From 31e2ee151bb6c938dfe6a983ce10a5a7b36c33a3 Mon Sep 17 00:00:00 2001
From: Jaswant Panchumarti <jaswant.panchumarti@kitware.com>
Date: Fri, 9 Aug 2024 11:09:57 -0400
Subject: [PATCH] Fix -Winconsistent-missing-override warning in
RenderingWebGPU module
- adds override at the end of `PrintSelf` function declarations
---
Rendering/WebGPU/vtkWebGPUComputeFrustumCuller.h | 2 +-
Rendering/WebGPU/vtkWebGPUComputeOcclusionCuller.h | 4 ++--
Rendering/WebGPU/vtkWebGPUComputeRenderTexture.h | 2 +-
Rendering/WebGPU/vtkWebGPUComputeTexture.h | 2 +-
Rendering/WebGPU/vtkWebGPUComputeTextureView.h | 2 +-
Rendering/WebGPU/vtkWebGPUTexture.h | 2 +-
Rendering/WebGPU/vtkWebGPUTextureView.h | 2 +-
7 files changed, 8 insertions(+), 8 deletions(-)
diff --git a/Rendering/WebGPU/vtkWebGPUComputeFrustumCuller.h b/Rendering/WebGPU/vtkWebGPUComputeFrustumCuller.h
index 86357727d0c..eb09ab379a4 100644
--- a/Rendering/WebGPU/vtkWebGPUComputeFrustumCuller.h
+++ b/Rendering/WebGPU/vtkWebGPUComputeFrustumCuller.h
@@ -38,7 +38,7 @@ public:
virtual double Cull(
vtkRenderer* ren, vtkProp** propList, int& listLength, int& initialized) override;
- void PrintSelf(ostream& os, vtkIndent indent);
+ void PrintSelf(ostream& os, vtkIndent indent) override;
protected:
vtkWebGPUComputeFrustumCuller();
diff --git a/Rendering/WebGPU/vtkWebGPUComputeOcclusionCuller.h b/Rendering/WebGPU/vtkWebGPUComputeOcclusionCuller.h
index 5edea1faf96..ad1ba3e0d8f 100644
--- a/Rendering/WebGPU/vtkWebGPUComputeOcclusionCuller.h
+++ b/Rendering/WebGPU/vtkWebGPUComputeOcclusionCuller.h
@@ -71,7 +71,7 @@ public:
vtkTypeMacro(vtkWebGPUComputeOcclusionCuller, vtkCuller);
static vtkWebGPUComputeOcclusionCuller* New();
- void PrintSelf(ostream& os, vtkIndent indent);
+ void PrintSelf(ostream& os, vtkIndent indent) override;
/**
* Sets which render window this occlusion culler is going to work on
@@ -81,7 +81,7 @@ public:
/**
* Culls props and returns the number of props that still need to be rendered after the culling
*/
- virtual double Cull(vtkRenderer* ren, vtkProp** propList, int& listLength, int& initialized);
+ double Cull(vtkRenderer* ren, vtkProp** propList, int& listLength, int& initialized) override;
protected:
vtkWebGPUComputeOcclusionCuller();
diff --git a/Rendering/WebGPU/vtkWebGPUComputeRenderTexture.h b/Rendering/WebGPU/vtkWebGPUComputeRenderTexture.h
index 16f3cc0fe2b..fd39c5c0af8 100644
--- a/Rendering/WebGPU/vtkWebGPUComputeRenderTexture.h
+++ b/Rendering/WebGPU/vtkWebGPUComputeRenderTexture.h
@@ -23,7 +23,7 @@ public:
vtkTypeMacro(vtkWebGPUComputeRenderTexture, vtkWebGPUComputeTexture);
static vtkWebGPUComputeRenderTexture* New();
- void PrintSelf(ostream& os, vtkIndent indent);
+ void PrintSelf(ostream& os, vtkIndent indent) override;
/**
* What type of texture of the vtk render pipeline is this ComputeRenderTexture refering to.
diff --git a/Rendering/WebGPU/vtkWebGPUComputeTexture.h b/Rendering/WebGPU/vtkWebGPUComputeTexture.h
index 723645703e4..7d8a557fa7d 100644
--- a/Rendering/WebGPU/vtkWebGPUComputeTexture.h
+++ b/Rendering/WebGPU/vtkWebGPUComputeTexture.h
@@ -31,7 +31,7 @@ public:
vtkTypeMacro(vtkWebGPUComputeTexture, vtkObject);
static vtkWebGPUComputeTexture* New();
- void PrintSelf(ostream& os, vtkIndent indent);
+ void PrintSelf(ostream& os, vtkIndent indent) override;
///@{
/**
diff --git a/Rendering/WebGPU/vtkWebGPUComputeTextureView.h b/Rendering/WebGPU/vtkWebGPUComputeTextureView.h
index 641ce111e20..c7625eb325d 100644
--- a/Rendering/WebGPU/vtkWebGPUComputeTextureView.h
+++ b/Rendering/WebGPU/vtkWebGPUComputeTextureView.h
@@ -16,7 +16,7 @@ public:
vtkTypeMacro(vtkWebGPUComputeTextureView, vtkObject);
static vtkWebGPUComputeTextureView* New();
- void PrintSelf(ostream& os, vtkIndent indent);
+ void PrintSelf(ostream& os, vtkIndent indent) override;
protected:
vtkWebGPUComputeTextureView();
diff --git a/Rendering/WebGPU/vtkWebGPUTexture.h b/Rendering/WebGPU/vtkWebGPUTexture.h
index d14dce11a32..707ef6b48d2 100644
--- a/Rendering/WebGPU/vtkWebGPUTexture.h
+++ b/Rendering/WebGPU/vtkWebGPUTexture.h
@@ -19,7 +19,7 @@ public:
vtkTypeMacro(vtkWebGPUTexture, vtkObject);
static vtkWebGPUTexture* New();
- void PrintSelf(ostream& os, vtkIndent indent);
+ void PrintSelf(ostream& os, vtkIndent indent) override;
/**
* RGBA: Uses RGB + alpha. Default.
diff --git a/Rendering/WebGPU/vtkWebGPUTextureView.h b/Rendering/WebGPU/vtkWebGPUTextureView.h
index 7f7d2974911..0733ca07165 100644
--- a/Rendering/WebGPU/vtkWebGPUTextureView.h
+++ b/Rendering/WebGPU/vtkWebGPUTextureView.h
@@ -20,7 +20,7 @@ public:
vtkTypeMacro(vtkWebGPUTextureView, vtkObject);
static vtkWebGPUTextureView* New();
- void PrintSelf(ostream& os, vtkIndent indent);
+ void PrintSelf(ostream& os, vtkIndent indent) override;
/**
* What will the shader sample from the texture when calling a sampling function.
--
GitLab