Done now, in !9857 (merged). Sorry for the delay. I have been not responsive to by emails for a long while.
About !9857 (merged), I think I will need help from Kitware experts, because I am struggling with the CI, whereas the patch is pretty simple.
@ben.boeckel @mwestphal I think I need help.
Because of the conflicts, that will be difficult to rebase this MR on paraview/release
or 9.2.x
.
Laurent Rineau (4d8283bc) at 23 Feb 09:44
More #include <cstdint> to compile with gcc13
... and 1 more commit
Laurent Rineau (d11154db) at 23 Feb 09:39
Merge branch 'master' into 'gcc13'
... and 2520 more commits
Do: reformat
Laurent Rineau (9fcf9c3b) at 23 Feb 09:35
More #include <cstdint> to compile with gcc13
The tests result (https://gitlab.kitware.com/lrineau/vtk/-/pipelines/314686) show reds, but they all seem to be already red in the tests for master
.
Laurent Rineau (ef95422b) at 18 Jan 09:52
Add #include <cstdint> to compile with gcc13
Laurent Rineau at 18 Jan 09:49
@ben.boeckel @dgobbi @mwestphal
As you have seen, I am not really used to the guidelines for contributing to VTK. Sorry for the spam by the Kitware bot.
The vtkSEPReader
was introduced by MRs !4909 (merged) (from my former collaborator Maxime) and !4938 (merged). Then it was highly modified by !7516 (merged). The later MR is the one that introduced the uses of uint8_t
and uint32_t
.
I just force-pushed a new version of the commit, and hopefully that one will be right.
Laurent Rineau (481e10e9) at 18 Jan 09:20
Add #include <cstdint> to compile with gcc13
Laurent Rineau (7dbdb0f1) at 18 Jan 09:19
Add #include <cstdint> to compile with gcc13
Laurent Rineau (fcabb39a) at 17 Jan 10:33
Add #include <cstdint> to compile with gcc13
Laurent Rineau (e1f4c9a4) at 17 Jan 10:28
Apply clang-format
Do: reformat
@opoplawski You can add https://gitlab.kitware.com/vtk/vtk/-/merge_requests/9857.patch
as a patch.
Add #include <cstdint>
in IO/Image/vtkSEPReader.h
to compile with gcc13.
Fix #18782.
Laurent Rineau (e07cc344) at 17 Jan 10:19
Add #include <cstdint> to compile with gcc13
... and 13835 more commits
@opoplawski Hi, I am also a Fedora packager, for CGAL.
I can reproduce the issue with a fedpkg mockbuild --root fedora-rawhide-x86_64
. That is a missing #include
. I will contribute a merge-request soon.
diff -up /builddir/build/BUILD/VTK-9.2.5/IO/Image/vtkSEPReader.h.cstdint-orig /builddir/build/BUILD/VTK-9.2.5/IO/Image/vtkSEPReader.h
--- /builddir/build/BUILD/VTK-9.2.5/IO/Image/vtkSEPReader.h.cstdint-orig 2023-01-17 16:02:46.082573616 +0100
+++ /builddir/build/BUILD/VTK-9.2.5/IO/Image/vtkSEPReader.h 2023-01-17 16:03:17.307677446 +0100
@@ -27,6 +27,7 @@
#include <array> // for std::array
#include <string> // for std::string
+#include <cstdint>
namespace details
{