Ben Boeckel authored Jun 30, 2022 and Kitware Robot committed Jun 30, 2022

2ccdae98 typos: fix `nothin` slang usage
d2d9f7d4 warnings: remove usage of `std::binary_function`
a3d59cde vtkCGNSReader: remove dead code
821f8f53 vtkPLagrangianParticleTracker: ensure that source and size are initialized
454fc734 vtkPythonInterpreter: use `size_t` to iterate over a vector
2945af89 vtkDistanceRepresentation3D: simplify conditional
f66efa90 vtkHyperTreeGridPProbeFilter: avoid shadowing
40bfdfac

 vtkm: return handle by move in DataArrayConverters
...
Acked-by: Kitware Robot <kwrobot@kitware.com>
Merge-request: !9330

Ben Boeckel authored Jun 30, 2022 and Kitware Robot committed Jun 30, 2022

736b4082

 std::swap: use `std::swap` instead of manual macro implementations
Acked-by: Kitware Robot <kwrobot@kitware.com>
Merge-request: !9325

Sujin Philip authored Jun 30, 2022 and Kitware Robot committed Jun 30, 2022

0d9fdb0b Increase the timeout for `fedora34-tidy`
9419e060

 Suppress tidy warning `modernize-use-equals-default`
Acked-by: Kitware Robot <kwrobot@kitware.com>
Merge-request: !9328

David Gobbi authored Jun 30, 2022 and Kitware Robot committed Jun 30, 2022

5196a595

 Update the ref to vtkDICOM remote module
Acked-by: Kitware Robot <kwrobot@kitware.com>
Merge-request: !9324

David Gobbi authored Jun 30, 2022 and Kitware Robot committed Jun 30, 2022

5196a595

 Update the ref to vtkDICOM remote module
Acked-by: Kitware Robot <kwrobot@kitware.com>
Merge-request: !9324

Mathieu Westphal authored Jun 30, 2022 and Kitware Robot committed Jun 30, 2022

d04a2187 ci: don't mask failing targets
51da08a8

 gitlab-ci: show a warning in the pipeline when detected
Acked-by: Kitware Robot <kwrobot@kitware.com>
Acked-by: Timothee Chabat <timothee.chabat@kitware.com>
Acked-by: Ben Boeckel <ben.boeckel@kitware.com>
Merge-request: !9288

Thomas Galland authored Jun 30, 2022 and Kitware Robot committed Jun 30, 2022

c3ec685a

 Uniformize vtkPlot API
Acked-by: Kitware Robot <kwrobot@kitware.com>
Merge-request: !9320

David Gobbi authored Jun 30, 2022 and Kitware Robot committed Jun 30, 2022

ee2c9bff

 Properly wrap array reference parameters
Acked-by: Kitware Robot <kwrobot@kitware.com>
Acked-by: Charles Gueunet <charles.gueunet@kitware.com>
Merge-request: !9331

If multiple targets are built, any breaking should fail the build, so
stop when any of them fail. Otherwise a further target that passes would
mask the prior failure.

The build is frequently timing out.

We don't use `= default` in certain VTK-m based code as `nvcc` does not
allow it and produces the following warning:

"__deviceddd__/__host__ annotation is ignored on a function that is explicitly defaulted on its first declaration"

Sean McBride authored Jun 30, 2022 and Kitware Robot committed Jun 29, 2022

6edc5f80

 Fixed more warnings from cdash
Acked-by: Kitware Robot <kwrobot@kitware.com>
Merge-request: !9297

Spiros Tsalikis authored Jun 29, 2022 and Kitware Robot committed Jun 29, 2022

b608770c

 Common/DataModel/Testing: avoid ODR violations of helper functions
Acked-by: Kitware Robot <kwrobot@kitware.com>
Acked-by: Ben Boeckel <ben.boeckel@kitware.com>
Merge-request: !9333

Spiros Tsalikis authored Jun 29, 2022 and Kitware Robot committed Jun 29, 2022

b608770c

 Common/DataModel/Testing: avoid ODR violations of helper functions
Acked-by: Kitware Robot <kwrobot@kitware.com>
Acked-by: Ben Boeckel <ben.boeckel@kitware.com>
Merge-request: !9333

Specifically, fixes:

/Common/DataModel/vtkDataSet.cxx:1075:44: warning: constructor parameter 'BitSet' shadows the field 'BitSet' of 'IsAnyBitSetFunctor' [-Wshadow-field-in-constructor]
  IsAnyBitSetFunctor(vtkUnsignedCharArray* BitSet, int BitFlag)
                                           ^
/Common/DataModel/vtkDataSet.cxx:1075:56: warning: constructor parameter 'BitFlag' shadows the field 'BitFlag' of 'IsAnyBitSetFunctor' [-Wshadow-field-in-constructor]
  IsAnyBitSetFunctor(vtkUnsignedCharArray* BitSet, int BitFlag)

/Filters/General/vtkFiniteElementFieldDistributor.cxx:819:43: warning: comparison of integers of different signs: 'std::vector<std::vector<double>>::size_type' (aka 'unsigned long') and 'const int' [-Wsign-compare]
        reqInit |= (*hCurlMats)[i].size() != npts;
                   ~~~~~~~~~~~~~~~~~~~~~~ ^  ~~~~
/Filters/General/vtkFiniteElementFieldDistributor.cxx:820:42: warning: comparison of integers of different signs: 'std::vector<std::vector<double...

Gaspard Thevenon authored Jun 29, 2022 and Kitware Robot committed Jun 29, 2022

c4874d9b

 Replace vtkOpenGLRenderWindow noise texture by blue noise
Acked-by: Kitware Robot <kwrobot@kitware.com>
Merge-request: !9327

Found by GCC 12.

Fixes: #18581

This small change allows wrapping of "T (&a)[N]" array parameters,
such as "float (&a)[3]" or "char (&a)[256]".   These are now
wrapped as size-checked Python-sequence to C++-array conversions.

Ben Boeckel authored Jun 28, 2022 and Kitware Robot committed Jun 28, 2022

444d6f76 Merge branch 'upstream-fmt' into fmtlib-cherry-pick-warnings
733b73bb fmt 2022-06-22 (90d87583)
121585b9

 bumped fmt to vtk-20220621-8.1.1
Acked-by: Kitware Robot <kwrobot@kitware.com>
Acked-by: Ben Boeckel <ben.boeckel@kitware.com>
Merge-request: !9316

This type is gone in C++17. Instead, just use lambdas and static
functions.

It doesn't need to check for `nullptr`.

Also require a trailing semicolon.

This fixes `clang-format` behavior around some usages but also makes
macro usage a lot more consistent.