GitLab

I was using a tolerance of 0.001 near the apex of the pyramid
relative to a distance squared for the interior check but elsewhere
I was doing a tolerance of 0.001 for the absolute value of
the distance so I squared the 0.001 tolerance to be consistent
with the interior check for the other parts of the cell.
Note that due to the degenerate nature of the pyramid cell we
do a specialized interior check near the apex.
Thanks to Kathleen S. Biagas for the bug report and fix.

Change-Id: I7580fa04539b159ceac12385e2ac3d795906dc01

3e275cfd Replaced invalid casts with memcpy
a38c3e45 Moved and renamed macros from .cxx to .h
32dcb78d Replaced invalid casts with memcpy
5d9d895b Removed dead code in private tableVert and tableDeg classes
931fc218 Moved ROUND_SIZE macro into '#ifdef __CUDACC__' condition
9d8ebea8 Removed unused NMAX macro (constant)
7184f767 Removed unused TEST macro
40201954 Removed unused sign macro
0368f481 Removed unused VTK_CREATE macro
9bb5e01f Removed unused vtkVRCMultiplyViewPointMacro macro
71c5784e Removed unused vtkStackedMIN and vtkStackedMAX macros
404c387f Removed unused min and max macros
2c121cee Removed unused MIN and MAX macros
44d6c749 Removed unused MY_MIN and MY_MAX macros
b34d99c9 Removed unused vtkTTFEQUAL macro
e3b4dcfa Removed unused macros
...

b78f8054 Put GetPixelInformation() variant in VTK_LEGACY
6f8741a8 Stop using deprecated variant of GetPixelInformation
4049603d Put SetScalars() in VTK_LEGACY
ac24b781 Put RenderString() in VTK_LEGACY
5c29b2ca Wrapped deprecated constants in #ifndef VTK_LEGACY_REMOVE

9c5c2a16 Replaced all "VTK_LARGE_ID" with "VTK_ID_MAX"
35c44ca1 Replaced "-VTK_LARGE_ID-1" with "VTK_ID_MIN"
a69493b5 Added VTK_ID_MIN and VTK_ID_MAX constants

The comments say its deprecated, put it in
VTK_LEGACY.

Previous commit updated VTK's own usage to
the non-deprecated variants.

Change-Id: I05b2e575bb03179b35d26d7439076674107195ae

Replace it with non-deprecated version.

Change-Id: Ia8392b395a0140796b6340a6724bf09f0a1263d4

The comments say its deprecated, put it in
VTK_LEGACY.  API seems unused in VTK itself.

Change-Id: Ic619f1c8cdc75c255addb2d3da9a873808b451eb

The comments say its deprecated, put it in
VTK_LEGACY.  API seems unused in VTK itself.

Change-Id: If043e635408a89b01a1186307e9fa8c2dd627d71

The comments say they are deprecated,
and they are unused in the codebase.

Change-Id: I88d85fabb3ef16f2980877af21380fd8694dc321

A few places were reinterpreting byte aligned memory
as larger types like int, float, or double.

Use memcpy, which can do this kind of thing safely.

Fixes -Wcast-align warnings.

Change-Id: Ib480b4f12fb0fab5b672ed7acd83ab30ef094ad8

These 4 macros are documented to be
return values of public APIs, so moved
from .cxx to .h.

Also renamed them with VTK_ prefix
since they are in the global namespace.

Fixes -Wunused-macro warnings.

Change-Id: I7cb7e4444a49a558b8cdf16cce4d84565445b00f

A few places were reinterpreting byte aligned memory
as larger types like int, float, or double.

Use memcpy, which can do this kind of thing safely.

Fixes -Wcast-align warnings.

Change-Id: I93cdb897384f70c568a9a7ca8afbd3983ca502b9

Identified with -Wunused-member-function.
Improves coverage a little.

Change-Id: I42804da51ff74838b641720ba15ae1b2832ada71

It's only used within the '#ifdef __CUDACC__'
condition.  Silences -Wunused-macros warning.

Change-Id: I0fcf782099318cb97ab956d9baabd9dbb31b17a0

It's not used anywhere.
Found this dead code using -Wunused-macros.

Change-Id: I3c01119b09db431f6a719e52da22f33dbbdf9213

Found this dead code using -Wunused-macros.

Change-Id: I53c341d590eccd4d3d0093a0fd57d66c3b82bdf4

It appears nowhere else in the file.
Found this dead code using -Wunused-macros.

Change-Id: Ib0f1571d29199acf30227c246dfe3d85b07b81b6

It appears nowhere else in the file,
but an identical macro appears in many other places,
making me think this is leftover copy-paste.
Found this dead code using -Wunused-macros.

Change-Id: Ib8ac3d8c4eb756b04147f7dcd029a0e8c75c0869

It's defined in two different files, but used nowhere!

Change-Id: Ica9235ae24e01c5dca473a8d9cc85f2c1095f70c

It appears nowhere else in the codebase.
Found this dead code using -Wunused-macros.

Change-Id: I01cc01b18c024c5cda0b9f92f21b47fea280b18f

They weren't very safely defined anyway.
Found this dead code using -Wunused-macros.

Change-Id: Idd5c64e52c4fc7b72cd649f162e76e07c295a774

Unused in this file.
Found this dead code using -Wunused-macros.

These are kinda dangerous to define anyway,
since macros of such names are often defined
and sometimes subtly differently.

Change-Id: Ie4aeee139f87061be0504c9295e421205adfcc51

Unused in this file.
Found this dead code using -Wunused-macros.

Change-Id: Ide4a3102b64b243f6806ffed9865cf6ba9a5e543

It appears nowhere else in the codebase.
Found this dead code using -Wunused-macros.

Change-Id: I7db677c2b4367040d53602c336f31fc556dfd469

They appear nowhere else in the codebase.
Found this dead code using -Wunused-macros.

Change-Id: I2f44e64356fa8a41bdb17885c6ae2d21ea2e23a3

It appears nowhere else in the codebase.
Found this dead code using -Wunused-macros.

Change-Id: Ifbf09b46a7de7952e9961521726dda6c2c92100a

Looks like leftover refactoring.

Change-Id: I2fd5720950f11794e34cff844b8e36aab136110b

Identical copy of macro was there twice.

Change-Id: I05aa0fd42c312c019c70da283f05b29da9f2497c

They appear nowhere else in the codebase.
Found this dead code using -Wunused-macros.

Change-Id: I0100e6d427cc762abc3ba734e7609998ea9759c2

They appear nowhere else in the codebase.
Found this dead code using -Wunused-macros.

Change-Id: I1186e349eba2a5de8589191e33d1e225fd7c0e0e

It appears nowhere else in the codebase.
Looks like refactoring leftovers.
Found this dead code using -Wunused-macros.

Change-Id: I00f608f26f9eada928a6c910786a6fe218d3dd82

It appears nowhere else in the codebase.
Found this dead code using -Wunused-macros.

Change-Id: I1cbd97cd6905b5fd8dae878ef1a099522b9153e8

It appears nowhere else in the codebase.
Found this dead code using -Wunused-macros.

There's an off chance, I suppose, that it
is expected by a system header, but I
don't think so.

Change-Id: Ib306770cd9c2aab05866f2bbdabb6f1aba2d435c

It appears nowhere else in the codebase.
Found this dead code using -Wunused-macros.

Change-Id: Ifbd9ab7954463d6b00e3a38ce464b4be5f74eb4d

They are only used in commented out code.
Moved into comment.
(Really this should use vtkMath anyway.)
Found this dead code using -Wunused-macros.

Change-Id: I4f4af4c6228455c4663ca8c603d4a053d36cff1b

It appears nowhere else in the codebase. Found this dead code using -Wunused-macros.

Change-Id: Iaa2fec28b6ccd1ae0f5f04746425a73c2dfd1973

It appears nowhere else in the codebase. Found this dead code using -Wunused-macros.

Change-Id: I9e6f4ddbf2f1f00fc6c7ed5ca96bf1fed76038f1

It appears nowhere else in the codebase. Found this dead code using -Wunused-macros.

Change-Id: I66bc2a2ebab4c3e69aa47b9808b57926e50163bc

It appears nowhere else in the codebase.

Change-Id: Ib7375958086e8b60c48895830bbd5268ba8a3488

Macro unused in this file; already exists in vtkCoordinate.cxx.
Probably refactoring leftovers.

Change-Id: Ib2b935908e02c353dbed845786988e0fcb3d8f49