1. 22 Jul, 2016 1 commit
  2. 21 Jul, 2016 1 commit
    • Brad King's avatar
      Autogen: Revert changes to generate moc/rcc in subdirectories · 5e55d87b
      Brad King authored
      Revert these commits:
      
      * v3.6.0-rc1~134^2
        Tests: QtAutogen: Same source name in different directories test, 2016-04-13
      * v3.6.0-rc1~134^2~1
        Autogen: Generate qrc_NAME.cpp files in subdirectories, 2016-04-19
      * v3.6.0-rc1~134^2~2
        Autogen: Generate not included moc files in subdirectories, 2016-04-19
      
      They regress existing builds that depend on the paths/symbols generated
      previously.  Another approach will be needed to solve the name collision
      problem they were intended to solve.  Leave the error diagnostics for
      the colliding cases that were added in the same topic as the above
      commits because they provide a useful early failure in relevant cases.
      
      Fixes #16209.
      5e55d87b
  3. 19 Jul, 2016 1 commit
    • Brad King's avatar
      CPack: Add compatibility for incorrect CPACK_INSTALL_CMAKE_PROJECTS value · 57534990
      Brad King authored
      Since commit v3.6.0-rc1~339^2 (CPack: Fix CPACK_INSTALL_CMAKE_PROJECTS
      SubDirectory (4th) option, 2016-02-18) we now honor the "Directory"
      option of this variable.  Prior to that commit the value was not used
      so projects may have used a placeholder value like `.` instead of `/`.
      Treat `.` the same as `/` to restore compatibility with such projects.
      
      Fixes #16205.
      57534990
  4. 15 Jul, 2016 1 commit
  5. 13 Jul, 2016 1 commit
  6. 11 Jul, 2016 1 commit
    • Brad King's avatar
      Restore find_(library|file|path) search of PATH itself · 54475018
      Brad King authored
      The fix in commit commit v3.6.0-rc1~82^2 (Drop find_(library|file|path)
      prefixes from PATH on non-Windows, 2016-05-09) aggressively dropped
      search of the entries in PATH itself in addition to the prefixes derived
      from it.  This regresses find modules that (incorrectly) depended on the
      behavior, including some of our own modules such as FindImageMagick.
      
      Restore the search of entries in PATH itself.  If we want to drop it
      later we will need to do so with a policy.  Fixes #16192.
      54475018
  7. 07 Jul, 2016 1 commit
  8. 05 Jul, 2016 1 commit
  9. 29 Jun, 2016 1 commit
  10. 28 Jun, 2016 1 commit
    • Brad King's avatar
      Revert "try_compile: Honor CMAKE_<LANG>_FLAGS_<CONFIG> changes" · 943fe6e3
      Brad King authored
      Revert commit v3.6.0-rc1~160^2 (try_compile: Honor
      CMAKE_<LANG>_FLAGS_<CONFIG> changes, 2016-04-11).  The behavior it
      introduced can break projects that depend on the lack of such behavior.
      We will have to introduce a policy or other mechanism to enable the
      behavior in a compatible way.  Simply revert it for now.
      
      See issue #16174.
      943fe6e3
  11. 27 Jun, 2016 1 commit
    • Ben Boeckel's avatar
      ninja, rc: ignore CMAKE_NINJA_FORCE_RESPONSE_FILE for RC files · 15b3f6f0
      Ben Boeckel authored and Brad King's avatar Brad King committed
      In commit v3.6.0-rc1~174^2 (Ninja: Honor CMAKE_NINJA_FORCE_RESPONSE_FILE
      for compile rules, 2016-04-06), Ninja learned to look for
      `CMAKE_NINJA_FORCE_RESPONSE_FILE` in the current scope or the
      environment in order to force response file usage for all compilation
      rules.
      
      However, on Windows, the RC compiler goes through cmcldeps which does a
      `replace(output, output + ".dep.obj")` on the command line. However,
      with a response file (which we name `output + ".rsp"`), the response
      file path is replaced instead causing the compiler to (correctly)
      complain that the response file `output + ".dep.obj.rsp"` does not
      exist.
      
      What needs to happen is for cmcldeps to look through the response file,
      replace *its* contents and place it in the `output + ".dep.obj.rsp"`
      file.
      
      Also add a test which actually compiles an RC file into a library and
      executable for all generators on Windows and additionally test
      `CMAKE_NINJA_FORCE_RESPONSE_FILE` for Ninja generators.
      
      Fixes #16167.
      15b3f6f0
  12. 22 Jun, 2016 1 commit
  13. 17 Jun, 2016 2 commits
  14. 13 Jun, 2016 1 commit
  15. 09 Jun, 2016 1 commit
    • Robert Maynard's avatar
      cmake-gui: Teach Qt5 where plugins are when launched through a symlink · f2840155
      Robert Maynard authored and Brad King's avatar Brad King committed
      When we are on OSX and we are launching cmake-gui from a symlink, the
      application will fail to launch as it can't find the qt.conf file which
      tells it what the name of the plugin folder is. We need to add this path
      BEFORE the application is constructed as that is what triggers the
      searching for the platform plugins
      f2840155
  16. 02 Jun, 2016 1 commit
    • Brad King's avatar
      Fix crash on $<TARGET_PROPERTY:...,LOCATION> genex (#16134) · f500a784
      Brad King authored
      Policy CMP0026 deprecated the LOCATION property, and we have long
      provided a $<TARGET_FILE:...> generator expression.  However, if
      a project tries to use $<TARGET_PROPERTY:...,LOCATION> we should
      at least not crash.
      
      The compatibility implementation of the LOCATION property uses
      cmGlobalGenerator::CreateGenerationObjects to create the structures
      needed to evaluate the property before generation starts.  The
      implementation assumed that accessing the property could only be done
      during configuration (via the typical get_property command use case).
      The $<TARGET_PROPERTY:...,LOCATION> genex causes the LOCATION property
      to be accessed during generation.  Calling CreateGenerationObjects
      during generation blows away all the objects currently being used for
      generation and is not safe.  Add a condition to call it only when
      configuration is not finished.
      f500a784
  17. 01 Jun, 2016 4 commits
  18. 31 May, 2016 1 commit
  19. 30 May, 2016 1 commit
  20. 29 May, 2016 1 commit
  21. 28 May, 2016 1 commit
  22. 27 May, 2016 1 commit
  23. 26 May, 2016 4 commits
    • Daniel Pfeifer's avatar
      Remove redundant c_str() calls. · 1b2bb933
      Daniel Pfeifer authored
      Run clang-tidy's readability-redundant-string-cstr checker.
      Ignore findings in kwsys.
      1b2bb933
    • Daniel Pfeifer's avatar
      Remove unnecessary local copies. · 27ead963
      Daniel Pfeifer authored
      Use clang-tidy's performance-unnecessary-copy-initialization checker.
      After applying the fix-its (which turns the copies into const&), revise
      the changes and see whether the copies can be removed entirely by using
      the original instead.
      27ead963
    • Daniel Pfeifer's avatar
      Pass arguments that are not modified as const&. · 618fb23f
      Daniel Pfeifer authored
      Use clang-tidy's performance-unnecessary-value-param checker to find
      value parameter declarations of expensive to copy types that are not
      modified inside the function.  Ignore findings in kwsys.
      After applying the fix-its, manually change `const T&` to `T const&`.
      618fb23f
    • Kitware Robot's avatar
      CMake Nightly Date Stamp · 0746a4c6
      Kitware Robot authored
      0746a4c6
  24. 25 May, 2016 8 commits
  25. 24 May, 2016 2 commits
    • Daniel Pfeifer's avatar
      Improve string find: prefer character overloads. · 5784747d
      Daniel Pfeifer authored
      Apply fix-its from clang-tidy's performance-faster-string-find checker.
      Ignore findings in kwsys.
      5784747d
    • Daniel Pfeifer's avatar
      Use std::replace for replacing chars in strings. · 5cec953e
      Daniel Pfeifer authored
      Find uses of `cmSystemTools::ReplaceString` where both `replace` and
      `with` are string literals with a size of one.
      
      Automate with:
      
      git grep -l ReplaceString | xargs sed -i "s|cmSystemTools::ReplaceString(\([^,]*\), \"\(.\)\", \"\(.\)\");|std::replace(\1.begin(), \1.end(), '\2', '\3');|g"
      git grep -l ReplaceString | xargs sed -i "s|cmSystemTools::ReplaceString(\([^,]*\), \"\(.\)\", \"\\\\\\\\\");|std::replace(\1.begin(), \1.end(), '\2', '\\\\\\\\');|g"
      git grep -l ReplaceString | xargs sed -i "s|cmSystemTools::ReplaceString(\([^,]*\), \"\\\\\\\\\", \"\(.\)\");|std::replace(\1.begin(), \1.end(), '\\\\\\\\', '\2');|g"
      5cec953e