1. 22 Jul, 2016 1 commit
  2. 21 Jul, 2016 4 commits
    • Brad King's avatar
    • Brad King's avatar
    • Justin Clift's avatar
      NSIS: Quote uninstaller path when executing it in a shell · 11768733
      Justin Clift authored
      Protect our `$0` reference in the shell as `"$0"`.  Otherwise it works
      with a space in the path only due to an insecure Windows feature.
      Prior to this fix, any installer using the option added by commit
      2011-06-11) exposes a local privilege escalation vulnerability.
      Reported-by: default avatarAmir Szekely <kichik@gmail.com>
      Reported-by: Ug_0 Security
    • Brad King's avatar
      Autogen: Revert changes to generate moc/rcc in subdirectories · 5e55d87b
      Brad King authored
      Revert these commits:
      * v3.6.0-rc1~134^2
        Tests: QtAutogen: Same source name in different directories test, 2016-04-13
      * v3.6.0-rc1~134^2~1
        Autogen: Generate qrc_NAME.cpp files in subdirectories, 2016-04-19
      * v3.6.0-rc1~134^2~2
        Autogen: Generate not included moc files in subdirectories, 2016-04-19
      They regress existing builds that depend on the paths/symbols generated
      previously.  Another approach will be needed to solve the name collision
      problem they were intended to solve.  Leave the error diagnostics for
      the colliding cases that were added in the same topic as the above
      commits because they provide a useful early failure in relevant cases.
      Fixes #16209.
  3. 19 Jul, 2016 2 commits
  4. 15 Jul, 2016 2 commits
  5. 13 Jul, 2016 3 commits
  6. 12 Jul, 2016 3 commits
  7. 11 Jul, 2016 4 commits
  8. 07 Jul, 2016 1 commit
  9. 05 Jul, 2016 4 commits
  10. 30 Jun, 2016 5 commits
  11. 29 Jun, 2016 1 commit
  12. 28 Jun, 2016 4 commits
  13. 27 Jun, 2016 3 commits
    • Brad King's avatar
    • Ben Boeckel's avatar
      ninja, rc: ignore CMAKE_NINJA_FORCE_RESPONSE_FILE for RC files · 15b3f6f0
      Ben Boeckel authored
      In commit v3.6.0-rc1~174^2 (Ninja: Honor CMAKE_NINJA_FORCE_RESPONSE_FILE
      for compile rules, 2016-04-06), Ninja learned to look for
      `CMAKE_NINJA_FORCE_RESPONSE_FILE` in the current scope or the
      environment in order to force response file usage for all compilation
      However, on Windows, the RC compiler goes through cmcldeps which does a
      `replace(output, output + ".dep.obj")` on the command line. However,
      with a response file (which we name `output + ".rsp"`), the response
      file path is replaced instead causing the compiler to (correctly)
      complain that the response file `output + ".dep.obj.rsp"` does not
      What needs to happen is for cmcldeps to look through the response file,
      replace *its* contents and place it in the `output + ".dep.obj.rsp"`
      Also add a test which actually compiles an RC file into a library and
      executable for all generators on Windows and additionally test
      `CMAKE_NINJA_FORCE_RESPONSE_FILE` for Ninja generators.
      Fixes #16167.
    • Brad King's avatar
  14. 24 Jun, 2016 2 commits
  15. 23 Jun, 2016 1 commit