iMSTK issueshttps://gitlab.kitware.com/iMSTK/iMSTK/-/issues2022-06-29T09:48:49-04:00https://gitlab.kitware.com/iMSTK/iMSTK/-/issues/161Enable audio support for Linux and OS X2022-06-29T09:48:49-04:00Sreekanth ArikatlaEnable audio support for Linux and OS XCurrently, audio support is built by default on windows only. This could be extended to Linux and OS XCurrently, audio support is built by default on windows only. This could be extended to Linux and OS Xhttps://gitlab.kitware.com/iMSTK/iMSTK/-/issues/414Can't build TBB 2019 with gcc112022-06-29T09:38:53-04:00Harald ScheirichCan't build TBB 2019 with gcc11The TBB version that iMSKT currently uses `2019` can't be built with gcc 11 due to https://github.com/oneapi-src/oneTBB/issues/370
- we could try and apply the fix to our local version
- we could try and update TBBThe TBB version that iMSKT currently uses `2019` can't be built with gcc 11 due to https://github.com/oneapi-src/oneTBB/issues/370
- we could try and apply the fix to our local version
- we could try and update TBBhttps://gitlab.kitware.com/iMSTK/iMSTK/-/issues/426Cmake Settings for Imstk-Unity2022-06-24T08:19:57-04:00Harald ScheirichCmake Settings for Imstk-UnityWhen building for imstk Unity VTK and maybe some other dependencies should be turned offWhen building for imstk Unity VTK and maybe some other dependencies should be turned offHarald ScheirichHarald Scheirichhttps://gitlab.kitware.com/iMSTK/iMSTK/-/issues/395ViewerVTK & RenderingVTK Module Toggles2022-05-12T22:25:15-04:00Andrew WilsonViewerVTK & RenderingVTK Module TogglesNow that the libraries have been separated we may add a toggle for ViewerVTK & RenderingVTK which will allow one to build without these modules. Ultimately for using iMSTK as a physics backend only (a VTK without vtk rendering or differe...Now that the libraries have been separated we may add a toggle for ViewerVTK & RenderingVTK which will allow one to build without these modules. Ultimately for using iMSTK as a physics backend only (a VTK without vtk rendering or different rendering libs can be provided).https://gitlab.kitware.com/iMSTK/iMSTK/-/issues/169Assimp build issue with 3.3.12022-04-20T09:33:17-04:00Alexis GiraultAssimp build issue with 3.3.1Issue introduced here when using Assimp 3.3.1: https://gitlab.kitware.com/iMSTK/iMSTK/commit/34170af1540b9d7a16d296636bf62016eff8d99c#note_350649
On mac, I now can't build with the following error:
```
/Users/agirault/Projects/imstk/re...Issue introduced here when using Assimp 3.3.1: https://gitlab.kitware.com/iMSTK/iMSTK/commit/34170af1540b9d7a16d296636bf62016eff8d99c#note_350649
On mac, I now can't build with the following error:
```
/Users/agirault/Projects/imstk/rel/External/Assimp/src/code/D3MFImporter.cpp:230:29: error: invalid operands to binary expression ('float (*)(const char *, const char *)' and 'nullptr_t')
vertex.z = ai_strtof>(xmlReader->getAttributeValue(D3MF::XmlTag::z.c_str()), nullptr);
~~~~~~~~~^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
```
Bug is here: https://github.com/assimp/assimp/blob/v3.3.1/code/D3MFImporter.cpp#L230
Not sure why dashboard are fine, for any platform.
@NickMilef @sreekanth-arikatla @jbvimort I remember talking about upgrading to [Assimp 4.0.1](https://github.com/assimp/assimp/tree/v4.0.1) at some point. Do you remember the reason why we didn't?https://gitlab.kitware.com/iMSTK/iMSTK/-/issues/265Download the data optionally at the build2022-04-20T08:26:25-04:00Sreekanth ArikatlaDownload the data optionally at the buildBuild should not be held for the downloadBuild should not be held for the downloadhttps://gitlab.kitware.com/iMSTK/iMSTK/-/issues/372Build without OpenVR support2022-04-12T16:46:28-04:00Connor BowleyBuild without OpenVR supportFor projects that don't need OpenVR, it would be useful to have a build flag to turn off OpenVR support and not require OpenVR in the build process.For projects that don't need OpenVR, it would be useful to have a build flag to turn off OpenVR support and not require OpenVR in the build process.https://gitlab.kitware.com/iMSTK/iMSTK/-/issues/273iMSTK Uncrustify stealth dependency on PythonInterp2022-01-07T01:15:13-05:00Johan AndruejoliMSTK Uncrustify stealth dependency on PythonInterpUncrustify requires [PythonInterp](https://github.com/uncrustify/uncrustify/blob/23184091f66c5ba8434da08639cb2cdde77dfeb1/CMakeLists.txt#L20) though it's never prescribed by iMSTK itself anywhere.
This creates a confusing build failure...Uncrustify requires [PythonInterp](https://github.com/uncrustify/uncrustify/blob/23184091f66c5ba8434da08639cb2cdde77dfeb1/CMakeLists.txt#L20) though it's never prescribed by iMSTK itself anywhere.
This creates a confusing build failure in the superbuild if you system doesn't have python.
Worse, this may work against you by linking to whatever python you have on your system without you knowing **which** one.
Possible fix:
iMSTK should probably add a ```find_package(PythonInterp REQUIRED)``` to [External_Uncrustify.cmake](https://gitlab.kitware.com/iMSTK/iMSTK/-/blob/master/CMake/External/External_Uncrustify.cmake) and make sure to pass the proper vars to Uncrustify if possible.
That would at least ensure that the missing python libraries get caught at configure time.https://gitlab.kitware.com/iMSTK/iMSTK/-/issues/209.dll copy issue when system build of a dependency is used2022-01-07T01:04:43-05:00Sreekanth Arikatla.dll copy issue when system build of a dependency is usedAt CMake configure time, if an existing build of the imstk dependent library is used, the .dll files are not copied to the bin folder where the executables reside post-build.At CMake configure time, if an existing build of the imstk dependent library is used, the .dll files are not copied to the bin folder where the executables reside post-build.https://gitlab.kitware.com/iMSTK/iMSTK/-/issues/332Linux Build Issues2021-07-06T09:10:10-04:00Harald ScheirichLinux Build IssuesStill working on improving the linux dashboard builds
- [x] Debug build compile error
- [x] Debug build link error (!612)
- [x] Dashboard test issuesStill working on improving the linux dashboard builds
- [x] Debug build compile error
- [x] Debug build link error (!612)
- [x] Dashboard test issuesHarald ScheirichHarald Scheirichhttps://gitlab.kitware.com/iMSTK/iMSTK/-/issues/336iMSTKConfig Should be Appending CMAKE_MODULE_PATH2021-07-03T18:32:18-04:00Andrew WilsoniMSTKConfig Should be Appending CMAKE_MODULE_PATHDon't have time to test right now but leaving this here for later.
I'm pretty sure the iMSTKConfig.cmake file should be appending or only temporarily setting the CMAKE_MODULE_PATH, not overwriting it. It causes problems when users set i...Don't have time to test right now but leaving this here for later.
I'm pretty sure the iMSTKConfig.cmake file should be appending or only temporarily setting the CMAKE_MODULE_PATH, not overwriting it. It causes problems when users set it in their external project. This variable is a cmake one used as a search path by cmake "include". By setting it in the config it overwrites the user's CMAKE_MODULE_PATH when find_package(iMSTK) is called. Whatever the user then had is erased and all their include's break.
(The reason the iMSTKConfig.cmake sets the module path to begin with is because certain cmake includes are used in iMSTK's cmake code)
The solution would be:
Appending: https://gitlab.kitware.com/iMSTK/iMSTK/-/blob/master/CMake/iMSTKConfig.cmake.in#L19 should be list(APPEND CMAKE_MODULE_PATH "${CMAKE_CURRENT_LIST_DIR}/modules").
Temporarily Set: Save the current CMAKE_MODULE_PATH, set it for iMSTKConfig.cmake, then at the end, set it back to the one before config ran.
I'm thinking it should be temp set. The difference is whether iMSTK's cmake code should be on the user's module path, accessible by the external project or not. Names could conflict in user cmake files vs iMSTK's (or even finds). It would make more sense to just provide iMSTK's cmake code via another variable that the user could then optionally include on their cmake path.
Example of failure in external project (of course one could reorder these calls as a temp fix):
```
list(APPEND CMAKE_MODULE_PATH ${CMAKE_SOURCE_DIR}/cmake)
find_package(iMSTK REQUIRED)
include(ClangFormat) # Can't be found!
...
```https://gitlab.kitware.com/iMSTK/iMSTK/-/issues/248External Use Shader Location Invalid2021-06-01T13:13:15-04:00Andrew WilsonExternal Use Shader Location InvalidShaders are not found when using imstk externally. Simulation runs fine, but nothing is displayed and VTK shader errors are thrown.Shaders are not found when using imstk externally. Simulation runs fine, but nothing is displayed and VTK shader errors are thrown.https://gitlab.kitware.com/iMSTK/iMSTK/-/issues/239Using system builds of dependencies fails2020-07-31T13:04:54-04:00Sreekanth ArikatlaUsing system builds of dependencies failshttps://gitlab.kitware.com/iMSTK/iMSTK/-/issues/241superbuild fails at physx external project2020-03-13T09:43:39-04:00Sreekanth Arikatlasuperbuild fails at physx external projecthttps://gitlab.kitware.com/iMSTK/iMSTK/-/issues/240Timeout in external data download2020-02-24T14:29:34-05:00Sreekanth ArikatlaTimeout in external data downloadThe volume rendering data set fails to download as it times out even after setting no limits on timeThe volume rendering data set fails to download as it times out even after setting no limits on timehttps://gitlab.kitware.com/iMSTK/iMSTK/-/issues/221CMake 3.14x build issue2019-12-20T16:18:02-05:00Sreekanth ArikatlaCMake 3.14x build issueCMake 3.14X has an issue with mismatching x86 and x64 build config for dependenciesCMake 3.14X has an issue with mismatching x86 and x64 build config for dependenciesRelease 2.0.0https://gitlab.kitware.com/iMSTK/iMSTK/-/issues/232Group multiple projects into folders in msvc2019-08-03T18:26:15-04:00Sreekanth ArikatlaGroup multiple projects into folders in msvchttps://stackoverflow.com/questions/41078807/cmake-and-visualstudio-group-files-in-solution-explorerhttps://stackoverflow.com/questions/41078807/cmake-and-visualstudio-group-files-in-solution-explorerhttps://gitlab.kitware.com/iMSTK/iMSTK/-/issues/217Asian Dragon example mesh is not updating properly2019-04-28T17:03:04-04:00Nicholas MilefAsian Dragon example mesh is not updating properlyThe config SHA file seems to be invalid. The keys don't match :(.The config SHA file seems to be invalid. The keys don't match :(.https://gitlab.kitware.com/iMSTK/iMSTK/-/issues/182Add multithreaded compilation2018-10-17T13:33:17-04:00Nicholas MilefAdd multithreaded compilationThe build process is very slow, particularly for VTK. To improve the performance, we should add the /MP compiler option via CMake.The build process is very slow, particularly for VTK. To improve the performance, we should add the /MP compiler option via CMake.https://gitlab.kitware.com/iMSTK/iMSTK/-/issues/178Add an option to build imstk without rendering module2018-09-15T12:15:58-04:00Sreekanth ArikatlaAdd an option to build imstk without rendering module1. Add cmake options to not build any rendering backend at configure time
2. Even if the rendering is configured at build time, the user should let simulation manager know that no rendering is needed and the simulation manager should dis...1. Add cmake options to not build any rendering backend at configure time
2. Even if the rendering is configured at build time, the user should let simulation manager know that no rendering is needed and the simulation manager should disable render context.