Commit 3df75ed1 authored by Sean McBride's avatar Sean McBride
Browse files

Fixed misc cppcheck warnings:

- warning about not rethrowing
- added extra parens
- warning about iterator misuse
- unused variable
parent 171efbea
...@@ -157,8 +157,7 @@ void IntersectWithCell(unsigned nTest, ...@@ -157,8 +157,7 @@ void IntersectWithCell(unsigned nTest,
int TestIntersectWithLine(int argc, char* argv[]) int TestIntersectWithLine(int argc, char* argv[])
{ {
std::ostringstream vtkmsg_with_warning_C4701; std::ostringstream strm;
ostream& strm = vtkmsg_with_warning_C4701;
strm << "Test vtkCell::IntersectWithLine Start" << endl; strm << "Test vtkCell::IntersectWithLine Start" << endl;
vtkSmartPointer<vtkRenderWindow> renderWindow = vtkSmartPointer<vtkRenderWindow> renderWindow =
......
...@@ -38,7 +38,6 @@ vtkAMRDataSetCache::~vtkAMRDataSetCache() ...@@ -38,7 +38,6 @@ vtkAMRDataSetCache::~vtkAMRDataSetCache()
{ {
iter->second->Delete(); iter->second->Delete();
} }
this->Cache.erase( iter );
} }
} }
......
...@@ -106,7 +106,7 @@ void vtkUTF8TextCodec::ToUnicode(istream& InputStream, ...@@ -106,7 +106,7 @@ void vtkUTF8TextCodec::ToUnicode(istream& InputStream,
} }
else else
{ {
throw ef; throw;
} }
} }
} }
......
...@@ -121,7 +121,7 @@ static bool CheckStencilExtents( ...@@ -121,7 +121,7 @@ static bool CheckStencilExtents(
j >= stencilExt[2] && j <= stencilExt[3] && j >= stencilExt[2] && j <= stencilExt[3] &&
k >= stencilExt[4] && k <= stencilExt[5]) k >= stencilExt[4] && k <= stencilExt[5])
{ {
match &= !inside ^ (*p > 127); match &= (!inside) ^ (*p > 127);
} }
else else
{ {
......
Supports Markdown
0% or .
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment