- 20 Sep, 2021 5 commits
-
-
c0eb7138 Instatiations: fix paths templates inside project Acked-by:
Kitware Robot <kwrobot@kitware.com> Acked-by:
Li-Ta Lo <ollie@lanl.gov> Merge-request: !2583
-
Vicente Bolea authored
When VTKm is used inside another CMAKE project the instatitations will include its filers with the relative path from the top lever of the parent project instead of the top level of the VTKm project. This commit resolves that.
-
166e76f6 implement tbb runtime device configuration testing 9baa7cd9 Implement tbb runtime device configuration and update vtkm to use it Acked-by:
Kenneth Moreland <morelandkd@ornl.gov> Merge-request: !2574
-
-
-
- 17 Sep, 2021 3 commits
-
-
4c6522de Precompile ConvertNumComponentsToOffsets b1343474 Consolidate count-to-offset algorithms Acked-by:
-
964ef29e Suppress warning when logging is turned off Acked-by:
Vicente Bolea <vicente.bolea@kitware.com>
Merge-request: !2581 -
Kenneth Moreland authored
There was a case where a VTK-m exception was caught and then used in a logging message. That is fine, but if VTK-m logging is turned off, that code is removed and the exception variable goes unused. There was a time when it was common to have logging turned off in VTK-m, but now it is almost always on. There is one old-style dashboard that has logging turned off and is giving a warning about this variable not being used. It went unnoticed because the dashboard was down at the time. This should fix the issue.
-
- 16 Sep, 2021 3 commits
-
-
277c3360 implement openmp runtime device configuration testing 1c4d6810 implement openmp runtime device configuration and update code to use it Acked-by:
-
Kenneth Moreland authored
`ConvertNumComponentsToOffsets` has been changed to provide a pre- compiled version for common arrays. This helps with the dual goals of compiling less device code and allowing data set builders to not have to use the device compiler. For cases where you need to compile `ConvertNumComponentsToOffsets` for a different kind of array, you can use the internal `ConvertNumComponentsToOffsetsTemplate`.
-
Kenneth Moreland authored
For no particularly good reason, there were two functions that converted and array of counts to an array of offsets: `ConvertNumComponentsToOffsets` and `ConvertNumIndicesToOffsets`. These functions were identical, except one was defined in `ArrayHandleGroupVecVariable.h` and the other was defined in `CellSetExplicit.h`. These two functions have been consolidated into one (which is now called `ConvertNumComponentsToOffsets`). The consolidated function has also been put in its own header file: `ConvertNumComponentsToOffsets.h`. Normally, backward compatibility would be established using deprecated features. However, one of the things being worked on is the removal of device-specific code (e.g. `vtkm::cont::Algorithm`) from core classes like `CellSetExplicit` so that less code needs to use the device compiler (especially downstream code). Part of this change removed unnecessary includes of `Algorithm.h` in `ArrayHandleGroupVecVariable.h` and `CellSetExplicit.h`. This header had to be added to some classes that were not including it themselves.
-
- 15 Sep, 2021 2 commits
-
-
Nickolas Davis authored
-
Nickolas Davis authored
-
- 09 Sep, 2021 2 commits
-
-
0e6228bb Updating threshold to return all or part in range. d28bdec4 Merge remote-tracking branch 'upstream/master' f42d73fa Merge remote-tracking branch 'upstream/master' 74c4d347 Merge remote-tracking branch 'upstream/master' Acked-by:
-
4239d13b Make triangulate implementation more general 1bd70d9c Enable triangulation on CellSetSingleType Acked-by:
-
- 08 Sep, 2021 6 commits
-
-
5191909b Fix MeshQuality to work with CellSetSingleType ecf36ed3 Fix compile errors in CellSetSingleType::CompleteAddingCells Acked-by:
-
32870353 Remove use of deprecated items from StreamlineMPI example 264a8a4b Remove dependence of examples on testing files Acked-by:
Nickolas Davis <nadavi@sandia.gov> Merge-request: !2571
-
Kenneth Moreland authored
The triangulate and tetrahedra worklet implementations were for some reason grabbing raw arrays out of `CellSetExplicit` and using those for lookup tables. Rather than do that, simply use a `WorkletVisitCellsWithPoints` automatically provide the values of these cells. The advantage of this approach is that it simplifies the code and also generalize it to cell sets that do not provide this explicit representation. For example, the new implementation also works with `CellSetExtrude`.
-
Kenneth Moreland authored
The code path for doing either tetrahedralization or triangulation on a CellSetSingleType was not actually doing any work. Changed the worklet implementation so that these work on CellSetExplicit with any template parameters (which includes CellSetSingleType).
-
Kenneth Moreland authored
-
Kenneth Moreland authored
The testing files (even the headers) are not available if `VTKm_ENABLE_TESTING` is off. Mostly, the testing was used to generate example data sets. Instead, change the examples to load data files.
-
- 02 Sep, 2021 9 commits
-
-
a2a8dcdf Allow a `const ArrayHandle` to be reallocated Acked-by:
-
8704ff25 Removing host/device being called from device warning f0d267e8 Adding WarpX particle advection streamlines Acked-by:
-
5530d86e update cuda examples to use RuntimeDeviceConfiguration eaba4072 Call GetRuntimeConfiguration before GetRuntimeDeviceTracker in Initialize 9730de80 remove cudaGetDevice calls, favor runtime device config adac415f implement cuda runtime device configuraton Acked-by:
-
Kenneth Moreland authored
Previously, the `Allocate` method of `ArrayHandle` was _not_ declared as `const`. Likewise, the methods that depended on `Allocate`, namely `ReleaseResources` and `PrepareForOutput` were also not declared `const`. The main consequence of this was that if an `ArrayHandle` were passed as a constant reference argument to a method (e.g. `const ArrayHandle<T>& arg`), then the array could not be reallocated. This seems right at first blush. However, we have changed these methods to be `const` so that you can in fact reallocate the `ArrayHandle`. This is because the `ArrayHandle` is in principle a pointer to an array pointer. Such a structure in C will allow you to change the pointer to the array, and so in this context it makes sense for `ArrayHandle` to support that as well. Although this distinction will certainly be confusing to users, we think this change is correct for a variety of reasons. 1. This change makes the behavior of `ArrayHandle` consistent with the behavior of `UnknownArrayHandle`. The latter needed this behavior to allow `ArrayHandle`s to be passed as output arguments to methods that get automatically converted to `UnknownArrayHandle`. 2. Before this change, a `const ArrayHandle&` was still multible is many way. In particular, it was possible to change the data in the array even if the array could not be resized. You could still call things like `WritePortal` and `PrepareForInOut`. The fact that you could change it for some things and not others was confusing. The fact that you could call `PrepareForInOut` but not `PrepareForOutput` was doubly confusing. 3. Passing a value by constant reference should be the same, from the calling code's perspective, as passing by value. Although the function can change an argument passed by value, that change is not propogated back to the calling code. However, in the case of `ArrayHandle`, calling by value would allow the array to be reallocated from the calling side whereas a constant reference would prevent that. This change makes the two behaviors consistent. 4. The supposed assurance that the `ArrayHandle` would not be reallocated was easy to break even accidentally. If the `ArrayHandle` was assigned to another `ArrayHandle` (for example as a class' member or wrapped inside of an `UnknownArrayHandle`), then the array was free to be reallocated. -
e7409347 Allow ArrayCopy into const ref of UnknownArrayHandle Acked-by:
-
Nickolas Davis authored
-
Nickolas Davis authored
-
Nickolas Davis authored
-
Nickolas Davis authored
-
- 01 Sep, 2021 8 commits
-
-
Abhishek Yenpure authored
-
Abhishek Yenpure authored
-
52ae3e4d Adding missing header 57711cab Merge branch 'master' of https://gitlab.kitware.com/vtk/vtk-m into mir c64bf9b3 removing wrong fix that added additional errors c13ed21e Fixing failing CUDA test 32bit IDs 64bit Floats e53f419f Fixing failing CUDA test 32bit IDs 64bit Floats 816c29ed Adding missing header VectorAnalysis da19ea2e Removing unnecessesary header ImplicitFunctionHandle b185944d Adding fixes from Ken's review ... Acked-by:
-
Abhishek Yenpure authored
-
Kenneth Moreland authored
Added the following form of `ArrayCopy`: ```cpp VTKM_CONT_EXPORT void ArrayCopy( const vtkm::cont::UnknownArrayHandle& source, const vtkm::cont::UnknownArrayHandle& destination); ``` Note that the destination array is a constant reference. This is actually OK because you can change the contents of an `UnknownArrayHandle` (as long as you don't change the array being referenced). The main motivation for this change is to allow you to call this form of `ArrayCopy` while passing in a `ArrayHandle` as the second argument. C++ will automatically make the conversion, but the function has to accept a const reference for it to be passed correctly. Note that there is still a form of `ArrayCopy` that accepts a non-const reference to the destination array. The two arrays behave the same except for one difference. For the non-const version, if the `UnknownArrayHandle` does not already point to an array (i.e. is not valid), a new array will be created and placed in the destination object. However, because this cannot be done for a const reference, an exception is thrown instead.
-
-
83546775 Fix link issue with discarded section 42acb9a6 Properly check whether ArrayHandleRecombineVec is on device c17a5569 Do not try to use ArrayGetValue on arrays of non-basic types 9ca0cd1f Report array type when UnknownArrayHandle::ExtractComponent fails e1ac918b Compile ArrayGetValues implementation in library Acked-by:
-
546dd608 Suppress exception when mapping field of unknown type Acked-by:
Abhishek Yenpure <abhishek@uoregon.edu>
Merge-request: !2567
-
- 31 Aug, 2021 2 commits
-
-
Kenneth Moreland authored
By default, the `FilterDataSet` class will iterate over all fields and use `CastAndCall` on each one to call the subclass' mapping function with the appropriate array type. This only works if the array is of a known type. If it is not `CastAndCall` throws an exception. However, having the entire filter exception out just because one field cannot be converted does not make sense. Instead, catch the exception, log a warning, and drop the field.
-
James Kress authored
-
