3bb46b29 Tests: Teach RunCMake to ignore Xcode DVTCoreDeviceEnabledState warnings

Merge-request: !8392

Merge-request: !8392

Merge-request: !8392

Merge-request: !8392

On some Xcode versions, `xcodebuild` may warn:

    ... xcodebuild[...] DVTCoreDeviceEnabledState: DVTCoreDeviceEnabledState_Disabled set via user default

Teach RunCMake to drop such incidental lines before matching against
expected output.

52dbfefe Xcode: Fix detection of Swift compiler location for Xcode 14.3

Merge-request: !8388

Merge-request: !8388

Merge-request: !8388

Merge-request: !8388

Previously we tried to match output from `xcodebuild` to detect the
path to the `swiftc` tool.  This approach is used for C and CXX
for historical reasons, but is unnecessary for Swift.  We know the
name of the tool, so we can just ask `xcrun --find swiftc`.

Fixes: #24666

Brad King authored 2 years ago and Kitware Robot committed 2 years ago

4da50fe3 VS: Remove extra try_compile argument in Intel Fortran check

Acked-by: Kitware Robot <kwrobot@kitware.com>
Merge-request: !8383

Merge-request: !8383

Refactoring in commit d00d8537 (Modules: Use new keyword-dispatched
try_compile signature, 2022-09-16, v3.25.0-rc1~115^2) accidentally
left one of the old signature arguments behind, causing a warning.

Brad King authored 2 years ago and Kitware Robot committed 2 years ago

006e1995 Swift: Restore compatibility with old C++ driver

Acked-by: Kitware Robot <kwrobot@kitware.com>
Merge-request: !8365

YR Chen authored 2 years ago and Brad King committed 2 years ago

The `-wmo` flag added by commit 6063428d (Swift: Update default build
flags, 2022-10-03, v3.26.0-rc1~585^2~1) behaves differently with the old
driver.  Detect when the old driver is being used, and avoid adding that
flag.

Fixes: #24641

Brad King authored 2 years ago and Kitware Robot committed 2 years ago

a67cd9c3 Ninja: Restore slash style for MinGW tools when extra languages are enabled

Acked-by: Kitware Robot <kwrobot@kitware.com>
Acked-by: buildbot <buildbot@kitware.com>
Merge-request: !8368

Since commit f3ca199c (cmGlobalNinjaGenerator: Factor out GNU-like
command-line detection on Windows, 2023-03-18, v3.26.1~2^2~6), we
accidentally "unrecognize" MinGW tools on Windows if a language other
than C or CXX is enabled.  This causes the wrong slash style to be
generated in paths in `build.ninja`.

Fixes: #24642

Brad King authored 2 years ago and Kitware Robot committed 2 years ago

01d7860f Ninja,Makefile: Restore Fortran module scanning in static library cycle
846baa7c cmGlobalGenerator: Factor out helper to check target ordering

Acked-by: Kitware Robot <kwrobot@kitware.com>
Acked-by: buildbot <buildbot@kitware.com>
Merge-request: !8363

Since

* commit eed295fd (cmGlobalNinjaGenerator: require that dependency info
                     files work, 2023-02-01, v3.26.0-rc1~1^2~1), and
* commit 13810dee (cmDependsFortran: require that dependency info files
                     work, 2023-02-01, v3.26.0-rc1~1^2),

the Ninja and Makefile generators' module dependency scanning requires
that scanning results from from linked targets is available before
scanning the current target.  In the case of a static library cycle,
we cannot expect this information from other static libraries in the
cycle.  Previously we supported cyclic cases at the cost of silently
ignoring missing information.

We already compute a global order of targets that respects all
`add_dependencies`, but may break `target_link_libraries` dependencies
that occur in a static library cycle.  Use this order to filter the
linked targets so we only expect scanning results to be available from
those targets that build before the current target.

This approach is sufficient to support module dependency scanning in
static library cycles as long as module dependencies do not cross
between two libraries in the same cycle.

Fixes: #24631

Brad King authored 2 years ago and Kitware Robot committed 2 years ago

a6bb4975 FindHDF5: Restore parallel HDF5 detection with only CXX enabled

Acked-by: Kitware Robot <kwrobot@kitware.com>
Acked-by: buildbot <buildbot@kitware.com>
Merge-request: !8355

Since commit 14c46fb1 (FindHDF5: Find C component with only CXX
compiler, 2022-12-13, v3.26.0-rc1~175^2), if CXX is enabled but C is
not, the `_HDF5_test_regular_compiler_C` helper writes a `.cpp` source
but the `_HDF5_invoke_compiler` still expects a `.c` source.  Refactor
the logic to select a name for the source file up front, and use it in
both helpers.

Fixes: #24627
Issue: #24241

Brad King authored 2 years ago and Kitware Robot committed 2 years ago

1b7c26da Ninja: Wrap rules using '>' shell redirection with 'cmd /C' on Windows
ffd8537a Clang: Record Clang 16.0 C++ modules flags only for GNU-like front-end
60132272 cmGlobalNinjaGenerator: Use forward slashes in clang modmap format on Windows
d9d74b5e cmDyndepCollation: Drop outdated mentions of CXX_MODULE_INTERNAL_PARTITIONS
edab56d2 cmLocalNinjaGenerator: De-duplicate condition for using 'cmd /C' on Windows
8ebe3f92 cmGlobalNinjaGenerator: Detect GNU-like command-line for dyndep collator
f3ca199c cmGlobalNinjaGenerator: Factor out GNU-like command-line detection on Windows
f79817fc cmCxxModuleMapper: Use value semantics in path conversion callback
...

Acked-by: Kitware Robot <kwrobot@kitware.com>
Merge-request: !8346

Brad King authored 2 years ago and Kitware Robot committed 2 years ago

843fc607 Ninja: Restore detection of clang-cl showIncludes prefix
3346570a Tests: Comment RunCMake.Ninja ShowIncludes sample input languages

Acked-by: Kitware Robot <kwrobot@kitware.com>
Merge-request: !8344

Brad King authored 2 years ago and Kitware Robot committed 2 years ago

4c902d67 FindPython: ensure Stable ABI is correctly handled

Acked-by: Kitware Robot <kwrobot@kitware.com>
Merge-request: !8345

This is needed for the clang-scan-deps rule added by commit 0e21e55fc5
(Clang: Record Clang 16.0 C++ modules flags only for GNU-like front-end,
2023-03-16).

Fixes: #24611

The settings added by commit 3fe8e33f (Clang: Record Clang 16.0 flags
for our experimental C++ modules support, 2023-03-03, v3.26.0-rc6~6^2)
work only for the GNU-like `clang++` front-end, and not for the
MSVC-like `clang-cl` on Windows.

Also quote the path to `clang-scan-deps` to support spaces in its path.

Issue: #24611

YR Chen authored 2 years ago and Brad King committed 2 years ago

Since commit 8f82e755 (Ninja: Fix detection of MSVC showIncludes
prefix in Italian, 2023-01-26, v3.26.0-rc1~20^2) our regex no longer
matches the output from `clang-cl`, which uses a relative path, forward
slashes, and is always in English [1]:

    Note: including file: ./foo.h

Update the regex to match that too.

[1] https://github.com/llvm/llvm-project/blob/llvmorg-16.0.0/clang/lib/Frontend/HeaderIncludeGen.cpp#L102



Co-authored-by: Brad King <brad.king@kitware.com>

Marc Chevrier authored 2 years ago and Brad King committed 2 years ago

Fixes: #24610