Skip to content
GitLab
Commit c4b66df6 authored by Kenneth Leiter's avatar Kenneth Leiter
Browse files

ENH: Make XdmfArray variant visitors private members of XdmfArray.

parent 395175f5
Hide whitespace changes
Inline Side-by-side
XdmfArray.cpp
View file @ c4b66df6
......@@ -9,23 +9,24 @@
#include "XdmfVisitor.hpp"
#include <sstream>
class XdmfArrayClear : public boost::static_visitor <void> {
class XdmfArray::Clear : public boost::static_visitor <void> {
public:
XdmfArrayClear()
Clear()
{
}
template<typename T> void operator()(const boost::shared_ptr<std::vector<T> > & array) const
template<typename T>
void operator()(const boost::shared_ptr<std::vector<T> > & array) const
{
return array->clear();
}
};
class XdmfArrayCopyArrayValues : public boost::static_visitor <void> {
class XdmfArray::CopyArrayValues : public boost::static_visitor <void> {
public:
XdmfArrayCopyArrayValues(int startIndex, int valuesStartIndex, int numValues, int arrayStride, int valuesStride) :
CopyArrayValues(int startIndex, int valuesStartIndex, int numValues, int arrayStride, int valuesStride) :
mStartIndex(startIndex),
mValuesStartIndex(valuesStartIndex),
mNumValues(numValues),
......@@ -34,7 +35,8 @@ public:
{
}
template<typename T, typename U> void operator()(const boost::shared_ptr<std::vector<T> > & array, const boost::shared_ptr<std::vector<U> > & arrayToCopy) const
template<typename T, typename U>
void operator()(const boost::shared_ptr<std::vector<T> > & array, const boost::shared_ptr<std::vector<U> > & arrayToCopy) const
{
int size = mStartIndex + mNumValues;
if(mArrayStride > 1)
......@@ -60,9 +62,9 @@ private:
int mValuesStride;
};
class XdmfArrayGetHDF5Type : public boost::static_visitor <hid_t> {
class XdmfArray::GetHDF5Type : public boost::static_visitor <hid_t> {
public:
XdmfArrayGetHDF5Type()
GetHDF5Type()
{
}
......@@ -112,9 +114,9 @@ public:
}
};
class XdmfArrayGetPrecision : public boost::static_visitor <int> {
class XdmfArray::GetPrecision : public boost::static_visitor <int> {
public:
XdmfArrayGetPrecision()
GetPrecision()
{
}
......@@ -164,9 +166,9 @@ public:
}
};
class XdmfArrayGetType : public boost::static_visitor <std::string> {
class XdmfArray::GetType : public boost::static_visitor <std::string> {
public:
XdmfArrayGetType()
GetType()
{
}
......@@ -216,36 +218,38 @@ public:
}
};
class XdmfArrayGetSize : public boost::static_visitor <int> {
class XdmfArray::GetSize : public boost::static_visitor <int> {
public:
XdmfArrayGetSize()
GetSize()
{
}
template<typename T> int operator()(const boost::shared_ptr<std::vector<T> > & array) const
template<typename T>
int operator()(const boost::shared_ptr<std::vector<T> > & array) const
{
return array->size();
}
};
class XdmfArrayGetValuesPointer : public boost::static_visitor <const void* const> {
class XdmfArray::GetValuesPointer : public boost::static_visitor <const void* const> {
public:
XdmfArrayGetValuesPointer()
GetValuesPointer()
{
}
template<typename T> const void* const operator()(const boost::shared_ptr<std::vector<T> > & array) const
template<typename T>
const void* const operator()(const boost::shared_ptr<std::vector<T> > & array) const
{
return &array->operator[](0);
}
};
class XdmfArrayGetValuesString : public boost::static_visitor <std::string> {
class XdmfArray::GetValuesString : public boost::static_visitor <std::string> {
public:
XdmfArrayGetValuesString()
GetValuesString()
{
}
......@@ -259,7 +263,8 @@ public:
return toReturn.str();
}
template<typename T> std::string operator()(const boost::shared_ptr<std::vector<T> > & array) const
template<typename T>
std::string operator()(const boost::shared_ptr<std::vector<T> > & array) const
{
std::stringstream toReturn;
for(int i=0; i<array->size(); ++i)
......@@ -270,14 +275,15 @@ public:
}
};
class XdmfArrayNewArray : public boost::static_visitor <void> {
class XdmfArray::NewArray : public boost::static_visitor <void> {
public:
XdmfArrayNewArray()
NewArray()
{
}
template<typename T> void operator()(boost::shared_ptr<std::vector<T> > & array) const
template<typename T>
void operator()(boost::shared_ptr<std::vector<T> > & array) const
{
boost::shared_ptr<std::vector<T> > newArray(new std::vector<T>());
array = newArray;
......@@ -302,46 +308,46 @@ void XdmfArray::copyValues(int startIndex, boost::shared_ptr<XdmfArray> values,
// Copy the values variant in order to get the type (only taking smart pointer so no worries about large copies)
mArray = values->mArray;
// Reinitialize variant array to contain new array with same type.
boost::apply_visitor( XdmfArrayNewArray(), mArray);
boost::apply_visitor( NewArray(), mArray);
mInitialized = true;
}
boost::apply_visitor( XdmfArrayCopyArrayValues(startIndex, valuesStartIndex, numValues, arrayStride, valuesStride), mArray, values->mArray);
boost::apply_visitor( CopyArrayValues(startIndex, valuesStartIndex, numValues, arrayStride, valuesStride), mArray, values->mArray);
}
void XdmfArray::clear()
{
mInitialized = false;
return boost::apply_visitor( XdmfArrayClear(), mArray);
return boost::apply_visitor( Clear(), mArray);
}
hid_t XdmfArray::getHDF5Type() const
{
return boost::apply_visitor( XdmfArrayGetHDF5Type(), mArray);
return boost::apply_visitor( GetHDF5Type(), mArray);
}
int XdmfArray::getPrecision() const
{
return boost::apply_visitor( XdmfArrayGetPrecision(), mArray);
return boost::apply_visitor( GetPrecision(), mArray);
}
int XdmfArray::getSize() const
{
return boost::apply_visitor( XdmfArrayGetSize(), mArray);
return boost::apply_visitor( GetSize(), mArray);
}
std::string XdmfArray::getType() const
{
return boost::apply_visitor( XdmfArrayGetType(), mArray);
return boost::apply_visitor( GetType(), mArray);
}
const void* const XdmfArray::getValuesPointer() const
{
return boost::apply_visitor( XdmfArrayGetValuesPointer(), mArray);
return boost::apply_visitor( GetValuesPointer(), mArray);
}
std::string XdmfArray::getValuesString() const
{
return boost::apply_visitor( XdmfArrayGetValuesString(), mArray);
return boost::apply_visitor( GetValuesString(), mArray);
}
std::string XdmfArray::printSelf() const
......
XdmfArray.hpp
View file @ c4b66df6
......@@ -200,6 +200,23 @@ protected:
private:
// Variant Visitor Operations
class Clear;
class CopyArrayValues;
template<typename T>
class CopyValues;
class GetHDF5Type;
class GetPrecision;
class GetSize;
class GetType;
class GetValuesPointer;
class GetValuesString;
class NewArray;
struct NullDeleter;
typedef boost::variant<
boost::shared_ptr<std::vector<char> >,
boost::shared_ptr<std::vector<short> >,
......
XdmfArray.tpp
View file @ c4b66df6
......@@ -2,10 +2,10 @@
#include "XdmfArray.hpp"
template<typename T>
class XdmfArrayCopyValues : public boost::static_visitor <void> {
class XdmfArray::CopyValues : public boost::static_visitor <void> {
public:
XdmfArrayCopyValues(int startIndex, T * valuesPointer, int numValues = 1, int arrayStride = 1, int valuesStride = 1) :
CopyValues(int startIndex, T * valuesPointer, int numValues = 1, int arrayStride = 1, int valuesStride = 1) :
mStartIndex(startIndex),
mValuesPointer(valuesPointer),
mNumValues(numValues),
......@@ -14,7 +14,8 @@ public:
{
}
template<typename U> void operator()(boost::shared_ptr<std::vector<U> > & array) const
template<typename U>
void operator()(boost::shared_ptr<std::vector<U> > & array) const
{
int size = mStartIndex + mNumValues;
if(mArrayStride > 1)
......@@ -40,7 +41,7 @@ private:
int mValuesStride;
};
struct XdmfArrayNullDeleter
struct XdmfArray::NullDeleter
{
void operator()(void const *) const
{
......@@ -54,7 +55,7 @@ void XdmfArray::copyValues(int startIndex, T * valuesPointer, int numValues, int
{
initialize<T>();
}
boost::apply_visitor( XdmfArrayCopyValues<T>(startIndex, valuesPointer, numValues, arrayStride, valuesStride), mArray);
boost::apply_visitor( CopyValues<T>(startIndex, valuesPointer, numValues, arrayStride, valuesStride), mArray);
}
template <typename T>
......@@ -98,7 +99,7 @@ boost::shared_ptr<std::vector<T> > XdmfArray::initialize()
template<typename T>
void XdmfArray::setValues(std::vector<T> & array)
{
boost::shared_ptr<std::vector<T> > newArray(&array, XdmfArrayNullDeleter());
boost::shared_ptr<std::vector<T> > newArray(&array, NullDeleter());
mArray = newArray;
mInitialized = true;
}
......
Supports Markdown
0% or .
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment