Skip to content
Snippets Groups Projects

Split the "save smtk model" operator in two.

Merged David Thompson requested to merge dcthomp/smtk:rebased-squashed-change-model-save into master
All threads resolved!

This splits a portion of the functionality in "save smtk model" into a new "export smtk model" operator.

Also, this removes some dead code (a "package smtk model" operator that does what "export smtk model" now does).

Merge request reports

Loading
Loading

Activity

Filter activity
  • Approvals
  • Assignees & reviewers
  • Comments (from bots)
  • Comments (from users)
  • Commits & branches
  • Edits
  • Labels
  • Lock status
  • Mentions
  • Merge request status
  • Tracking
  • David Thompson added 1 commit

    added 1 commit

    • 9bc746de - Remove commented and dead code.

    Compare with previous version

  • David Thompson resolved all discussions

    resolved all discussions

  • Errors:

    • commit 2a76d992 is not allowed because the following files are not formatted according to the 'clang-format' check: smtk/extension/paraview/operators/smtkModelIOView.h. Use Do: reformat to rewrite the MR source branch automatically.

    Please rewrite commits to fix the errors listed above (adding fixup commits will not resolve the errors) and force-push the branch again to update the merge request.

  • Author Maintainer

    @haocheng.liu I pushed a new version with all irrelevant comments and code removed. The remaining commented code is there for a reason... I suspect we will be refactoring the code to improve reuse and this makes it easier.

  • Haocheng LIU resolved all discussions

    resolved all discussions

  • One thing about Model - Export operator is that since it's a custom UI, so we lost the info button to guide users. Would it hard to do something here?

  • +1 other than my little doubt.

  • Author Maintainer

    @haocheng.liu The info button will arrive in another commit once Bob merges some code to support it into qtBaseView.

  • Author Maintainer

    Do: reformat

  • This topic has been reformatted and pushed; please fetch from the repository before further development to use the new topic locally.

  • Kitware Robot added 2 commits

    added 2 commits

    • a8bfb86e - Add an "export smtk model" operator and UI.
    • 08be5f1f - Remove commented and dead code.

    Compare with previous version

  • Author Maintainer

    Do: merge

  • merged

  • David Thompson mentioned in commit 57913bc8

    mentioned in commit 57913bc8

  • Please register or sign in to reply
    Loading