Skip to content
Snippets Groups Projects

WIP: mockup of exposing session environments in python.

Closed T.J. Corona requested to merge tjcorona/smtk:python-env into master
1 unresolved thread

Merge request reports

Pipeline #97711 failed

Pipeline failed for d00b9b5c on tjcorona:python-env

Closed by T.J. CoronaT.J. Corona 6 years ago (May 23, 2018 1:46pm UTC)

Loading

Activity

Filter activity
  • Approvals
  • Assignees & reviewers
  • Comments (from bots)
  • Comments (from users)
  • Commits & branches
  • Edits
  • Labels
  • Lock status
  • Mentions
  • Merge request status
  • Tracking
  • Errors:

    • commit d00b9b5c cannot be merged; it is marked as a work-in-progress (WIP).

    Warnings:

    • the merge request is marked as a work-in-progress.

    The warnings do not need to be fixed, but it is recommended to do so.

    Please rewrite commits to fix the errors listed above (adding fixup commits will not resolve the errors) and force-push the branch again to update the merge request.

11 11 )
12 12 smtk_export_header(smtkPolygonSessionEnvironment Exports.h)
13 13 smtk_install_library(smtkPolygonSessionEnvironment)
14
15 if (SMTK_ENABLE_PYTHON_WRAPPING)
16 add_subdirectory(pybind11)
17 endif()
  • Rather than adding a subdirectory and all the machinery below — since it is very repetitive and verbose — we should add a CMake macro to SMTK like:

    smtk_environment(smtkPolygonSessionEnvironment
      LIBRARIES
        smtkModelEnvironment
        smtkPolygonSession
      SOURCES
        Environment.cxx
      DOCUMENTATION
        "Registers polygon-session resource type and operators."
    )

    that would do everything below plus the boring parts of the environment creation, like declaring the C++ environment library, adding its export header, installing it, and so forth.

  • Please register or sign in to reply
  • Other than consolidating boilerplate code into a CMake macro/function, +1 or even +5.

  • closed

  • Please register or sign in to reply
    Loading