SMTK issueshttps://gitlab.kitware.com/cmb/smtk/-/issues2021-04-14T10:04:18-04:00https://gitlab.kitware.com/cmb/smtk/-/issues/418SMTK ghostflow should look for restructured-text release notes2021-04-14T10:04:18-04:00David ThompsonSMTK ghostflow should look for restructured-text release notesPlease modify the ghostflow configuration for cmb/smtk> MRs to look for `.rst` files in `doc/release/notes` instead of `.md` files. If you want to test, see !2415 which has an RST note.Please modify the ghostflow configuration for cmb/smtk> MRs to look for `.rst` files in `doc/release/notes` instead of `.md` files. If you want to test, see !2415 which has an RST note.Brad KingBrad Kinghttps://gitlab.kitware.com/cmb/smtk/-/issues/395Improper include processing2020-11-18T22:38:17-05:00David ThompsonImproper include processingSMTK's string-encoding macros improperly process nested includes; instead of including content from all included files, only the deepest file content is in the output. For instance if `A.xml` includes `B.xml` includes `C.xml`, the output...SMTK's string-encoding macros improperly process nested includes; instead of including content from all included files, only the deepest file content is in the output. For instance if `A.xml` includes `B.xml` includes `C.xml`, the output will only have content from `A.xml` and `C.xml`.
A simple reproducing example is attached:
[naughty-include.tar.gz](/uploads/e1c99f4c0a9efd1a0fcc9c350803b538/naughty-include.tar.gz)Ben BoeckelBen Boeckelhttps://gitlab.kitware.com/cmb/smtk/-/issues/305ASAN/UBSAN builder2019-12-10T13:16:44-05:00Ben BoeckelASAN/UBSAN builderSMTK should be tested under ASAN and UBSAN.
https://clang.llvm.org/docs/AddressSanitizer.html
https://clang.llvm.org/docs/UndefinedBehaviorSanitizer.html
Suppression of issues is available: https://clang.llvm.org/docs/AddressSanitizer...SMTK should be tested under ASAN and UBSAN.
https://clang.llvm.org/docs/AddressSanitizer.html
https://clang.llvm.org/docs/UndefinedBehaviorSanitizer.html
Suppression of issues is available: https://clang.llvm.org/docs/AddressSanitizer.html#issue-suppression https://clang.llvm.org/docs/UndefinedBehaviorSanitizer.html#issue-suppressionBen BoeckelBen Boeckelhttps://gitlab.kitware.com/cmb/smtk/-/issues/234Building on Windows - add vtkInfovisLayout to CMakeLists.txt2019-04-17T10:39:20-04:00chart3388Building on Windows - add vtkInfovisLayout to CMakeLists.txtWhen building [SMTK](https://gitlab.kitware.com/cmb/smtk/tree/1be044d6e6fb51d8d7271e5d65f1133ff7104877) on Windows for the past few iterations I have to go and update [smtk\extension\vtk\reader\CMakeLists.txt](https://gitlab.kitware.com/...When building [SMTK](https://gitlab.kitware.com/cmb/smtk/tree/1be044d6e6fb51d8d7271e5d65f1133ff7104877) on Windows for the past few iterations I have to go and update [smtk\extension\vtk\reader\CMakeLists.txt](https://gitlab.kitware.com/cmb/smtk/blob/1be044d6e6fb51d8d7271e5d65f1133ff7104877/smtk/extension/vtk/reader/CMakeLists.txt) to include vtkInfovisLayout otherwise I get this error whilst building:
`Creating library lib\vtkSMTKReaderExt-8.2.lib and object lib\vtkSMTKReaderExt-8.2.expvtkGeoSphereTransformLegacy.cxx.obj : error LNK2019: unresolved external symbol "__declspec(dllimport) public: static double __cdecl vtkGeoMath::EarthRadiusMeters(void)" (__imp_?EarthRadiusMeters@vtkGeoMath@@SANXZ) referenced in function "public: virtual void __cdecl vtkGeoSphereTransformLegacy::InternalTransformPoint(double const * const,double * const)" (?InternalTransformPoint@vtkGeoSphereTransformLegacy@@UEAAXQEBNQEAN@Z)vtkGlobeSourceLegacy.cxx.obj : error LNK2001: unresolved external symbol "__declspec(dllimport) public: static double __cdecl vtkGeoMath::EarthRadiusMeters(void)" (__imp_?EarthRadiusMeters@vtkGeoMath@@SANXZ)bin\vtkSMTKReaderExt-8.2.dll : fatal error LNK1120: 1 unresolved externals`
Building against ParaView 5.6.0. Attached is a Patch, not saying it is the right way but it is what resolve the problem for me
[vtkInfovisLayout-Missing.patch](/uploads/fa3b11af83fae578fdfe2783b1c652a8/vtkInfovisLayout-Missing.patch)T.J. CoronaT.J. Coronahttps://gitlab.kitware.com/cmb/smtk/-/issues/162Remove "${PARAVIEW_PYTHONPATH}/vtk" from python list when ParaView updates.2018-02-15T14:26:08-05:00T.J. CoronaRemove "${PARAVIEW_PYTHONPATH}/vtk" from python list when ParaView updates.T.J. CoronaT.J. Coronahttps://gitlab.kitware.com/cmb/smtk/-/issues/122Praxis build failure2018-04-11T01:59:25-04:00Ben BoeckelPraxis build failureHere's the build failure for SMTK on nightly `praxis` builds:
```
qtSurfaceExtractorView.cxx.obj : error LNK2019: unresolved external symbol "public: __cdecl imageFeatureExtractorWidget::imageFeatureExtractorWidget(void)" (??0imageFeatu...Here's the build failure for SMTK on nightly `praxis` builds:
```
qtSurfaceExtractorView.cxx.obj : error LNK2019: unresolved external symbol "public: __cdecl imageFeatureExtractorWidget::imageFeatureExtractorWidget(void)" (??0imageFeatureExtractorWidget@@QEAA@XZ) referenced in function "public: virtual void __cdecl qtSurfaceExtractorView::operationSelected(class std::shared_ptr<class smtk::model::Operator> const &)" (?operationSelected@qtSurfaceExtractorView@@UEAAXAEBV?$shared_ptr@VOperator@model@smtk@@@std@@@Z)
qtSurfaceExtractorView.cxx.obj : error LNK2019: unresolved external symbol "public: void __cdecl imageFeatureExtractorWidget::setImage(class std::basic_string<char,struct std::char_traits<char>,class std::allocator<char> >)" (?setImage@imageFeatureExtractorWidget@@QEAAXV?$basic_string@DU?$char_traits@D@std@@V?$allocator@D@2@@std@@@Z) referenced in function "public: virtual void __cdecl qtSurfaceExtractorView::operationSelected(class std::shared_ptr<class smtk::model::Operator> const &)" (?operationSelected@qtSurfaceExtractorView@@UEAAXAEBV?$shared_ptr@VOperator@model@smtk@@@std@@@Z)
qtSurfaceExtractorView.cxx.obj : error LNK2019: unresolved external symbol "public: class vtkSmartPointer<class vtkPolyData> __cdecl imageFeatureExtractorWidget::getPolydata(void)" (?getPolydata@imageFeatureExtractorWidget@@QEAA?AV?$vtkSmartPointer@VvtkPolyData@@@@XZ) referenced in function "public: virtual void __cdecl qtSurfaceExtractorView::operationSelected(class std::shared_ptr<class smtk::model::Operator> const &)" (?operationSelected@qtSurfaceExtractorView@@UEAAXAEBV?$shared_ptr@VOperator@model@smtk@@@std@@@Z)
bin\smtkPolygonSessionPlugin.dll : fatal error LNK1120: 3 unresolved externals
LINK failed. with 1120
Please define _WIN32_WINNT or _WIN32_WINDOWS appropriately. For example:
- add -D_WIN32_WINNT=0x0501 to the compiler command line; or
- add _WIN32_WINNT=0x0501 to your project's Preprocessor Definitions.
Assuming _WIN32_WINNT=0x0501 (i.e. Windows XP target).
```
Cc: @bob.obaraDavid ThompsonDavid Thompsonhttps://gitlab.kitware.com/cmb/smtk/-/issues/95Pybind11 TODO list2017-09-12T13:21:41-04:00Ben BoeckelPybind11 TODO listTODO list for Pybind11 to be used:
- [x] output only the relevant class for the given header
- [x] make output performance time reasonable
- [ ] compare built Python object versus class header
* [ ] output diff/new code during...TODO list for Pybind11 to be used:
- [x] output only the relevant class for the given header
- [x] make output performance time reasonable
- [ ] compare built Python object versus class header
* [ ] output diff/new code during the test (use `CTEST_FULL_OUTPUT`)
- [x] free functions
- [x] free enumerations
- [ ] partial regeneration (detect which files may be invalid based on header diffs)
- [ ] docs on how to obtain/build the wrapper scripts
* [ ] may make sense to add support to the superbuild to build these bits
- [ ] document process for python bits
- [x] manually implement the 37 modified functions currently in typesystem.xml
* [ ] I (john) will try to write a new test for the 37 mods
Cc: @bob.obara @robertmaynard @john.tourtellott @yuminT.J. CoronaT.J. Coronahttps://gitlab.kitware.com/cmb/smtk/-/issues/88Shiboken needs to support the `override` keyword2016-11-30T14:53:32-05:00Ben BoeckelShiboken needs to support the `override` keywordCurrently, it generates bad code.
Cc: @matthew-woehlke @dcthomp @bob.obaraCurrently, it generates bad code.
Cc: @matthew-woehlke @dcthomp @bob.obarahttps://gitlab.kitware.com/cmb/smtk/-/issues/79Update the COMPILE_FLAGS code in moab2018-08-09T14:29:40-04:00T.J. CoronaUpdate the COMPILE_FLAGS code in moabAs we bump up our CMake minimum ver this will break, and I dont want have to scramble and fix the problem with zero notice.As we bump up our CMake minimum ver this will break, and I dont want have to scramble and fix the problem with zero notice.https://gitlab.kitware.com/cmb/smtk/-/issues/73Fix building error on Ubuntu 14 and 16 as wrong path name - VTKToMesh2016-09-06T18:28:46-04:00Haocheng LIUFix building error on Ubuntu 14 and 16 as wrong path name - VTKToMeshSince Linux is case-sensitive, the path in *smtk/smtk/extension/vtkToMesh/CMakeLists.txt* as `VTKToMesh` should be replaced with `vtkToMesh`. Otherwise we would have build error as *VTKDataConverter.h: No such file or directory*Since Linux is case-sensitive, the path in *smtk/smtk/extension/vtkToMesh/CMakeLists.txt* as `VTKToMesh` should be replaced with `vtkToMesh`. Otherwise we would have build error as *VTKDataConverter.h: No such file or directory*Haocheng LIUHaocheng LIUhttps://gitlab.kitware.com/cmb/smtk/-/issues/42Moab + HDF5 requires NetCDF2018-08-09T14:28:54-04:00T.J. CoronaMoab + HDF5 requires NetCDFOtherwise you get a compilation error like the following:
```
Undefined symbols for architecture x86_64:
"moab::ReadNC::factory(moab::Interface*)", referenced from:
moab::ReaderWriterSet::ReaderWriterSet(moab::Core*) in ReaderWri...Otherwise you get a compilation error like the following:
```
Undefined symbols for architecture x86_64:
"moab::ReadNC::factory(moab::Interface*)", referenced from:
moab::ReaderWriterSet::ReaderWriterSet(moab::Core*) in ReaderWriterSet.cpp.o
"moab::WriteNC::factory(moab::Interface*)", referenced from:
moab::ReaderWriterSet::ReaderWriterSet(moab::Core*) in ReaderWriterSet.cpp.o
"moab::ReadNCDF::factory(moab::Interface*)", referenced from:
moab::ReaderWriterSet::ReaderWriterSet(moab::Core*) in ReaderWriterSet.cpp.o
"moab::WriteNCDF::factory(moab::Interface*)", referenced from:
moab::ReaderWriterSet::ReaderWriterSet(moab::Core*) in ReaderWriterSet.cpp.o
"moab::WriteSLAC::factory(moab::Interface*)", referenced from:
moab::ReaderWriterSet::ReaderWriterSet(moab::Core*) in ReaderWriterSet.cpp.o
```https://gitlab.kitware.com/cmb/smtk/-/issues/38Remove if possible requirement of vtkRenderingMatplotlib to exist2017-10-03T08:54:09-04:00Robert MaynardRemove if possible requirement of vtkRenderingMatplotlib to existSMTK does use vtkRenderingMatplotlib so why do we link against it? If we can remove this dependency we should as it is optional component of VTKSMTK does use vtkRenderingMatplotlib so why do we link against it? If we can remove this dependency we should as it is optional component of VTKT.J. CoronaT.J. Coronahttps://gitlab.kitware.com/cmb/smtk/-/issues/35Find HDF5 under MOAB is broken2016-10-18T09:20:34-04:00Robert M. O'BaraFind HDF5 under MOAB is brokenAfter SuperBuild runs, I need to set the SMTK build to be debug - when I do that the HDF variables are no longer properly set when I do a configureAfter SuperBuild runs, I need to set the SMTK build to be debug - when I do that the HDF variables are no longer properly set when I do a configureBen BoeckelBen Boeckelhttps://gitlab.kitware.com/cmb/smtk/-/issues/33SMTK no longer builds with VTK enabled and ParaView disabled2016-08-31T16:28:46-04:00T.J. CoronaSMTK no longer builds with VTK enabled and ParaView disabledTo replicate: enable VTK, leave ParaView disabled, try to build.
```
Make Error at CMake/smtkVTKModules.cmake:45 (message):
Requested modules not available: vtkPVVTKExtensionsDefault
Call Stack (most recent call first):
smt...To replicate: enable VTK, leave ParaView disabled, try to build.
```
Make Error at CMake/smtkVTKModules.cmake:45 (message):
Requested modules not available: vtkPVVTKExtensionsDefault
Call Stack (most recent call first):
smtk/extension/CMakeLists.txt:62 (vtk_smtk_process_modules)
```T.J. CoronaT.J. Corona