Commit 22b4aef2 authored by Bob Obara's avatar Bob Obara Committed by Kitware Robot

Merge topic 'fixItemUpdatingIssue' into release

e3c57585 BUG: Items not updated if switching Attributes in Attribute View
Acked-by: Kitware Robot's avatarKitware Robot <kwrobot@kitware.com>
Acked-by: T.J. Corona's avatarT.J. Corona <tj.corona@kitware.com>
Merge-request: !1552
parents 2e960d1b e3c57585
Pipeline #137039 running with stage
......@@ -150,11 +150,12 @@ The following is an example of a Analysis View:
###Changes to Attribute View
* added a new XML attribute "HideAssociations". If set to true the view will not display the association editing widget save screen Real Estate
* Added a new XML attribute "HideAssociations". If set to true the view will not display the association editing widget save screen Real Estate
* If there is only one type of attribute being created/modified then the type column is no longer displayed
* For the time being the view by property feature has been disabled until we can decide on whether it is useful and if so, what is the best way to display the information.
* The column "Attribute" has been renamed to "Name"
* Attempting to rename an attribute to a name already is use now generates a warning dialog.
* Fixed issue where changing the attribute being view would prevent an item being updated.
###Changes to Group View
......@@ -202,6 +203,9 @@ Added a new ReadOnly Option to Item Views. In the following example the item, a
with custom URLs. See qtReferenceItem::setSelectionIconPaths() and
doc/userguide/attribute/file-syntax.rst for details.
####Line Edit Items change Attribute Items on EdittingFinished
* Prior to 3.1, QlineEdit's used to set String, Double, and Int Items would try to update the item on key press events - this result in a large number of edits/modified signals being emitted. Now items are updated when the edittingFinished signal is emitted.
####Highlighting when Hovering
* Views showing associations will now highlight geometry when the user hovers over it
......
......@@ -351,17 +351,19 @@ void qtAttributeView::createWidget()
QObject::connect(
this->Internals->ViewByCombo, SIGNAL(currentIndexChanged(int)), this, SLOT(onViewBy(int)));
// We want the signals that may change the attribute to be displayed Queued instead of
// Direct so that QLineEdit::edittingFinished signals are processed prior to these.
QObject::connect(this->Internals->ListTable, SIGNAL(itemClicked(QTableWidgetItem*)), this,
SLOT(onListBoxClicked(QTableWidgetItem*)));
SLOT(onListBoxClicked(QTableWidgetItem*)), Qt::QueuedConnection);
QObject::connect(this->Internals->ListTable, SIGNAL(itemSelectionChanged()), this,
SLOT(onListBoxSelectionChanged()));
SLOT(onListBoxSelectionChanged()), Qt::QueuedConnection);
QObject::connect(this->Internals->ListTable, SIGNAL(itemChanged(QTableWidgetItem*)), this,
SLOT(onAttributeNameChanged(QTableWidgetItem*)));
// we need this so that the attribute name will also be changed
// when a recorded test is play back, which is using setText
// on the underline QLineEdit of the cell.
QObject::connect(this->Internals->ListTable, SIGNAL(cellChanged(int, int)), this,
SLOT(onAttributeCellChanged(int, int)));
SLOT(onAttributeCellChanged(int, int)), Qt::QueuedConnection);
QObject::connect(this->Internals->AddButton, SIGNAL(clicked()), this, SLOT(onCreateNew()));
QObject::connect(this->Internals->CopyButton, SIGNAL(clicked()), this, SLOT(onCopySelected()));
......
Markdown is supported
0% or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment