Skip to content

Conda py2 package

John Tourtellott requested to merge john.tourtellott/smtk:conda-py2-package into master

Known issues that need to get resolved before we can merge:

  • Must rebase on smtk:master in order to build on buildbot machines
  • In polygon session, move Import and ExtractContour class from operations to vtk folder, since they are dependent on vtk.
  • This branch changes CMAKE_LIBRARY_OUTPUT_PATH from "bin" to "lib", which is standard practice. Need to test if this breaks smtk/cmb packaging.
  • There is a hack/workaround for nlohmann_json in one of the cmake files. We think the issue is now fixed on smtk:master, so we should rebase and find out.
  • KWRobot complains that the build.sh file doesn't have executable flag set, but I don't know how to fix it. (Flag is set in my git checkout.)
  • The current cmake logic for finding python interpreter and libs are executed in the "reverse" order (according to the module docs). The conda build requires the correct order. Need to test if non-conda works with the correct order.
  • Pybind11 version 2.3 is currently required in smtk:master but not available in a standard conda package. We think that smtk:master can build with Pybind11 version 2.2 -- need to test.
  • This is not a deal breaker, but there is a problem building moab executables h5minfo and h5mvalidate on Apple. There are missing math and pthread symbols, even when I add -lm and -lpthread to the link libs.
  • Should also try switching conda-build to use ninja instead of make.
Edited by John Tourtellott

Merge request reports