SMTK issueshttps://gitlab.kitware.com/cmb/smtk/-/issues2020-01-31T11:39:10-05:00https://gitlab.kitware.com/cmb/smtk/-/issues/298Need to extend Advance Level Mechanism2020-01-31T11:39:10-05:00Robert M. O'BaraNeed to extend Advance Level Mechanism* Needs to be used to indicate if an Item is read only
* Should be inheritable between Definitions and Item Definitions
* An Item's advance level should take into consideration its owning Item/Attribute's advance level* Needs to be used to indicate if an Item is read only
* Should be inheritable between Definitions and Item Definitions
* An Item's advance level should take into consideration its owning Item/Attribute's advance levelRobert M. O'BaraRobert M. O'Barahttps://gitlab.kitware.com/cmb/smtk/-/issues/308Creating Analysis Configurations via an Attribute View Issues2020-01-31T11:38:57-05:00Robert M. O'BaraCreating Analysis Configurations via an Attribute View IssuesWhen creating an new configuration the dropdown menu for configurations does not get properly updated - the same is true when deleting a configuration.When creating an new configuration the dropdown menu for configurations does not get properly updated - the same is true when deleting a configuration.Robert M. O'BaraRobert M. O'Barahttps://gitlab.kitware.com/cmb/smtk/-/issues/309OperationView Duplicate Items2020-01-31T11:38:47-05:00Robert M. O'BaraOperationView Duplicate ItemsLoad in any attribute resource and select the export operation.
Enter anything in the filename field and then tab out. The items in the view get duplicatedLoad in any attribute resource and select the export operation.
Enter anything in the filename field and then tab out. The items in the view get duplicatedRobert M. O'BaraRobert M. O'Barahttps://gitlab.kitware.com/cmb/smtk/-/issues/312Add Support for Category and Advance Level specification on DiscreteItem's Enum2020-01-31T11:38:38-05:00Robert M. O'BaraAdd Support for Category and Advance Level specification on DiscreteItem's EnumThis will enable the UI to filter Enums based on the current category and advance level filtering mechanism.This will enable the UI to filter Enums based on the current category and advance level filtering mechanism.Robert M. O'BaraRobert M. O'Barahttps://gitlab.kitware.com/cmb/smtk/-/issues/315Improve Catrgory Modeling in SMTK::Attributes2020-01-31T11:38:26-05:00Robert M. O'BaraImprove Catrgory Modeling in SMTK::AttributesCurrently parent Definitions (both Attribute and Item) inherit the category names from their children but not the logical constraint (Any or All). Instead it always assumes Any - as a result the parents can be rendered in the GUI withou...Currently parent Definitions (both Attribute and Item) inherit the category names from their children but not the logical constraint (Any or All). Instead it always assumes Any - as a result the parents can be rendered in the GUI without any children which is not what is intended.
The category system should preserve the logical constraint and or these constraints together when forming the category constraint of the parent.Robert M. O'BaraRobert M. O'Barahttps://gitlab.kitware.com/cmb/smtk/-/issues/318Enum categories should not effect children items2020-01-31T11:38:16-05:00Robert M. O'BaraEnum categories should not effect children itemsIn the current implementation, categories constraints placed on enums are propagating down to the value item's children. This shouldn't be the case. The value item should inherit these categories but the children should only potentiall...In the current implementation, categories constraints placed on enums are propagating down to the value item's children. This shouldn't be the case. The value item should inherit these categories but the children should only potentially inherit the value item's local categories and those the value item inherits from its parent.Robert M. O'BaraRobert M. O'Barahttps://gitlab.kitware.com/cmb/smtk/-/issues/316Add ID Field in ItemDefinition2020-01-31T11:38:03-05:00Robert M. O'BaraAdd ID Field in ItemDefinitionThis is a simple string that can be used to aid in mapping the Item's Definition to external Databases.
This should include I/O support in both JSON and XML but do not need to be displayed in the GUI.This is a simple string that can be used to aid in mapping the Item's Definition to external Databases.
This should include I/O support in both JSON and XML but do not need to be displayed in the GUI.Robert M. O'BaraRobert M. O'Barahttps://gitlab.kitware.com/cmb/smtk/-/issues/322SMTK_ENABLE_MESH_SESSION=OFF is not checked when building SMTK plugins2020-01-27T16:23:26-05:00chart3388SMTK_ENABLE_MESH_SESSION=OFF is not checked when building SMTK pluginsIf you have SMTK_ENABLE_MESH_SESSION=OFF the library for smtk mesh session is not built but the mesh plugin still attempts to build and throws an error complaining it can't find smtkMeshSesision
```
[951/984] Linking CXX shared module l...If you have SMTK_ENABLE_MESH_SESSION=OFF the library for smtk mesh session is not built but the mesh plugin still attempts to build and throws an error complaining it can't find smtkMeshSesision
```
[951/984] Linking CXX shared module lib/smtk-3.3.0/smtkMeshPlugin/smtkMeshPlugin.so
FAILED: : && /usr/bin/c++ -fPIC -g -shared -o lib/smtk-3.3.0/smtkMeshPlugin/smtkMeshPlugin.so smtk/mesh/plugin/CMakeFiles/smtkMeshPlugin.dir/smtkMeshPluginPlugin.cxx.o smtk/mesh/plugin/CMakeFiles/smtkMeshPlugin.dir/serverSource.cxx.o -Wl,-rpath,/opt/axion/paraview-5.8.0/lib:/home/xzp6f6/dev/data/build/smtk-3.3.0/lib:/opt/axion/MOAB-4.9.0/lib: /opt/axion/paraview-5.8.0/lib/libvtkRemotingCore-pv5.8.so.5.8 lib/libsmtkCore.so lib/libsmtkPluginSupport.so -lsmtkMeshSession /opt/axion/paraview-5.8.0/lib/libvtkRemotingClientServerStream-pv5.8.so.5.8 /opt/axion/paraview-5.8.0/lib/libvtkPVVTKExtensionsCore-pv5.8.so.5.8 /opt/axion/paraview-5.8.0/lib/libvtkIOXML-pv5.8.so.5.8 /opt/axion/paraview-5.8.0/lib/libvtkIOXMLParser-pv5.8.so.5.8 /opt/axion/paraview-5.8.0/lib/libvtkParallelCore-pv5.8.so.5.8 /opt/axion/paraview-5.8.0/lib/libvtkCommonExecutionModel-pv5.8.so.5.8 /opt/axion/paraview-5.8.0/lib/libvtkCommonDataModel-pv5.8.so.5.8 /opt/axion/paraview-5.8.0/lib/libvtkCommonTransforms-pv5.8.so.5.8 /opt/axion/paraview-5.8.0/lib/libvtkCommonMisc-pv5.8.so.5.8 /opt/axion/paraview-5.8.0/lib/libvtkCommonMath-pv5.8.so.5.8 /opt/axion/paraview-5.8.0/lib/libvtkCommonCore-pv5.8.so.5.8 /opt/axion/paraview-5.8.0/lib/libvtksys-pv5.8.so.5.8 -ldl -lpthread /opt/axion/MOAB-4.9.0/lib/libMOAB.so.4.9.0 -Wl,-rpath-link,/opt/axion/paraview-5.8.0/lib && :
/usr/bin/ld: cannot find -lsmtkMeshSession
```T.J. CoronaT.J. Coronahttps://gitlab.kitware.com/cmb/smtk/-/issues/314Unchecked iterator dereferences2019-12-23T14:58:07-05:00Ben BoeckelUnchecked iterator dereferencesTwo tests are catching errors from !1894.
- [ ] unitAttributeAssociationConstraints (Child aborted)
- [ ] modelAttributesPy (Failed)Two tests are catching errors from !1894.
- [ ] unitAttributeAssociationConstraints (Child aborted)
- [ ] modelAttributesPy (Failed)Ben BoeckelBen Boeckelhttps://gitlab.kitware.com/cmb/smtk/-/issues/296Failing tests2019-12-20T09:01:35-05:00Ben BoeckelFailing tests - [x] elevateMeshOnStructuredGridPy
```
137: E
137: ======================================================================
137: ERROR: testMeshing2D (__main__.ElevateMeshOnStructuredGrid)
137: -----------------------------------------... - [x] elevateMeshOnStructuredGridPy
```
137: E
137: ======================================================================
137: ERROR: testMeshing2D (__main__.ElevateMeshOnStructuredGrid)
137: ----------------------------------------------------------------------
137: Traceback (most recent call last):
137: File "/builds/ben.boeckel/smtk/smtk/mesh/testing/python/elevateMeshOnStructuredGrid.py", line 165, in testMeshing2D
137: raise ValueError
137: ValueError
137:
137: ----------------------------------------------------------------------
137: Ran 1 test in 0.263s
137:
137: FAILED (errors=1)
137: Expected 5115 but got 0 at 5.
```
- [x] pv.OpenExodusFile
```
236: Couldn't find object `pqClientMainWindow/pqSelectReaderDialog/listWidget`
236: Found up to `pqClientMainWindow`
236: Available widget: `pqClientMainWindow/_layout`
236: Available widget: `pqClientMainWindow/menubar`
236: Available widget: `pqClientMainWindow/menubar/qt_menubar_ext_button`
236: Available widget: `pqClientMainWindow/menubar/menu_File`
236: Available widget: `pqClientMainWindow/menubar/menu_File/QAction0`
236: Available widget: `pqClientMainWindow/menubar/menu_File/actionServerConnect`
236: Available widget: `pqClientMainWindow/menubar/menu_File/actionServerConnect/pqServerConnectReaction0`
236: Available widget: `pqClientMainWindow/menubar/menu_File/actionServerDisconnect`
236: Available widget: `pqClientMainWindow/menubar/menu_File/actionServerDisconnect/pqServerDisconnectReaction0`
236: Available widget: `pqClientMainWindow/menubar/menu_File/actionFileSaveScreenshot`
236: Available widget: `pqClientMainWindow/menubar/menu_File/actionFileSaveScreenshot/pqSaveScreenshotReaction0`
236: Available widget: `pqClientMainWindow/menubar/menu_File/actionFileSaveAnimation`
236: Available widget: `pqClientMainWindow/menubar/menu_File/actionFileSaveAnimation/pqSaveAnimationReaction0`
236: Available widget: `pqClientMainWindow/menubar/menu_File/actionFileSaveData`
236: Available widget: `pqClientMainWindow/menubar/menu_File/actionFileSaveData/pqSaveDataReaction0`
236: Available widget: `pqClientMainWindow/menubar/menu_File/actionFileLoadServerState`
236: Available widget: `pqClientMainWindow/menubar/menu_File/actionFileLoadServerState/pqLoadStateReaction0`
236: Available widget: `pqClientMainWindow/menubar/menu_File/actionFileSaveServerState`
236: Available widget: `pqClientMainWindow/menubar/menu_File/actionFileSaveServerState/pqSaveStateReaction0`
236: Available widget: `pqClientMainWindow/menubar/menu_File/actionFileSaveGeometry`
236: Available widget: .... (and 3531 more!)
236: Set PQOBJECTNAMING_MATCH_LIMIT environment var to a +'ve number to limit entries (or 0 for unlimited).
```
- [x] TestReadWrite (only in Debug builds; this should be changed to not hinge on `assert`)
```
41: Log after Read Operation:
41: ERROR: JSON missing Cluster 1for group item:TimeSeriesData
41: INFO: smtk::attribute::Read: operation succeeded
41: Original and generated file sizes are different
41:
41: generated smtk file: /builds/ben.boeckel/smtk/build/Testing/Temporary/jsonResource.smtk
41: generated sbi1 file: /builds/ben.boeckel/smtk/build/Testing/Temporary/originalResource.sbi
41: generated sbi2 file: /builds/ben.boeckel/smtk/build/Testing/Temporary/jsonResource.sbi
41: TestReadWrite: /builds/ben.boeckel/smtk/smtk/attribute/testing/cxx/TestReadWrite.cxx:221: int main(int, char**): Assertion `false' failed.
```T.J. CoronaT.J. Coronahttps://gitlab.kitware.com/cmb/smtk/-/issues/305ASAN/UBSAN builder2019-12-10T13:16:44-05:00Ben BoeckelASAN/UBSAN builderSMTK should be tested under ASAN and UBSAN.
https://clang.llvm.org/docs/AddressSanitizer.html
https://clang.llvm.org/docs/UndefinedBehaviorSanitizer.html
Suppression of issues is available: https://clang.llvm.org/docs/AddressSanitizer...SMTK should be tested under ASAN and UBSAN.
https://clang.llvm.org/docs/AddressSanitizer.html
https://clang.llvm.org/docs/UndefinedBehaviorSanitizer.html
Suppression of issues is available: https://clang.llvm.org/docs/AddressSanitizer.html#issue-suppression https://clang.llvm.org/docs/UndefinedBehaviorSanitizer.html#issue-suppressionBen BoeckelBen Boeckelhttps://gitlab.kitware.com/cmb/smtk/-/issues/299Changing an Analysis configuration cause current tab to change2019-12-06T11:34:49-05:00Robert M. O'BaraChanging an Analysis configuration cause current tab to change* Load in smtk/data/attribute/attribute_collection/ConfigurationTest.sbt
* Create a new configuration
* Make it active (select it as My Configurations:
* Turn on Heat Transfer
You will see the Test Tab gets selected instead of staying...* Load in smtk/data/attribute/attribute_collection/ConfigurationTest.sbt
* Create a new configuration
* Make it active (select it as My Configurations:
* Turn on Heat Transfer
You will see the Test Tab gets selected instead of staying on ConfigurationsRobert M. O'BaraRobert M. O'Barahttps://gitlab.kitware.com/cmb/smtk/-/issues/300Changing Advance Level causes Attribute View to change selected attribute2019-12-06T11:34:48-05:00Robert M. O'BaraChanging Advance Level causes Attribute View to change selected attribute* Load in smtk/data/attribute/attribute_collection/ConfigurationTest.sbt
* Create a new configuration
* Create another one (the newly created one should now be selected)
* Change Advance Level
* The selection has now changed to the first* Load in smtk/data/attribute/attribute_collection/ConfigurationTest.sbt
* Create a new configuration
* Create another one (the newly created one should now be selected)
* Change Advance Level
* The selection has now changed to the firstRobert M. O'BaraRobert M. O'Barahttps://gitlab.kitware.com/cmb/smtk/-/issues/303Remove cJSON2019-12-05T16:02:37-05:00Ben BoeckelRemove cJSONWe now have nlohmann_json and shouldn't need two JSON libraries in the codebase. cJSON has some silly C coding behaviors that ends up being caught by `clang-tidy` (see !1850).
@tjcorona Seems that it has become used outside cumulus agai...We now have nlohmann_json and shouldn't need two JSON libraries in the codebase. cJSON has some silly C coding behaviors that ends up being caught by `clang-tidy` (see !1850).
@tjcorona Seems that it has become used outside cumulus again (I see usage in DateTimeZonePair, Remus bits. some model session IO, discrete session, and polygon session).
Cc: @john.tourtellott @dcthompBen BoeckelBen Boeckelhttps://gitlab.kitware.com/cmb/smtk/-/issues/284Prevent a part from highlighting on hover if it is hidden2019-12-03T14:43:39-05:00Jacob VaverkaPrevent a part from highlighting on hover if it is hiddenIf you click on a part and deselect the eyeball the part is still highlighted in the render window via the selection color from the pallet. It is not until you click off of the part in the geometry browser does the part disappears in th...If you click on a part and deselect the eyeball the part is still highlighted in the render window via the selection color from the pallet. It is not until you click off of the part in the geometry browser does the part disappears in the render window. If you click on the eye ball without selecting the part first the part disappears immediately because the part was not selected, hence, no selection color to be shown.
Import some Geometry
Select the part you which to hide in the geometry panel
Left click on the eyeball to hide the geometry. The part is still shown via the selection color
Left click on another part and the part is now hidden.Aron HelserAron Helserhttps://gitlab.kitware.com/cmb/smtk/-/issues/293Assign colors: change palette is broken2019-11-20T17:02:16-05:00Aron HelserAssign colors: change palette is brokenAfter the upgrade of ParaView, the dialog to choose the categorical color map / color palette no longer actually changes the palette.
This error is printed if the default palette is applied to a model:
```
QObject::connect: No such sign...After the upgrade of ParaView, the dialog to choose the categorical color map / color palette no longer actually changes the palette.
This error is printed if the default palette is applied to a model:
```
QObject::connect: No such signal pqPresetDialog::applyPreset(const Json::Value&)
QObject::connect: (sender name: 'pqPresetDialog')
```
Steps:
* Open model/3D/exodus/knee.smtk
* select one or more pieces
* double click AssignColors
* click the "change palette" button
* choose a different palette, and click Apply or Close
The button showing the palette with overlapping circles doesn't change, and the palette applied to selected pieces doesn't change.https://gitlab.kitware.com/cmb/smtk/-/issues/276Make save-on-close dialog a user preference2019-11-14T15:09:32-05:00David ThompsonMake save-on-close dialog a user preferenceIn addition to bypassing the save-on-close and save-on-exit dialogs during testing, there should be a user preference (implemented via `smtk/extension/paraview/server/vtkSMTKSettings.{h,cxx}`) to either always discard modifications to re...In addition to bypassing the save-on-close and save-on-exit dialogs during testing, there should be a user preference (implemented via `smtk/extension/paraview/server/vtkSMTKSettings.{h,cxx}`) to either always discard modifications to resources or always save.
Furthermore, the dialogs should provide an option to change the setting (so instead of "Discard changes" and "Save", there should be a "Do not ask again").Aron HelserAron Helserhttps://gitlab.kitware.com/cmb/smtk/-/issues/272Modelbuilder crash, clicking on Use Multi-Block Inspector attributes2019-11-07T09:47:22-05:00Aron HelserModelbuilder crash, clicking on Use Multi-Block Inspector attributesIn Modelbuilder, if I open a data file (like epic-trex) and click `Properties` .. `Color Mode, Use Multi-Block Inspector attributes`, modelbuilder exits, and prints this:
`ERROR: In /home/aron.helser/projects/cmb/cmb-superbuild/build/su...In Modelbuilder, if I open a data file (like epic-trex) and click `Properties` .. `Color Mode, Use Multi-Block Inspector attributes`, modelbuilder exits, and prints this:
`ERROR: In /home/aron.helser/projects/cmb/cmb-superbuild/build/superbuild/paraview/src/VTK/Views/Core/vtkDataRepresentation.cxx, line 177
vtkSMTKResourceRepresentation (0xb881260): Port 2, connection 0 is not defined on this representation.
Segmentation fault (core dumped)
`
Unbuntu 16.04, current master of cmb/smtk.Aron HelserAron Helserhttps://gitlab.kitware.com/cmb/smtk/-/issues/285io::Logger Multithreading Issue2019-11-07T07:50:28-05:00Robert M. O'Baraio::Logger Multithreading Issuerecords() and record(i) methods are not truly thread safe since they return references to internal data structures.records() and record(i) methods are not truly thread safe since they return references to internal data structures.Robert M. O'BaraRobert M. O'Barahttps://gitlab.kitware.com/cmb/smtk/-/issues/283Need the ability to prepend to an attribute::GroupItem2019-11-07T07:50:16-05:00Robert M. O'BaraNeed the ability to prepend to an attribute::GroupItemThis should also be exposed in qtGroupItemThis should also be exposed in qtGroupItemRobert M. O'BaraRobert M. O'Bara