SMTK issueshttps://gitlab.kitware.com/cmb/smtk/-/issues2022-12-13T23:11:07-05:00https://gitlab.kitware.com/cmb/smtk/-/issues/499Avoid creating pipeline proxies for resources without geometry.2022-12-13T23:11:07-05:00David ThompsonAvoid creating pipeline proxies for resources without geometry.Currently, SMTK's ParaView extensions create pipeline proxies for each managed SMTK resource. In cases where many resources that will never present geometry are created, this can slow ParaView down.
Most resources (especially in this ca...Currently, SMTK's ParaView extensions create pipeline proxies for each managed SMTK resource. In cases where many resources that will never present geometry are created, this can slow ParaView down.
Most resources (especially in this case: attribute and graph resources) inherit `smtk::geometry::Resource`. However, in many cases, these resources do not provide a geometry backend for VTK. We should find a way to avoid creating pipeline sources in ParaView for resources that do not provide VTK geometry backends. However, be aware that some UI elements in SMTK may assume every resource has a corresponding pipeline.
@jwilson1881 FYIDavid ThompsonDavid Thompsonhttps://gitlab.kitware.com/cmb/smtk/-/issues/497Copying ValueItem with Expressions can sometimes fail2022-11-30T16:01:14-05:00Robert M. O'BaraCopying ValueItem with Expressions can sometimes failIf the ValueItem's Expression is stored in a different Attribute Resource, the copy will fail since the copy code assumes the Expression is in the same resource as the destination ValueItemIf the ValueItem's Expression is stored in a different Attribute Resource, the copy will fail since the copy code assumes the Expression is in the same resource as the destination ValueItemRobert M. O'BaraRobert M. O'Barahttps://gitlab.kitware.com/cmb/smtk/-/issues/496Create SMTK 22.08.0 Release2022-11-28T11:22:57-05:00Robert M. O'BaraCreate SMTK 22.08.0 Release<!--
This template is for tracking a release of smtk. Please replace the
following strings with the associated values:
- `VERSION`: e.g. yy.mm.n
- `MAJOR`: e.g. yy is the year
- `MINOR`: e.g. mm is the month
- `PATCH`: e.g. the ...<!--
This template is for tracking a release of smtk. Please replace the
following strings with the associated values:
- `VERSION`: e.g. yy.mm.n
- `MAJOR`: e.g. yy is the year
- `MINOR`: e.g. mm is the month
- `PATCH`: e.g. the release sequence number (start at 0)
- `BRANCHPOINT`: The commit where the release should be started - it is a point on master where the release process branch is started from. The release process branch will have multiple commits including the assembling of release notes and changing of the version.
Please remove this comment.
-->
# Preparatory steps
- Make sure you have run the `utility/SetupForDevelopment.sh` script.
- Update smtk guides
# Update smtk
- Update the local copy of the base branch.
- If `PATCH` is 0, update `master`
- Otherwise, update `release`
- [x] `git fetch origin`
- [x] `git checkout $branch`
- [x] `git merge --ff-only origin/$branch`
- If this fails, there are local commits that need to be removed
- Ensure that changes intended for the release are in it.
- The [`backport-mrs.py`][backport-mrs] script can be used to find and
ensure that merge requests assigned to the associated milestone are
available on the `release` branch. See its documentation for usage.
- Integrate changes.
- Create branch for release commits
- [x] `git checkout -b update-to-v22.08.0 9242a022fd65206adae3691bfc4ac3c8f441972b`
- Make a commit for each of these `release`-only changes:
- [x] Assemble release notes into `doc/release/smtk-22.08.rst`.
- [x] Top of release notes should have `.. _release-notes-22.08:` and a reference to the previous release's notes (See `doc/release/smtk-21.07.rst` or later for an example.)
- [x] Add reference to new release notes to `doc/release/index.rst`. (This publishes release notes on read-the-docs.)
- [x] Update the ReadMe file to refer to the new release notes
- [x] If `PATCH` is greater than 0, add items to the end of this file.
- [x] `git rm` all of the individual release note files *except* `00-example.rst`.
- [x] Do a git add for ReadMe, index.rst, and smtk-22.08.rst
- [x] `git commit -m 'Compile release notes for 22.08.0'`
- [ ] Update `version.txt` and tag the commit (tag this commit below)
- [x] `echo 22.08.0 > version.txt`
- [x] Rebuild smtk to check for deprecation warnings
- [x] `git commit -m 'Update version number to 22.08.0' version.txt` (commit message must be verbatum)
- [x] Update `.gitlab/ci/cdash-groups.json` to track the `release` CDash
groups.
- [x] Change "master" => "release" everywhere in `.gitlab/ci/cdash-groups.json`,
and change "latest-master" => "latest-release".
- [x] `git commit -m 'Update cdash-groups.json to track the release group' .gitlab/ci/cdash-groups.json`
- Create a merge request targeting `release`
- [x] Obtain a GitLab API token for the `kwrobot.release.cmb` user (ask
@ben.boeckel if you do not have one)
- [x] Add the `kwrobot.release.cmb` user to your fork with at least
`Developer` privileges (so it can open MRs)
- [x] Use [the `release-mr`][release-mr] script to open the create the
Merge Request (see script for usage)
- Pull the script for each release; it may have been updated since it
was last used
- The script outputs the information it will be using to create the
merge request. Please verify that it is all correct before creating
the merge request. See usage at the top of the script to provide
information that is either missing or incorrect (e.g., if its data
extraction heuristics fail).
- [x] Get positive review
- [x] Get a repo maintainer (currently Ben) or owner (currently Bob) to`Do: merge`
- [x] Get a repo maintainer or ownder to push the tag to the main repository
- [x] `git tag -a -m 'SMTK 22.08.0' v22.08.0 commit-that-updated-version.txt`
- [x] `git push origin v22.08.0`
- Software process updates (these can all be done independently)
- [x] Update kwrobot with the new `release` branch rules (@ben.boeckel)
- [x] Run [this script][cdash-update-groups] to update the CDash groups
- This must be done after a nightly run to ensure all builds are in the
`release` group
- See the script itself for usage documentation
- [ ] Add (or update if `PATCH` is greater than 0) version selection entry
in cmb-superbuild
[backport-mrs]: https://gitlab.kitware.com/utils/release-utils/-/blob/master/backport-mrs.py
[release-mr]: https://gitlab.kitware.com/utils/release-utils/-/blob/master/release-mr.py
[cdash-update-groups]: https://gitlab.kitware.com/utils/cdash-utils/-/blob/master/cdash-update-groups.py
# Post-release
- [ ] Write and publish blog post with release notes.
- [ ] Post an announcement in the Announcements category on
[discourse.smtk.org](https://discourse.kitware.com/c/smtk/).
- [x] Create a new commit on `master` that does the following:
- [ ] Remove the deprecated methods on `master`. Note that it should be discussed before hand which deprecated methods should be removed in this release.
- [x] Set the version.txt on `master` to be yy.mm.100
/cc @ben.boeckel
/cc @bob.obara
/cc @dcthompRobert M. O'BaraRobert M. O'Barahttps://gitlab.kitware.com/cmb/smtk/-/issues/494Deprecate and remove `ResourceManagerOperation`2022-08-11T09:22:39-04:00Aron HelserDeprecate and remove `ResourceManagerOperation`Follow on to https://gitlab.kitware.com/cmb/smtk/-/merge_requests/2773, `ResourceManagerOperation` has be absorbed into the `Operation` base class, and changed to a typedef. Its usage in SMTK should be removed, and the alias deprecated.Follow on to https://gitlab.kitware.com/cmb/smtk/-/merge_requests/2773, `ResourceManagerOperation` has be absorbed into the `Operation` base class, and changed to a typedef. Its usage in SMTK should be removed, and the alias deprecated.Aron HelserAron Helserhttps://gitlab.kitware.com/cmb/smtk/-/issues/493Discrete Value Editor not showing proper children items2022-11-28T11:22:00-05:00Robert M. O'BaraDiscrete Value Editor not showing proper children itemsIf a ValueItem has discrete values with categories and children items, the UI will sometimes not properly show the correct children. This is related to the set of active categories.If a ValueItem has discrete values with categories and children items, the UI will sometimes not properly show the correct children. This is related to the set of active categories.Robert M. O'BaraRobert M. O'Barahttps://gitlab.kitware.com/cmb/smtk/-/issues/492Object colors in VTK-session cannot be changed2022-07-28T13:37:09-04:00David ThompsonObject colors in VTK-session cannot be changedWhen geometry is assigned a color during import, field data is added to the session's VTK data. This field data overrides any color property set, so it is impossible to change the color.
The `SetAttributeBlockColorToEntity` function in ...When geometry is assigned a color during import, field data is added to the session's VTK data. This field data overrides any color property set, so it is impossible to change the color.
The `SetAttributeBlockColorToEntity` function in `smtk/extension/paraview/server/vtkSMTKResourceRepresentation.cxx` should be changed to prefer the property value.
@rohit.krishnaAron HelserAron Helserhttps://gitlab.kitware.com/cmb/smtk/-/issues/491Release 22.072022-08-03T10:14:11-04:00Robert M. O'BaraRelease 22.07<!--
This template is for tracking a release of smtk. Please replace the
following strings with the associated values:
- `VERSION`: e.g. yy.mm.n
- `MAJOR`: e.g. yy is the year
- `MINOR`: e.g. mm is the month
- `PATCH`: e.g. the ...<!--
This template is for tracking a release of smtk. Please replace the
following strings with the associated values:
- `VERSION`: e.g. yy.mm.n
- `MAJOR`: e.g. yy is the year
- `MINOR`: e.g. mm is the month
- `PATCH`: e.g. the release sequence number (start at 0)
- `BRANCHPOINT`: The commit where the release should be started - it is a point on master where the release process branch is started from. The release process branch will have multiple commits including the assembling of release notes and changing of the version.
Please remove this comment.
-->
# Preparatory steps
- Make sure you have run the `utility/SetupForDevelopment.sh` script.
- Update smtk guides
# Update smtk
- Update the local copy of the base branch.
- If `PATCH` is 0, update `master`
- Otherwise, update `release`
- [x] `git fetch origin`
- [x] `git checkout $branch`
- [x] `git merge --ff-only origin/$branch`
- If this fails, there are local commits that need to be removed
- Ensure that changes intended for the release are in it.
- The [`backport-mrs.py`][backport-mrs] script can be used to find and
ensure that merge requests assigned to the associated milestone are
available on the `release` branch. See its documentation for usage.
- Integrate changes.
- Create branch for release commits
- [x] `git checkout -b update-to-v22.07.00 df30b405dcfe3530c02a592c8bdf37179b8837dd`
- Make a commit for each of these `release`-only changes:
- [x] Assemble release notes into `doc/release/smtk-22.07.rst`.
- [x] Top of release notes should have `.. _release-notes-22.07:` and a reference to the previous release's notes (See `doc/release/smtk-21.07.rst` or later for an example.)
- [x] Add reference to new release notes to `doc/release/index.rst`. (This publishes release notes on read-the-docs.)
- [x] Update the ReadMe file to refer to the new release notes
- [x] If `PATCH` is greater than 0, add items to the end of this file.
- [x] `git rm` all of the individual release note files *except* `00-example.rst`.
- [x] Do a git add for ReadMe, index.rst, and smtk-22.07.rst
- [x] `git commit -m 'Compile release notes for 22.07.00'`
- [x] Update `version.txt` and tag the commit (tag this commit below)
- [x] `echo 22.07.00 > version.txt`
- [x] Rebuild smtk to check for deprecation warnings
- [x] `git commit -m 'Update version number to 22.07.00' version.txt` (commit message must be verbatum)
- [x] Update `.gitlab/ci/cdash-groups.json` to track the `release` CDash
groups.
- [x] Change "master" => "release" everywhere in `.gitlab/ci/cdash-groups.json`,
and change "latest-master" => "latest-release".
- [x] `git commit -m 'Update cdash-groups.json to track the release group' .gitlab/ci/cdash-groups.json`
- Create a merge request targeting `release`
- [x] Obtain a GitLab API token for the `kwrobot.release.cmb` user (ask
@ben.boeckel if you do not have one)
- [x] Add the `kwrobot.release.cmb` user to your fork with at least
`Developer` privileges (so it can open MRs)
- [x] Use [the `release-mr`][release-mr] script to open the create the
Merge Request (see script for usage)
- Pull the script for each release; it may have been updated since it
was last used
- The script outputs the information it will be using to create the
merge request. Please verify that it is all correct before creating
the merge request. See usage at the top of the script to provide
information that is either missing or incorrect (e.g., if its data
extraction heuristics fail).
- [x] Get positive review
- [x] Get a repo maintainer (currently Ben) or owner (currently Bob) to`Do: merge`
- [x] Get a repo maintainer or ownder to push the tag to the main repository
- [x] `git tag -a -m 'SMTK 22.07.00' v22.07.00 commit-that-updated-version.txt`
- [x] `git push origin v22.07.00`
- Software process updates (these can all be done independently)
- [x] Update kwrobot with the new `release` branch rules (@ben.boeckel)
- [x] Run [this script][cdash-update-groups] to update the CDash groups
- This must be done after a nightly run to ensure all builds are in the
`release` group
- See the script itself for usage documentation
- [x] Add (or update if `PATCH` is greater than 0) version selection entry
in cmb-superbuild
[backport-mrs]: https://gitlab.kitware.com/utils/release-utils/-/blob/master/backport-mrs.py
[release-mr]: https://gitlab.kitware.com/utils/release-utils/-/blob/master/release-mr.py
[cdash-update-groups]: https://gitlab.kitware.com/utils/cdash-utils/-/blob/master/cdash-update-groups.py
# Post-release
- [x] Write and publish blog post with release notes.
- [x] Post an announcement in the Announcements category on
[discourse.smtk.org](https://discourse.kitware.com/c/smtk/).
- [x] Create a new commit on `master` that does the following:
- [x] Remove the deprecated methods on `master`. Note that it should be discussed before hand which deprecated methods should be removed in this release.
- [x] Set the version.txt on `master` to be 22.07.100
/cc @ben.boeckel
/cc @bob.obara
/cc @dcthompRobert M. O'BaraRobert M. O'Barahttps://gitlab.kitware.com/cmb/smtk/-/issues/490Investigate why `RemoveResource` operation fails when multi-threaded2022-07-11T13:53:40-04:00Aron HelserInvestigate why `RemoveResource` operation fails when multi-threadedFollowing up on https://gitlab.kitware.com/cmb/smtk/-/merge_requests/2773, if the `RemoveResource` operation is not pinned to the main/Qt thread, the target resource is not removed from the resource panel.
* Code inspection does not poi...Following up on https://gitlab.kitware.com/cmb/smtk/-/merge_requests/2773, if the `RemoveResource` operation is not pinned to the main/Qt thread, the target resource is not removed from the resource panel.
* Code inspection does not point to a culprit - the `qtSMTKCallObserversOnMainThreadBehavior` should execute **both** operation and resource observes on the main thread.
* When I traced the removal code in the debugger, it succeeded - the debugger changed the thread timing, masking the failure mode.Aron HelserAron Helserhttps://gitlab.kitware.com/cmb/smtk/-/issues/487qtFileItem doesn't keep value2022-06-24T12:12:41-04:00Aron HelserqtFileItem doesn't keep valueIf `qtFileItem` with the `ShowRecentFiles` option is assigned a value (or has a default value), then the user switches to a different tab or different attribute resource, and then comes back, the value is not displayed.
`qtFileItem` is...If `qtFileItem` with the `ShowRecentFiles` option is assigned a value (or has a default value), then the user switches to a different tab or different attribute resource, and then comes back, the value is not displayed.
`qtFileItem` is not retrieving the value of the `FileSystemItem` and displaying it when it is re-created.Aron HelserAron Helserhttps://gitlab.kitware.com/cmb/smtk/-/issues/482Rename or remove qtDoubleClickButton::clicked()2022-06-06T16:13:42-04:00David ThompsonRename or remove qtDoubleClickButton::clicked()Some platforms emit a warning that `clicked()` is a non-virtual function with the same name as a virtual method in its parent class.
If we can re-use the parent signal, we should remove `clicked()`. If not, we should rename it.Some platforms emit a warning that `clicked()` is a non-virtual function with the same name as a virtual method in its parent class.
If we can re-use the parent signal, we should remove `clicked()`. If not, we should rename it.Aron HelserAron Helserhttps://gitlab.kitware.com/cmb/smtk/-/issues/481Add the ability to not display an Item's label in the UI2022-06-17T14:14:51-04:00Robert M. O'BaraAdd the ability to not display an Item's label in the UIThere are cases where the item's label is redundant and should not be displayed. Currently you can set it to a "&nbsp;" but the Qt Elements that make up the label as still created and can take up space. What is needed is to not display...There are cases where the item's label is redundant and should not be displayed. Currently you can set it to a " " but the Qt Elements that make up the label as still created and can take up space. What is needed is to not display the Qt Elements at all if the label is set to " " and if the item is not optional (the optional checkbox is also one of those label related Qt Elements). Currently the ParaView related qtItems do this but this should be extended to all qtItems.John TourtellottJohn Tourtellotthttps://gitlab.kitware.com/cmb/smtk/-/issues/480Changing the way defaults work in the attribute resource UI2022-07-06T09:46:05-04:00Robert M. O'BaraChanging the way defaults work in the attribute resource UICurrently, when an Item that has a default value is set to an illegal value vi the UI , it is restored to its default value when the Item View is refreshed or recreated. Based on feedback this is not the most intuitive behavior. Instea...Currently, when an Item that has a default value is set to an illegal value vi the UI , it is restored to its default value when the Item View is refreshed or recreated. Based on feedback this is not the most intuitive behavior. Instead it has been proposed that a mechanism should be made available to the user to explicitly set the item to its default value.
Possible approaches are a custom button, or a context menu. Due to space issues, a context menu seems to be the best approach.Aron HelserAron Helserhttps://gitlab.kitware.com/cmb/smtk/-/issues/479Release SMTK 22.052022-11-28T11:22:46-05:00Robert M. O'BaraRelease SMTK 22.05<!--
This template is for tracking a release of smtk. Please replace the
following strings with the associated values:
- `VERSION`: e.g. yy.mm.n
- `MAJOR`: e.g. yy is the year
- `MINOR`: e.g. mm is the month
- `PATCH`: e.g. the ...<!--
This template is for tracking a release of smtk. Please replace the
following strings with the associated values:
- `VERSION`: e.g. yy.mm.n
- `MAJOR`: e.g. yy is the year
- `MINOR`: e.g. mm is the month
- `PATCH`: e.g. the release sequence number (start at 0)
- `BRANCHPOINT`: The commit where the release should be started - it is a point on master where the release process branch is started from. The release process branch will have multiple commits including the assembling of release notes and changing of the version.
Please remove this comment.
-->
# Preparatory steps
- Make sure you have run the `utility/SetupForDevelopment.sh` script.
- Update smtk guides
# Update smtk
- Update the local copy of the base branch.
- If `PATCH` is 0, update `master`
- Otherwise, update `release`
- [x] `git fetch origin`
- [x] `git checkout $branch`
- [x] `git merge --ff-only origin/$branch`
- If this fails, there are local commits that need to be removed
- Ensure that changes intended for the release are in it.
- The [`backport-mrs.py`][backport-mrs] script can be used to find and
ensure that merge requests assigned to the associated milestone are
available on the `release` branch. See its documentation for usage.
- Integrate changes.
- Create branch for release commits
- [x] `git checkout -b update-to-v22.05.0 36b1030b6a79dc72779c981de509e1f7434ccdc6`
- Make a commit for each of these `release`-only changes:
- [x] Assemble release notes into `doc/release/smtk-22.05.rst`.
- [x] Top of release notes should have `.. _release-notes-22.05:` and a reference to the previous release's notes (See `doc/release/smtk-21.07.rst` or later for an example.)
- [x] Add reference to new release notes to `doc/release/index.rst`. (This publishes release notes on read-the-docs.)
- [x] Update the ReadMe file to refer to the new release notes
- [x] If `PATCH` is greater than 0, add items to the end of this file.
- [x] `git rm` all of the individual release note files *except* `00-example.rst`.
- [x] Do a git add for ReadMe, index.rst, and smtk-22.05.rst
- [x] `git commit -m 'Compile release notes for 22.05.0'`
- [x] Update `version.txt` and tag the commit (tag this commit below)
- [x] `echo 22.05.0 > version.txt`
- [x] Rebuild smtk to check for deprecation warnings
- [x] `git commit -m 'Update version number to 22.05.0' version.txt` (commit message must be verbatum)
- [x] Update `.gitlab/ci/cdash-groups.json` to track the `release` CDash
groups.
- [x] Change "master" => "release" everywhere in `.gitlab/ci/cdash-groups.json`,
and change "latest-master" => "latest-release".
- [x] `git commit -m 'Update cdash-groups.json to track the release group' .gitlab/ci/cdash-groups.json`
- Create a merge request targeting `release`
- [x] Obtain a GitLab API token for the `kwrobot.release.cmb` user (ask
@ben.boeckel if you do not have one)
- [x] Add the `kwrobot.release.cmb` user to your fork with at least
`Developer` privileges (so it can open MRs)
- [x] Use [the `release-mr`][release-mr] script to open the create the
Merge Request (see script for usage)
- Pull the script for each release; it may have been updated since it
was last used
- The script outputs the information it will be using to create the
merge request. Please verify that it is all correct before creating
the merge request. See usage at the top of the script to provide
information that is either missing or incorrect (e.g., if its data
extraction heuristics fail).
- [x] Get positive review
- [x] Get a repo maintainer (currently Ben) or owner (currently Bob) to`Do: merge`
- [x] Get a repo maintainer or ownder to push the tag to the main repository
- [x] `git tag -a -m 'SMTK 22.05.0' v22.05.0 commit-that-updated-version.txt`
- [x] `git push origin v22.05.0`
- Software process updates (these can all be done independently)
- [ ] Update kwrobot with the new `release` branch rules (@ben.boeckel)
- [x] Run [this script][cdash-update-groups] to update the CDash groups
- This must be done after a nightly run to ensure all builds are in the
`release` group
- See the script itself for usage documentation
- [ ] Add (or update if `PATCH` is greater than 0) version selection entry
in cmb-superbuild
[backport-mrs]: https://gitlab.kitware.com/utils/release-utils/-/blob/master/backport-mrs.py
[release-mr]: https://gitlab.kitware.com/utils/release-utils/-/blob/master/release-mr.py
[cdash-update-groups]: https://gitlab.kitware.com/utils/cdash-utils/-/blob/master/cdash-update-groups.py
# Post-release
- [x] Write and publish blog post with release notes.
- [x] Post an announcement in the Announcements category on
[discourse.smtk.org](https://discourse.kitware.com/c/smtk/).
- [x] Create a new commit on `master` that does the following:
- [x] Remove the deprecated methods on `master`. Note that it should be discussed before hand which deprecated methods should be removed in this release.
- [x] Set the version.txt on `master` to be yy.mm.100
/cc @ben.boeckel
/cc @bob.obara
/cc @dcthompRobert M. O'BaraRobert M. O'Barahttps://gitlab.kitware.com/cmb/smtk/-/issues/478Add QSortFilterProxyModel to ResourceBrowser2022-06-20T13:43:17-04:00Aron HelserAdd QSortFilterProxyModel to ResourceBrowserIn order to enable a search bar in the resource browser, add an optional QSortFilterProxyModel in addition to the existing model.
* Use the json config to control whether the search bar is on
* If the search bar is enabled, the QSortFil...In order to enable a search bar in the resource browser, add an optional QSortFilterProxyModel in addition to the existing model.
* Use the json config to control whether the search bar is on
* If the search bar is enabled, the QSortFilterProxyModel will filter the default model, and a text-item search bar is added to the widget.
Leaning towards enabling the search bar by default in the main resource panel.Aron HelserAron Helserhttps://gitlab.kitware.com/cmb/smtk/-/issues/477Refactor SMTK dock widgets2022-06-15T09:18:25-04:00Aron HelserRefactor SMTK dock widgetsSome clients of SMTK wish to use the current dock widgets in other kinds of widgets, or grouped together in a single panel. To support this:
* Current Panels should inherit from QWidget instead of QDockWidget
* When the panels are create...Some clients of SMTK wish to use the current dock widgets in other kinds of widgets, or grouped together in a single panel. To support this:
* Current Panels should inherit from QWidget instead of QDockWidget
* When the panels are created, a parent `pqSMTKDockWidget` is created, and the Panel is added as the main widget
Identified issues:
* AttributePanel changes its own title. Instead it needs to emit a signal that is caught by `pqSMTKDockWidget`
* ProjectPanel needs to be included and available outside its plugin. It will need to be moved to `extensions/paraview` in a new library, and the current plugin moved and changed to reference that library.Aron HelserAron Helserhttps://gitlab.kitware.com/cmb/smtk/-/issues/474Refactor SMTK ParaView plugins2022-05-18T13:56:33-04:00David ThompsonRefactor SMTK ParaView plugins+ [x] Most if not all of the source files in `smtk/extension/paraview/appcomponents/plugin-core` should be moved up one directory and put into the smtkPQComponentsExt **library** (where they can be used by plugins) rather than in the smt...+ [x] Most if not all of the source files in `smtk/extension/paraview/appcomponents/plugin-core` should be moved up one directory and put into the smtkPQComponentsExt **library** (where they can be used by plugins) rather than in the smtkPQComponentsPlugin **plugin**.
+ [x] Beyond moving these files, we may wish to split functionality from smtkPQComponentsPlugin into multiple plugins. Certainly the autostart for pqSMTKBehavior could be separated into its own plugin so that plugin could be used without establishing reader/writer support, dock widgets, etc. @jwilson1881 Are there others?Aron HelserAron Helserhttps://gitlab.kitware.com/cmb/smtk/-/issues/473Release SMTK 22.042022-05-04T17:07:25-04:00Robert M. O'BaraRelease SMTK 22.04<!--
This template is for tracking a release of smtk. Please replace the
following strings with the associated values:
- `VERSION`: e.g. yy.mm.n
- `MAJOR`: e.g. yy is the year
- `MINOR`: e.g. mm is the month
- `PATCH`: e.g. the ...<!--
This template is for tracking a release of smtk. Please replace the
following strings with the associated values:
- `VERSION`: e.g. yy.mm.n
- `MAJOR`: e.g. yy is the year
- `MINOR`: e.g. mm is the month
- `PATCH`: e.g. the release sequence number (start at 0)
- `BRANCHPOINT`: The commit where the release should be started - it is a point on master where the release process branch is started from. The release process branch will have multiple commits including the assembling of release notes and changing of the version.
Please remove this comment.
-->
# Preparatory steps
- Make sure you have run the `utility/SetupForDevelopment.sh` script.
- Update smtk guides
# Update smtk
- Update the local copy of the base branch.
- If `PATCH` is 0, update `master`
- Otherwise, update `release`
- [x] `git fetch origin`
- [x] `git checkout $branch`
- [x] `git merge --ff-only origin/$branch`
- If this fails, there are local commits that need to be removed
- Ensure that changes intended for the release are in it.
- The [`backport-mrs.py`][backport-mrs] script can be used to find and
ensure that merge requests assigned to the associated milestone are
available on the `release` branch. See its documentation for usage.
- Integrate changes.
- Create branch for release commits
- [x] `git checkout -b update-to-v22.04.0 7cedaee48c1e2743841587692f24140f84a96d4b`
- Make a commit for each of these `release`-only changes:
- [x] Assemble release notes into `doc/release/smtk-22.04.rst`.
- [x] Top of release notes should have `.. _release-notes-22.04:` and a reference to the previous release's notes (See `doc/release/smtk-21.07.rst` or later for an example.)
- [x] Add reference to new release notes to `doc/release/index.rst`. (This publishes release notes on read-the-docs.)
- [x] Update the ReadMe file to refer to the new release notes
- [x] If `PATCH` is greater than 0, add items to the end of this file.
- [x] `git rm` all of the individual release note files *except* `00-example.rst`.
- [x] Do a git add for ReadMe, index.rst, and smtk-22.04.rst
- [x] `git commit -m 'Compile release notes for 22.04.0'`
- [x] Update `version.txt` and tag the commit (tag this commit below)
- [x] `echo 22.04.0 > version.txt`
- [x] Rebuild smtk to check for deprecation warnings
- [x] `git commit -m 'Update version number to 22.04.0' version.txt` (commit message must be verbatum)
- [x] Update `.gitlab/ci/cdash-groups.json` to track the `release` CDash
groups.
- [x] Change "master" => "release" everywhere in `.gitlab/ci/cdash-groups.json`,
and change "latest-master" => "latest-release".
- [x] `git commit -m 'Update cdash-groups.json to track the release group' .gitlab/ci/cdash-groups.json`
- Create a merge request targeting `release`
- [x] Obtain a GitLab API token for the `kwrobot.release.cmb` user (ask
@ben.boeckel if you do not have one)
- [x] Add the `kwrobot.release.cmb` user to your fork with at least
`Developer` privileges (so it can open MRs)
- [x] Use [the `release-mr`][release-mr] script to open the create the
Merge Request (see script for usage)
- Pull the script for each release; it may have been updated since it
was last used
- The script outputs the information it will be using to create the
merge request. Please verify that it is all correct before creating
the merge request. See usage at the top of the script to provide
information that is either missing or incorrect (e.g., if its data
extraction heuristics fail).
- [x] Get positive review
- [x] Get a repo maintainer (currently Ben) or owner (currently Bob) to`Do: merge`
- [x] Get a repo maintainer or ownder to push the tag to the main repository
- [x] `git tag -a -m 'SMTK 22.04.0' v22.04.0 commit-that-updated-version.txt`
- [x] `git push origin v22.04.0`
- Software process updates (these can all be done independently)
- [x] Update kwrobot with the new `release` branch rules (@ben.boeckel)
- [x] Run [this script][cdash-update-groups] to update the CDash groups
- This must be done after a nightly run to ensure all builds are in the
`release` group
- See the script itself for usage documentation
- [ ] Add (or update if `PATCH` is greater than 0) version selection entry
in cmb-superbuild
[backport-mrs]: https://gitlab.kitware.com/utils/release-utils/-/blob/master/backport-mrs.py
[release-mr]: https://gitlab.kitware.com/utils/release-utils/-/blob/master/release-mr.py
[cdash-update-groups]: https://gitlab.kitware.com/utils/cdash-utils/-/blob/master/cdash-update-groups.py
# Post-release
- [x] Write and publish blog post with release notes.
- [x] Post an announcement in the Announcements category on
[discourse.smtk.org](https://discourse.kitware.com/c/smtk/).
- [x] Create a new commit on `master` that does the following:
- [x] Remove the deprecated methods on `master`. Note that it should be discussed before hand which deprecated methods should be removed in this release.
- [x] Set the version.txt on `master` to be yy.mm.100
/cc @ben.boeckel
/cc @bob.obara
/cc @dcthompRobert M. O'BaraRobert M. O'Barahttps://gitlab.kitware.com/cmb/smtk/-/issues/471Expressions with an underscore in a variable name fail to evaluate2022-06-27T10:11:20-04:00David ThompsonExpressions with an underscore in a variable name fail to evaluateTo reproduce:
1. Create an expression named `infixExpression_0` and set its symbolic value to 0
2. Create a second expression named `infixExpression_1` and set its symbolic value to `{infixExpression_0}`. This will show "Evaluation fail...To reproduce:
1. Create an expression named `infixExpression_0` and set its symbolic value to 0
2. Create a second expression named `infixExpression_1` and set its symbolic value to `{infixExpression_0}`. This will show "Evaluation failed" for its computed value.
As a workaround, rename `infixExpression_0` to `infixExpression0` and update `infixExpression_1`'s symbolic value. The computed value will now be correct.
@jwilson1881 @rohit.krishnaAron HelserAron Helserhttps://gitlab.kitware.com/cmb/smtk/-/issues/469SMTK build error: VTK::ViewsInfovis dependency is missing for vtkSMTKSourceExt2022-03-24T18:15:45-04:00Nate deVelderSMTK build error: VTK::ViewsInfovis dependency is missing for vtkSMTKSourceExt
Hi! This might be an easy fix, but I'm trying to do a spack build of CMB, and running into a VTK error when building the latest master of SMTK. I've built paraview 5.10.0 for this, but maybe something changed in the vtk modules that ...
Hi! This might be an easy fix, but I'm trying to do a spack build of CMB, and running into a VTK error when building the latest master of SMTK. I've built paraview 5.10.0 for this, but maybe something changed in the vtk modules that SMTK doesn't like? i.e. "The VTK::ViewsInfovis dependency is missing for vtkSMTKSourceExt."
Does anyone have any tips/thoughts on getting past this? Should I not be using the latest versions of both paraview and smtk? Did I do something else wrong? Thanks for your help!
45 -- Performing Test COMPILER_HAS_HIDDEN_INLINE_VISIBILITY
46 -- Performing Test COMPILER_HAS_HIDDEN_INLINE_VISIBILITY - Success
47 -- Performing Test COMPILER_HAS_DEPRECATED_ATTR
48 -- Performing Test COMPILER_HAS_DEPRECATED_ATTR - Success
49 -- Looking for C++ include functional
50 -- Looking for C++ include functional - found
>> 51 CMake Error at /projects/wind/cmb/spack-manager/spack/opt/spack/linux-rhel7-cascadelake/gcc-9.3.1/paraview-5.10.0-4bfjidivjeerq6ayuv276qkgv4nsiqs6/lib64/cmake/paraview-5.10/vtk/vtkModule.cmake:2512 (
message):
52 The VTK::ViewsInfovis dependency is missing for vtkSMTKSourceExt.
53 Call Stack (most recent call first):
54 smtk/extension/vtk/CMakeLists.txt:14 (vtk_module_build)
55
56
57 -- Configuring incomplete, errors occurred!https://gitlab.kitware.com/cmb/smtk/-/issues/468Change to display volume surfaces broke AEVA widgets2022-03-24T13:47:22-04:00Aron HelserChange to display volume surfaces broke AEVA widgetsAeva is no longer able to show data for its image 3D widgets, after https://gitlab.kitware.com/cmb/smtk/-/merge_requests/2682 was added to SMTK.
Load either dataset in "aeva-session/data/itk/" and select the "scalars" volume, click the ...Aeva is no longer able to show data for its image 3D widgets, after https://gitlab.kitware.com/cmb/smtk/-/merge_requests/2682 was added to SMTK.
Load either dataset in "aeva-session/data/itk/" and select the "scalars" volume, click the 3-slice toolbar button. Nothing is shown. Expect a 3-slice widget to show with draggable slice planes.