SMTK issueshttps://gitlab.kitware.com/cmb/smtk/-/issues2023-03-28T11:33:56-04:00https://gitlab.kitware.com/cmb/smtk/-/issues/507Clean up export macros2023-03-28T11:33:56-04:00David ThompsonClean up export macros## Missing `SMTK_ALWAYS_EXPORT`
- smtk/attribute/CustomItem.h
- smtk/attribute/CustomItemDefinition.h
- smtk/common/Generator.h
- smtk/common/Links.h
- smtk/common/Observers.h
- smtk/common/RangeDetector.h
- smtk/common/TypeName.h
- smt...## Missing `SMTK_ALWAYS_EXPORT`
- smtk/attribute/CustomItem.h
- smtk/attribute/CustomItemDefinition.h
- smtk/common/Generator.h
- smtk/common/Links.h
- smtk/common/Observers.h
- smtk/common/RangeDetector.h
- smtk/common/TypeName.h
- smtk/common/UnionFind.h (UnionFindSet and UnionFind classes)
- smtk/common/WeakReferenceWrapper.h
- smtk/common/update/Factory.h
- smtk/extension/paraview/appcomponents/pqSMTKDock.h
- smtk/extension/paraview/server/vtkSMTKRepresentationStyleGenerator.h (vtkSMTKRepresentationStyleSupplier class)
- smtk/extension/vtk/io/ImportAsVTKData.h (ImportAsVTKDataType class)
- smtk/geometry/Cache.h
- smtk/geometry/GeometryForBackend.h
- smtk/graph/ArcImplementation.h (ArcImplementation ArcEndpointInterface classes)
- smtk/graph/ArcProperties.h
- smtk/graph/ExplicitArcs.h
- smtk/graph/NodeProperties.h
- maybe smtk/graph/detail/TypeTraits.h
- maybe smtk/plugin/Registry.h
- smtk/resource/DerivedFrom.h
- smtk/resource/Manager.h (is_derived_resource)
- smtk/resource/Metadata.h
- smtk/resource/Properties.h (PropertiesOfType, ConstPropertiesOfType classes)
- maybe smtk/resource/Resource.h (Key class)
- maybe smtk/resource/ResourceLinks.h (ResourceLinksBase class)
- smtk/resource/filter/Filter.h
- smtk/resource/filter/Rule.h
- smtk/resource/pybind11/PyResource.h
## Missing library export macro
- smtk/attribute/filter/Attribute.h (TypeNameRule and TypeRegexRule classes)
- smtk/extension/paraview/widgets/pqSMTKAttributeItemWidgetP.h
- smtk/extension/qt/qtComponentAttributeView.h (qComponentAttributeViewComboBoxItemDelegate class)
- smtk/extension/qt/qtOperationLauncher.h (qt::Launcher class at bottom)
- smtk/mesh/moab/MergeMeshVertices.h
- smtk/mesh/moab/Tags.h
- smtk/mesh/pybind11/PybindForEachTypes.h
- smtk/model/Arrangement.h (ArrangementReference class)
- smtk/model/testing/cxx/helpers.h
- smtk/operation/pybind11/PyOperation.h
- smtk/plugin/Registry.h
- smtk/resource/filter/Rule.h
- smtk/session/polygon/internal/ActiveFragmentTree.h
- smtk/session/polygon/internal/Neighborhood.h
- smtk/view/PhraseModel.h (PhraseDeltas class)https://gitlab.kitware.com/cmb/smtk/-/issues/505Try removing sorting from PhraseModel2023-01-18T11:35:32-05:00David ThompsonTry removing sorting from PhraseModelSince SMTK now allows a QSortFilterProxyModel in between the qtDescriptivePhraseModel and each view, we may be able to avoid sorting phrases as they are inserted. We should try removing sorting and have the subphrase generator append new...Since SMTK now allows a QSortFilterProxyModel in between the qtDescriptivePhraseModel and each view, we may be able to avoid sorting phrases as they are inserted. We should try removing sorting and have the subphrase generator append new subphrases to the end of its list. This may cause some issues with `PhraseModel::updateChildren()` since it relied on sorted phrases to compress observer events.
@jwilson1881 @rohit.krishna FYI.https://gitlab.kitware.com/cmb/smtk/-/issues/502Create CMake flag to switch builds between std and boost regex2022-10-26T10:30:30-04:00Shreeraj JadhavCreate CMake flag to switch builds between std and boost regexSMTK can be built with either `std::regex` or `boost::regex`.
Create a CMake flag to toggle preprocessor directive `#define USE_BOOST_REGEX`.
This will enable SMTK to switch between these two libraries at build time.
Specifically, bui...SMTK can be built with either `std::regex` or `boost::regex`.
Create a CMake flag to toggle preprocessor directive `#define USE_BOOST_REGEX`.
This will enable SMTK to switch between these two libraries at build time.
Specifically, building with Boost is required for aevaSlicer (see: https://gitlab.kitware.com/cmb/smtk/-/merge_requests/2652).https://gitlab.kitware.com/cmb/smtk/-/issues/501Operation sequence operation2022-09-16T10:52:20-04:00David ThompsonOperation sequence operationSMTK should provide an operation that accepts as input a sequence of other operations and runs them as an atomic unit. The idea is that this parent operation would lock the union of all the resources required for its operation sequence a...SMTK should provide an operation that accepts as input a sequence of other operations and runs them as an atomic unit. The idea is that this parent operation would lock the union of all the resources required for its operation sequence and run them internally in order to prevent other operations from running on the resources in between sequence members. However, rather than invoking observers once for the parent operation, observers should be invoked for each of the sequence entries (and potentially also the parent operation).
We need to decide how failure of an operation in the sequence should be handled. The default should probably be to abandon any further operations in the sequence and report failure for the parent operation.
@jwilson1881 FYIDavid ThompsonDavid Thompsonhttps://gitlab.kitware.com/cmb/smtk/-/issues/495Problem compiling SMTK with C++ 17 using Visual Studio 222022-08-16T15:56:43-04:00Robert M. O'BaraProblem compiling SMTK with C++ 17 using Visual Studio 22The compiler crashes when processing smtk/plugin/Client.xx.
```cpp
SMTK : smtk/plugin/Client.xx
#ifndef smtk_plugin_Client_txx
#define smtk_plugin_Client_txx
#include "smtk/plugin/Client.h"
#include "smtk/plugin/ClientBase.h"
#include...The compiler crashes when processing smtk/plugin/Client.xx.
```cpp
SMTK : smtk/plugin/Client.xx
#ifndef smtk_plugin_Client_txx
#define smtk_plugin_Client_txx
#include "smtk/plugin/Client.h"
#include "smtk/plugin/ClientBase.h"
#include "smtk/plugin/Manager.h"
namespace smtk
{
namespace plugin
{
template<typename Registrar_t, typename Manager_t, typename... T>
std::shared_ptr<ClientBase> Client<Registrar_t, Manager_t, T...>::create()
{
std::shared_ptr<Client<Registrar_t, Manager_t, T...>> shared(
new Client<Registrar_t, Manager_t, T...>);
smtk::plugin::Manager::instance()->addClient(
std::static_pointer_cast<ClientBase>(shared->ClientBase::shared_from_this())); <-----
return std::static_pointer_cast<ClientBase>(shared);
}
} // namespace plugin
} // namespace smtk
#endif
```
The indicated line is where the compiler crashed.
If the file CMake/smtkPluginInitializer.cxx.in is changed to this:
```cpp
namespace smtk
{
namespace plugin
{
template<>
std::shared_ptr<ClientBase>
Client<
@_smtk_plugin_REGISTRAR@,
@_smtk_plugin_managers@
>::create()
{
std::shared_ptr<
Client<@_smtk_plugin_REGISTRAR@,
@_smtk_plugin_managers@>>
shared(new Client<@_smtk_plugin_REGISTRAR@,
@_smtk_plugin_managers@>);
smtk::plugin::Manager::instance()->addClient(
std::static_pointer_cast<ClientBase>(shared->ClientBase::shared_from_this()));
return std::static_pointer_cast<ClientBase>(shared);
}
} // namespace plugin
} // namespace smtk
namespace smtk
{
namespace plugin
{
namespace init
{
using Client = smtk::plugin::Client<
@_smtk_plugin_REGISTRAR@,
@_smtk_plugin_managers@
>;
static std::shared_ptr<Client> myClient;
void @_smtk_plugin_autostart_name@()
{
myClient = std::dynamic_pointer_cast<Client>(Client::create());
}
}
}
}
```
Which includes a manual installation of the template for ClientBase - the code will compiler.
The question is "Is this ok to put in as a workaround for Visual Studio?" Assuming it is properly ifdef'd.Ben BoeckelBen Boeckelhttps://gitlab.kitware.com/cmb/smtk/-/issues/489Segfault in operation association widget after closing/opening resource2022-07-20T13:11:10-04:00Aron HelserSegfault in operation association widget after closing/opening resourceThe reference item widget in the operation parameters seems to trigger a segfault when it was last used on a resource that was closed.
To repro:
* Open a model, like `3D/exodus/knee.smtk`
* Select some faces, use the Assign Colors opera...The reference item widget in the operation parameters seems to trigger a segfault when it was last used on a resource that was closed.
To repro:
* Open a model, like `3D/exodus/knee.smtk`
* Select some faces, use the Assign Colors operation, from the Toolbox and Tool Parameters panels.
* File .. Close Resource
* Open another model, like `2D/smtk/epic-trex-drummer.smtk`
* Move the mouse over the associations widget at the top of the Tool Parameters.
* Segfaulthttps://gitlab.kitware.com/cmb/smtk/-/issues/488Does "Show by Category" work any more?2022-06-23T16:55:12-04:00John TourtellottDoes "Show by Category" work any more?Maybe I am getting the syntax wrong, but I cannot get the "Show by Category" feature to work.
1. Start modelbuilder
2. Open the attached template file [categoryExamples.sbt](/uploads/b69bfd144e9d8c48f0a390e96078ca9b/categoryExamples.sbt...Maybe I am getting the syntax wrong, but I cannot get the "Show by Category" feature to work.
1. Start modelbuilder
2. Open the attached template file [categoryExamples.sbt](/uploads/b69bfd144e9d8c48f0a390e96078ca9b/categoryExamples.sbt)
3. Check the "Show by Category" box
4. No matter what you set the "Show by Category" combo box to, all 3 attributes are displayed.
I am using linux again, last night's CI build. (I sure hope this doesn't just work on macOS.)https://gitlab.kitware.com/cmb/smtk/-/issues/486modelbuilder crash (linux)2022-06-23T16:07:58-04:00John Tourtellottmodelbuilder crash (linux)1\. I observed an unexpected crash when using modelbuilder. Testing with the 22-Jun-2022 nightly build (linux):
1. Start modelbuilder
2. Load the template file at `smtk/data/attribute/attribute_collection/ConfigurationTest.sbt`
3. In th...1\. I observed an unexpected crash when using modelbuilder. Testing with the 22-Jun-2022 nightly build (linux):
1. Start modelbuilder
2. Load the template file at `smtk/data/attribute/attribute_collection/ConfigurationTest.sbt`
3. In the attribute editor's "Configurations" tab, click "New" to create a new analysis.
4. In the editor field, click the checkbox next to "Heat Transfer" ==> _most of the time_ modelbuilder crashes
2\. Also tested macOS-x86: no problem.
<details>
<summary>Stack trace</summary>
```
Stack trace:
26 0x40f92d ./bin/modelbuilder() [0x40f92d]
25 0x7f8e9f6c0083 __libc_start_main + 243
24 0x40f3c1 ./bin/modelbuilder() [0x40f3c1]
23 0x7f8eafb594e0 QCoreApplication::exec() + 128
22 0x7f8eafb509ea QEventLoop::exec(QFlags<QEventLoop::ProcessEventsFlag>) + 298
21 0x7f8e8f52b233 /home/local/KHQ/john.tourtellott/temp/nightly/modelbuilder/modelbuilder-22.04.100-Linux-x86_64/plugins/platforms/../../lib/libQt5XcbQpa.so.5(+0x60233) [0x7f8e8f52b233]
20 0x7f8eaff6703b QWindowSystemInterface::sendWindowSystemEvents(QFlags<QEventLoop::ProcessEventsFlag>) + 187
19 0x7f8eaff8ba95 QGuiApplicationPrivate::processWindowSystemEvent(QWindowSystemInterfacePrivate::WindowSystemEvent*) + 261
18 0x7f8eaff8a80d QGuiApplicationPrivate::processMouseEvent(QWindowSystemInterfacePrivate::MouseEvent*) + 1837
17 0x7f8eafb52198 QCoreApplication::notifyInternal2(QObject*, QEvent*) + 280
16 0x7f8eb0606900 QApplication::notify(QObject*, QEvent*) + 704
15 0x7f8eb05ff82c QApplicationPrivate::notify_helper(QObject*, QEvent*) + 156
14 0x7f8eb0659fbb /home/local/KHQ/john.tourtellott/temp/nightly/modelbuilder/modelbuilder-22.04.100-Linux-x86_64/bin/../lib/libQt5Widgets.so.5(+0x1bcfbb) [0x7f8eb0659fbb]
13 0x7f8eb0657446 /home/local/KHQ/john.tourtellott/temp/nightly/modelbuilder/modelbuilder-22.04.100-Linux-x86_64/bin/../lib/libQt5Widgets.so.5(+0x1ba446) [0x7f8eb0657446]
12 0x7f8eb0605e6c QApplicationPrivate::sendMouseEvent(QWidget*, QMouseEvent*, QWidget*, QWidget*, QWidget**, QPointer<QWidget>&, bool, bool) + 460
11 0x7f8eafb52198 QCoreApplication::notifyInternal2(QObject*, QEvent*) + 280
10 0x7f8eb0607468 QApplication::notify(QObject*, QEvent*) + 3624
9 0x7f8eb05ff82c QApplicationPrivate::notify_helper(QObject*, QEvent*) + 156
8 0x7f8eb063d2d8 QWidget::event(QEvent*) + 424
7 0x7f8eb06e3015 QAbstractButton::mouseReleaseEvent(QMouseEvent*) + 213
6 0x7f8eb06e2ddb /home/local/KHQ/john.tourtellott/temp/nightly/modelbuilder/modelbuilder-22.04.100-Linux-x86_64/bin/../lib/libQt5Widgets.so.5(+0x245ddb) [0x7f8eb06e2ddb]
5 0x7f8eb06f29ee QCheckBox::stateChanged(int) + 46
4 0x7f8eafb806a4 QMetaObject::activate(QObject*, int, int, void**) + 2100
3 0x7f8eb0d17da2 smtk::extension::qtGroupItem::setEnabledState(int) + 178
2 0x7f8eafb805aa QMetaObject::activate(QObject*, int, int, void**) + 1850
1 0x7f8eafb7fe74 QMetaObject::activate(QObject*, int, int, void**) + 4
0 0x7f8e9fdf7420 /lib/x86_64-linux-gnu/libpthread.so.0(+0x14420) [0x7f8e9fdf7420]
( 10.467s) [paraview ] :0 FATL| Signal: SIGSEGV
Segmentation fault (core dumped)
```
</details>https://gitlab.kitware.com/cmb/smtk/-/issues/483Using python shell crashes modelbuilder2022-06-02T11:27:53-04:00John TourtellottUsing python shell crashes modelbuilderThis is technically a cmb issue, but it overlaps with smtk::common::PythonInterpreter. If you start modelbuilder from a command line and use the python shell as little as:
```
import smtk
import smtk.common
```
modelbuilder segfaults w...This is technically a cmb issue, but it overlaps with smtk::common::PythonInterpreter. If you start modelbuilder from a command line and use the python shell as little as:
```
import smtk
import smtk.common
```
modelbuilder segfaults when it exits.
* Stack trace is below.
* Note that the python shell dock widget instantiates a `vtkPythonInterpreter` and the crash occurs when finalizing `smtk::common::PythonInterpreter` which I _think_ is the superbuild's python. Whatever the case, there is some overlap in the vtk garbage collection code that ends with a null pointer call when the smtk::common::PythonInterpreter is finalized. Is there anyway to avoid this?
<details>
<summary>Stack trace</summary>
```
GNU DDD 3.3.12 (x86_64-pc-linux-gnu), by Dorothea LReading symbols from /home/local/KHQ/john.tourtellott/projects/cmb-master/build/cmb/bin/modelbuilder...
(gdb) run
Starting program: /home/local/KHQ/john.tourtellott/projects/cmb-master/build/cmb/bin/modelbuilder
[Thread debugging using libthread_db enabled]
Using host libthread_db library "/lib/x86_64-linux-gnu/libthread_db.so.1".
[New Thread 0x7fffd4948700 (LWP 952736)]
[New Thread 0x7fffce7de700 (LWP 952737)]
[New Thread 0x7fffcdfdd700 (LWP 952738)]
[New Thread 0x7fffc7fff700 (LWP 952739)]
Replacing existing manager for function : "smtk project menu"
[Thread 0x7fffd4948700 (LWP 952736) exited]
[Thread 0x7fffc7fff700 (LWP 952739) exited]
Thread 1 "modelbuilder" received signal SIGSEGV, Segmentation fault.
0x0000000000000000 in ?? ()
(gdb) where
#0 0x0000000000000000 in ?? ()
#1 0x00007fffe93bb581 in vtkInformation::ReportReferences (this=0x555557f19480, collector=0x7fffffffc330) at /home/local/KHQ/john.tourtellott/projects/cmb-master/build/cmb-superbuild/superbuild/paraview/src/VTK/Common/Core/vtkInformation.cxx:929
#2 0x00007fffe93acf79 in vtkGarbageCollectorToObjectBaseFriendship::ReportReferences (self=0x7fffffffc330, obj=0x555557f19480) at /home/local/KHQ/john.tourtellott/projects/cmb-master/build/cmb-superbuild/superbuild/paraview/src/VTK/Common/Core/vtkGarbageCollector.cxx:114
#3 0x00007fffe93aac58 in vtkGarbageCollectorImpl::VisitTarjan (this=0x7fffffffc330, obj=0x555557f19480) at /home/local/KHQ/john.tourtellott/projects/cmb-master/build/cmb-superbuild/superbuild/paraview/src/VTK/Common/Core/vtkGarbageCollector.cxx:555
#4 0x00007fffe93aa944 in vtkGarbageCollectorImpl::MaybeVisit (this=0x7fffffffc330, obj=0x555557f19480) at /home/local/KHQ/john.tourtellott/projects/cmb-master/build/cmb-superbuild/superbuild/paraview/src/VTK/Common/Core/vtkGarbageCollector.cxx:528
#5 0x00007fffe93ab240 in vtkGarbageCollectorImpl::Report (this=0x7fffffffc330, obj=0x555557f19480, ptr=0x555557ed0a20) at /home/local/KHQ/john.tourtellott/projects/cmb-master/build/cmb-superbuild/superbuild/paraview/src/VTK/Common/Core/vtkGarbageCollector.cxx:635
#6 0x00007fffe93ab16c in vtkGarbageCollectorImpl::Report (this=0x7fffffffc330, obj=0x555557f19480, ptr=0x555557ed0a20, desc=0x7fffe9748a0e "Entry") at /home/local/KHQ/john.tourtellott/projects/cmb-master/build/cmb-superbuild/superbuild/paraview/src/VTK/Common/Core/vtkGarbageCollector.cxx:625
#7 0x00007fffe93acd3b in vtkGarbageCollectorReportInternal (collector=0x7fffffffc330, obj=0x555557f19480, ptr=0x555557ed0a20, desc=0x7fffe9748a0e "Entry") at /home/local/KHQ/john.tourtellott/projects/cmb-master/build/cmb-superbuild/superbuild/paraview/src/VTK/Common/Core/vtkGarbageCollector.cxx:1059
#8 0x00007fffe93d209d in vtkGarbageCollectorReport<vtkInformation> (collector=0x7fffffffc330, ptr=@0x555557ed0a20: 0x555557f19480, desc=0x7fffe9748a0e "Entry") at /home/local/KHQ/john.tourtellott/projects/cmb-master/build/cmb-superbuild/superbuild/paraview/src/VTK/Common/Core/vtkGarbageCollector.h:199
#9 0x00007fffe93d1b99 in vtkInformationVector::ReportReferences (this=0x555557f09e20, collector=0x7fffffffc330) at /home/local/KHQ/john.tourtellott/projects/cmb-master/build/cmb-superbuild/superbuild/paraview/src/VTK/Common/Core/vtkInformationVector.cxx:227
#10 0x00007fffe93acf79 in vtkGarbageCollectorToObjectBaseFriendship::ReportReferences (self=0x7fffffffc330, obj=0x555557f09e20) at /home/local/KHQ/john.tourtellott/projects/cmb-master/build/cmb-superbuild/superbuild/paraview/src/VTK/Common/Core/vtkGarbageCollector.cxx:114
#11 0x00007fffe93aac58 in vtkGarbageCollectorImpl::VisitTarjan (this=0x7fffffffc330, obj=0x555557f09e20) at /home/local/KHQ/john.tourtellott/projects/cmb-master/build/cmb-superbuild/superbuild/paraview/src/VTK/Common/Core/vtkGarbageCollector.cxx:555
#12 0x00007fffe93aa944 in vtkGarbageCollectorImpl::MaybeVisit (this=0x7fffffffc330, obj=0x555557f09e20) at /home/local/KHQ/john.tourtellott/projects/cmb-master/build/cmb-superbuild/superbuild/paraview/src/VTK/Common/Core/vtkGarbageCollector.cxx:528
#13 0x00007fffe93ab240 in vtkGarbageCollectorImpl::Report (this=0x7fffffffc330, obj=0x555557f09e20, ptr=0x555557f09d80) at /home/local/KHQ/john.tourtellott/projects/cmb-master/build/cmb-superbuild/superbuild/paraview/src/VTK/Common/Core/vtkGarbageCollector.cxx:635
#14 0x00007fffe93ab16c in vtkGarbageCollectorImpl::Report (this=0x7fffffffc330, obj=0x555557f09e20, ptr=0x555557f09d80, desc=0x7fffe95dc55c "Output Information Vector") at /home/local/KHQ/john.tourtellott/projects/cmb-master/build/cmb-superbuild/superbuild/paraview/src/VTK/Common/Core/vtkGarbageCollector.cxx:625
#15 0x00007fffe93acd3b in vtkGarbageCollectorReportInternal (collector=0x7fffffffc330, obj=0x555557f09e20, ptr=0x555557f09d80, desc=0x7fffe95dc55c "Output Information Vector") at /home/local/KHQ/john.tourtellott/projects/cmb-master/build/cmb-superbuild/superbuild/paraview/src/VTK/Common/Core/vtkGarbageCollector.cxx:1059
#16 0x00007fffe839d7cb in vtkGarbageCollectorReport<vtkInformationVector> (collector=0x7fffffffc330, ptr=@0x555557f09d80: 0x555557f09e20, desc=0x7fffe95dc55c "Output Information Vector") at /home/local/KHQ/john.tourtellott/projects/cmb-master/build/cmb-superbuild/superbuild/paraview/src/VTK/Common/Core/vtkGarbageCollector.h:199
#17 0x00007fffe839a7fa in vtkExecutive::ReportReferences (this=0x555557f09d10, collector=0x7fffffffc330) at /home/local/KHQ/john.tourtellott/projects/cmb-master/build/cmb-superbuild/superbuild/paraview/src/VTK/Common/ExecutionModel/vtkExecutive.cxx:286
#18 0x00007fffe93acf79 in vtkGarbageCollectorToObjectBaseFriendship::ReportReferences (self=0x7fffffffc330, obj=0x555557f09d10) at /home/local/KHQ/john.tourtellott/projects/cmb-master/build/cmb-superbuild/superbuild/paraview/src/VTK/Common/Core/vtkGarbageCollector.cxx:114
#19 0x00007fffe93aac58 in vtkGarbageCollectorImpl::VisitTarjan (this=0x7fffffffc330, obj=0x555557f09d10) at /home/local/KHQ/john.tourtellott/projects/cmb-master/build/cmb-superbuild/superbuild/paraview/src/VTK/Common/Core/vtkGarbageCollector.cxx:555
#20 0x00007fffe93aa944 in vtkGarbageCollectorImpl::MaybeVisit (this=0x7fffffffc330, obj=0x555557f09d10) at /home/local/KHQ/john.tourtellott/projects/cmb-master/build/cmb-superbuild/superbuild/paraview/src/VTK/Common/Core/vtkGarbageCollector.cxx:528
#21 0x00007fffe93ab240 in vtkGarbageCollectorImpl::Report (this=0x7fffffffc330, obj=0x555557f09d10, ptr=0x555557f28b30) at /home/local/KHQ/john.tourtellott/projects/cmb-master/build/cmb-superbuild/superbuild/paraview/src/VTK/Common/Core/vtkGarbageCollector.cxx:635
#22 0x00007fffe93ab16c in vtkGarbageCollectorImpl::Report (this=0x7fffffffc330, obj=0x555557f09d10, ptr=0x555557f28b30, desc=0x7fffe95d9c3d "Executive") at /home/local/KHQ/john.tourtellott/projects/cmb-master/build/cmb-superbuild/superbuild/paraview/src/VTK/Common/Core/vtkGarbageCollector.cxx:625
#23 0x00007fffe93acd3b in vtkGarbageCollectorReportInternal (collector=0x7fffffffc330, obj=0x555557f09d10, ptr=0x555557f28b30, desc=0x7fffe95d9c3d "Executive") at /home/local/KHQ/john.tourtellott/projects/cmb-master/build/cmb-superbuild/superbuild/paraview/src/VTK/Common/Core/vtkGarbageCollector.cxx:1059
#24 0x00007fffe8382139 in vtkGarbageCollectorReport<vtkExecutive> (collector=0x7fffffffc330, ptr=@0x555557f28b30: 0x555557f09d10, desc=0x7fffe95d9c3d "Executive") at /home/local/KHQ/john.tourtellott/projects/cmb-master/build/cmb-superbuild/superbuild/paraview/src/VTK/Common/Core/vtkGarbageCollector.h:199
#25 0x00007fffe837caec in vtkAlgorithm::ReportReferences (this=0x555557f28ab0, collector=0x7fffffffc330) at /home/local/KHQ/john.tourtellott/projects/cmb-master/build/cmb-superbuild/superbuild/paraview/src/VTK/Common/ExecutionModel/vtkAlgorithm.cxx:931
#26 0x00007fffe93acf79 in vtkGarbageCollectorToObjectBaseFriendship::ReportReferences (self=0x7fffffffc330, obj=0x555557f28ab0) at /home/local/KHQ/john.tourtellott/projects/cmb-master/build/cmb-superbuild/superbuild/paraview/src/VTK/Common/Core/vtkGarbageCollector.cxx:114
#27 0x00007fffe93aac58 in vtkGarbageCollectorImpl::VisitTarjan (this=0x7fffffffc330, obj=0x555557f28ab0) at /home/local/KHQ/john.tourtellott/projects/cmb-master/build/cmb-superbuild/superbuild/paraview/src/VTK/Common/Core/vtkGarbageCollector.cxx:555
#28 0x00007fffe93aa944 in vtkGarbageCollectorImpl::MaybeVisit (this=0x7fffffffc330, obj=0x555557f28ab0) at /home/local/KHQ/john.tourtellott/projects/cmb-master/build/cmb-superbuild/superbuild/paraview/src/VTK/Common/Core/vtkGarbageCollector.cxx:528
#29 0x00007fffe93aa882 in vtkGarbageCollectorImpl::FindComponents (this=0x7fffffffc330, root=0x555557f28ab0) at /home/local/KHQ/john.tourtellott/projects/cmb-master/build/cmb-superbuild/superbuild/paraview/src/VTK/Common/Core/vtkGarbageCollector.cxx:514
#30 0x00007fffe93aa66f in vtkGarbageCollectorImpl::CollectInternal (this=0x7fffffffc330, root=0x555557f28ab0) at /home/local/KHQ/john.tourtellott/projects/cmb-master/build/cmb-superbuild/superbuild/paraview/src/VTK/Common/Core/vtkGarbageCollector.cxx:465
#31 0x00007fffe93ac688 in vtkGarbageCollector::Collect (root=0x555557f28ab0) at /home/local/KHQ/john.tourtellott/projects/cmb-master/build/cmb-superbuild/superbuild/paraview/src/VTK/Common/Core/vtkGarbageCollector.cxx:898
#32 0x00007fffe9454a73 in vtkObjectBase::UnRegisterInternal (this=0x555557f28ab0, check=1) at /home/local/KHQ/john.tourtellott/projects/cmb-master/build/cmb-superbuild/superbuild/paraview/src/VTK/Common/Core/vtkObjectBase.cxx:350
#33 0x00007fffe9452bc1 in vtkObject::UnRegisterInternal (this=0x555557f28ab0, o=0x0, check=1) at /home/local/KHQ/john.tourtellott/projects/cmb-master/build/cmb-superbuild/superbuild/paraview/src/VTK/Common/Core/vtkObject.cxx:926
#34 0x00007fffe94548fc in vtkObjectBase::UnRegister (this=0x555557f28ab0, o=0x0) at /home/local/KHQ/john.tourtellott/projects/cmb-master/build/cmb-superbuild/superbuild/paraview/src/VTK/Common/Core/vtkObjectBase.cxx:297
#35 0x00007fffe94ede03 in vtkSmartPointerBase::~vtkSmartPointerBase (this=0x7fffffffc630, __in_chrg=<optimized out>) at /home/local/KHQ/john.tourtellott/projects/cmb-master/build/cmb-superbuild/superbuild/paraview/src/VTK/Common/Core/vtkSmartPointerBase.cxx:60
#36 0x00007fffe94ede68 in vtkSmartPointerBase::operator= (this=0x555557f68d48, r=0x0) at /home/local/KHQ/john.tourtellott/projects/cmb-master/build/cmb-superbuild/superbuild/paraview/src/VTK/Common/Core/vtkSmartPointerBase.cxx:74
#37 0x00007ffff4136700 in vtkSmartPointer<vtkObjectBase>::operator= (this=0x555557f68d48, r=...) at /home/local/KHQ/john.tourtellott/projects/cmb-master/build/cmb-superbuild/superbuild/paraview/src/VTK/Common/Core/vtkSmartPointer.h:144
#38 0x00007ffff4159fa5 in vtkSIProxy::DeleteVTKObjects (this=0x555557f68ca0) at /home/local/KHQ/john.tourtellott/projects/cmb-master/build/cmb-superbuild/superbuild/paraview/src/Remoting/ServerManager/vtkSIProxy.cxx:402
#39 0x00007ffff415805d in vtkSIProxy::~vtkSIProxy (this=0x555557f68ca0, __in_chrg=<optimized out>) at /home/local/KHQ/john.tourtellott/projects/cmb-master/build/cmb-superbuild/superbuild/paraview/src/Remoting/ServerManager/vtkSIProxy.cxx:100
#40 0x00007ffff417275c in vtkSISourceProxy::~vtkSISourceProxy (this=0x555557f68ca0, __in_chrg=<optimized out>) at /home/local/KHQ/john.tourtellott/projects/cmb-master/build/cmb-superbuild/superbuild/paraview/src/Remoting/ServerManager/vtkSISourceProxy.cxx:64
#41 0x00007ffff4172780 in vtkSISourceProxy::~vtkSISourceProxy (this=0x555557f68ca0, __in_chrg=<optimized out>) at /home/local/KHQ/john.tourtellott/projects/cmb-master/build/cmb-superbuild/superbuild/paraview/src/Remoting/ServerManager/vtkSISourceProxy.cxx:68
#42 0x00007fffe9454a5f in vtkObjectBase::UnRegisterInternal (this=0x555557f68ca0, check=0) at /home/local/KHQ/john.tourtellott/projects/cmb-master/build/cmb-superbuild/superbuild/paraview/src/VTK/Common/Core/vtkObjectBase.cxx:342
#43 0x00007fffe9452bc1 in vtkObject::UnRegisterInternal (this=0x555557f68ca0, o=0x0, check=0) at /home/local/KHQ/john.tourtellott/projects/cmb-master/build/cmb-superbuild/superbuild/paraview/src/VTK/Common/Core/vtkObject.cxx:926
#44 0x00007fffe94548fc in vtkObjectBase::UnRegister (this=0x555557f68ca0, o=0x0) at /home/local/KHQ/john.tourtellott/projects/cmb-master/build/cmb-superbuild/superbuild/paraview/src/VTK/Common/Core/vtkObjectBase.cxx:297
#45 0x00007fffe9454582 in vtkObjectBase::Delete (this=0x555557f68ca0) at /home/local/KHQ/john.tourtellott/projects/cmb-master/build/cmb-superbuild/superbuild/paraview/src/VTK/Common/Core/vtkObjectBase.cxx:236
#46 0x00007ffff41343f6 in vtkPVSessionCore::vtkInternals::~vtkInternals (this=0x555555dab400, __in_chrg=<optimized out>) at /home/local/KHQ/john.tourtellott/projects/cmb-master/build/cmb-superbuild/superbuild/paraview/src/Remoting/ServerManager/vtkPVSessionCore.cxx:112
#47 0x00007ffff412fe34 in vtkPVSessionCore::~vtkPVSessionCore (this=0x555555e23580, __in_chrg=<optimized out>) at /home/local/KHQ/john.tourtellott/projects/cmb-master/build/cmb-superbuild/superbuild/paraview/src/Remoting/ServerManager/vtkPVSessionCore.cxx:319
#48 0x00007ffff412feba in vtkPVSessionCore::~vtkPVSessionCore (this=0x555555e23580, __in_chrg=<optimized out>) at /home/local/KHQ/john.tourtellott/projects/cmb-master/build/cmb-superbuild/superbuild/paraview/src/Remoting/ServerManager/vtkPVSessionCore.cxx:323
#49 0x00007fffe9454a5f in vtkObjectBase::UnRegisterInternal (this=0x555555e23580, check=0) at /home/local/KHQ/john.tourtellott/projects/cmb-master/build/cmb-superbuild/superbuild/paraview/src/VTK/Common/Core/vtkObjectBase.cxx:342
#50 0x00007fffe9452bc1 in vtkObject::UnRegisterInternal (this=0x555555e23580, o=0x0, check=0) at /home/local/KHQ/john.tourtellott/projects/cmb-master/build/cmb-superbuild/superbuild/paraview/src/VTK/Common/Core/vtkObject.cxx:926
#51 0x00007fffe94548fc in vtkObjectBase::UnRegister (this=0x555555e23580, o=0x0) at /home/local/KHQ/john.tourtellott/projects/cmb-master/build/cmb-superbuild/superbuild/paraview/src/VTK/Common/Core/vtkObjectBase.cxx:297
#52 0x00007fffe9454582 in vtkObjectBase::Delete (this=0x555555e23580) at /home/local/KHQ/john.tourtellott/projects/cmb-master/build/cmb-superbuild/superbuild/paraview/src/VTK/Common/Core/vtkObjectBase.cxx:236
#53 0x00007ffff412dca5 in vtkPVSessionBase::~vtkPVSessionBase (this=0x555555e2d740, __in_chrg=<optimized out>) at /home/local/KHQ/john.tourtellott/projects/cmb-master/build/cmb-superbuild/superbuild/paraview/src/Remoting/ServerManager/vtkPVSessionBase.cxx:86
#54 0x00007ffff42a76bd in vtkSMSession::~vtkSMSession (this=0x555555e2d740, __in_chrg=<optimized out>) at /home/local/KHQ/john.tourtellott/projects/cmb-master/build/cmb-superbuild/superbuild/paraview/src/Remoting/ServerManager/vtkSMSession.cxx:93
#55 0x00007ffff42a76dc in vtkSMSession::~vtkSMSession (this=0x555555e2d740, __in_chrg=<optimized out>) at /home/local/KHQ/john.tourtellott/projects/cmb-master/build/cmb-superbuild/superbuild/paraview/src/Remoting/ServerManager/vtkSMSession.cxx:107
#56 0x00007fffe9454a5f in vtkObjectBase::UnRegisterInternal (this=0x555555e2d740, check=0) at /home/local/KHQ/john.tourtellott/projects/cmb-master/build/cmb-superbuild/superbuild/paraview/src/VTK/Common/Core/vtkObjectBase.cxx:342
#57 0x00007fffe9452bc1 in vtkObject::UnRegisterInternal (this=0x555555e2d740, o=0x0, check=0) at /home/local/KHQ/john.tourtellott/projects/cmb-master/build/cmb-superbuild/superbuild/paraview/src/VTK/Common/Core/vtkObject.cxx:926
#58 0x00007fffe94548fc in vtkObjectBase::UnRegister (this=0x555555e2d740, o=0x0) at /home/local/KHQ/john.tourtellott/projects/cmb-master/build/cmb-superbuild/superbuild/paraview/src/VTK/Common/Core/vtkObjectBase.cxx:297
#59 0x00007fffe9454582 in vtkObjectBase::Delete (this=0x555555e2d740) at /home/local/KHQ/john.tourtellott/projects/cmb-master/build/cmb-superbuild/superbuild/paraview/src/VTK/Common/Core/vtkObjectBase.cxx:236
#60 0x00007fffea457bd5 in vtkPythonObjectMap::remove (this=0x555555ca0880, key=0x555555e2d740) at /home/local/KHQ/john.tourtellott/projects/cmb-master/build/cmb-superbuild/superbuild/paraview/src/VTK/Wrapping/PythonCore/vtkPythonUtil.cxx:129
#61 0x00007fffea4583f6 in vtkPythonUtil::RemoveObjectFromMap (obj=0x7fffb4ec6160) at /home/local/KHQ/john.tourtellott/projects/cmb-master/build/cmb-superbuild/superbuild/paraview/src/VTK/Wrapping/PythonCore/vtkPythonUtil.cxx:339
#62 0x00007fffea4355ff in PyVTKObject_Delete (op=0x7fffb4ec6160) at /home/local/KHQ/john.tourtellott/projects/cmb-master/build/cmb-superbuild/superbuild/paraview/src/VTK/Wrapping/PythonCore/PyVTKObject.cxx:288
#63 0x00007fffea13e3fc in _Py_DECREF (op=<optimized out>) at /home/local/KHQ/john.tourtellott/projects/cmb-master/build/cmb-superbuild/superbuild/python3/src/Include/object.h:430
#64 _Py_XDECREF (op=<optimized out>) at /home/local/KHQ/john.tourtellott/projects/cmb-master/build/cmb-superbuild/superbuild/python3/src/Include/object.h:497
#65 dict_dealloc (mp=0x7fffb4e8fe40) at /home/local/KHQ/john.tourtellott/projects/cmb-master/build/cmb-superbuild/superbuild/python3/src/Objects/dictobject.c:2018
#66 0x00007fffea1674af in _Py_DECREF (op=<optimized out>) at /home/local/KHQ/john.tourtellott/projects/cmb-master/build/cmb-superbuild/superbuild/python3/src/Include/object.h:430
#67 subtype_dealloc (self=0x7fffb4ec55e0) at /home/local/KHQ/john.tourtellott/projects/cmb-master/build/cmb-superbuild/superbuild/python3/src/Objects/typeobject.c:1321
#68 0x00007fffea13d4cd in _Py_DECREF (op=<optimized out>) at /home/local/KHQ/john.tourtellott/projects/cmb-master/build/cmb-superbuild/superbuild/python3/src/Include/object.h:430
#69 _Py_XDECREF (op=<optimized out>) at /home/local/KHQ/john.tourtellott/projects/cmb-master/build/cmb-superbuild/superbuild/python3/src/Include/object.h:497
#70 free_keys_object (keys=0x55555b60bc80) at /home/local/KHQ/john.tourtellott/projects/cmb-master/build/cmb-superbuild/superbuild/python3/src/Objects/dictobject.c:598
#71 0x00007fffea1426dd in dict_tp_clear (op=<optimized out>) at /home/local/KHQ/john.tourtellott/projects/cmb-master/build/cmb-superbuild/superbuild/python3/src/Objects/dictobject.c:3158
#72 0x00007fffea258f0e in delete_garbage (gcstate=0x555555659de8, gcstate=0x555555659de8, old=0x555555659e30, collectable=0x7fffffffce70, tstate=0x5555555c29f0) at /home/local/KHQ/john.tourtellott/projects/cmb-master/build/cmb-superbuild/superbuild/python3/src/Modules/gcmodule.c:1004
#73 collect (tstate=0x5555555c29f0, generation=generation@entry=2, n_collected=n_collected@entry=0x0, n_uncollectable=n_uncollectable@entry=0x0, nofail=nofail@entry=1) at /home/local/KHQ/john.tourtellott/projects/cmb-master/build/cmb-superbuild/superbuild/python3/src/Modules/gcmodule.c:1273
#74 0x00007fffea259bd6 in _PyGC_CollectNoFail () at /home/local/KHQ/john.tourtellott/projects/cmb-master/build/cmb-superbuild/superbuild/python3/src/Modules/gcmodule.c:2109
#75 0x00007fffea21997c in _PyImport_Cleanup (tstate=tstate@entry=0x5555555c29f0) at /home/local/KHQ/john.tourtellott/projects/cmb-master/build/cmb-superbuild/superbuild/python3/src/Python/import.c:572
#76 0x00007fffea232188 in Py_FinalizeEx () at /home/local/KHQ/john.tourtellott/projects/cmb-master/build/cmb-superbuild/superbuild/python3/src/Python/pylifecycle.c:1426
#77 Py_FinalizeEx () at /home/local/KHQ/john.tourtellott/projects/cmb-master/build/cmb-superbuild/superbuild/python3/src/Python/pylifecycle.c:1345
#78 0x00007fffeea6cf05 in pybind11::finalize_interpreter () at /home/local/KHQ/john.tourtellott/projects/cmb-master/build/cmb-superbuild/install/include/pybind11/embed.h:250
#79 0x00007fffeea5c9b3 in smtk::common::PythonInterpreter::finalize (this=0x7fffef734ae0 <smtk::common::PythonInterpreter::m_instance>) at /home/local/KHQ/john.tourtellott/projects/cmb-master/git/smtk/smtk/common/PythonInterpreter.cxx:158
#80 0x00007fffeea5c65a in smtk::common::PythonInterpreter::~PythonInterpreter (this=0x7fffef734ae0 <smtk::common::PythonInterpreter::m_instance>, __in_chrg=<optimized out>) at /home/local/KHQ/john.tourtellott/projects/cmb-master/git/smtk/smtk/common/PythonInterpreter.cxx:84
#81 0x00007fffe73ccfde in __cxa_finalize (d=0x7fffef733640) at cxa_finalize.c:83
#82 0x00007fffee9acd07 in __do_global_dtors_aux () from /home/local/KHQ/john.tourtellott/projects/cmb-master/build/smtk/lib/libsmtkCore.so
#83 0x00007fffffffdc30 in ?? ()
#84 0x00007ffff7fe0f6b in _dl_fini () at dl-fini.c:138
Backtrace stopped: frame did not save the PC
(gdb) Quit
(gdb)
```
</details>https://gitlab.kitware.com/cmb/smtk/-/issues/476Refactor project-manager observer2022-05-09T10:12:46-04:00David ThompsonRefactor project-manager observerThe project-manager's [metadata observer](https://gitlab.kitware.com/cmb/smtk/-/blob/master/smtk/project/Manager.cxx#L68-90) needs to be refactored or eliminated since it forces the construction of every operation registered with the ope...The project-manager's [metadata observer](https://gitlab.kitware.com/cmb/smtk/-/blob/master/smtk/project/Manager.cxx#L68-90) needs to be refactored or eliminated since it forces the construction of every operation registered with the operation manager. Also, it is no longer needed after !2568 since all operations have access to the `smtk::common::Managers` instance registered with the operation Manager. Thus, any operation should have access to the project and resource managers.
FYI @john.tourtellott @bob.obarahttps://gitlab.kitware.com/cmb/smtk/-/issues/475Future work for the graph resource2022-05-06T19:45:03-04:00David ThompsonFuture work for the graph resourceHere is an umbrella issue collecting ideas for expanding/improving the `smtk::graph::Resource`.
### Runtime API and Python bindings
+ Create runtime, non-templated accessor objects for nodes and arcs
+ Use the runtime accessors to prov...Here is an umbrella issue collecting ideas for expanding/improving the `smtk::graph::Resource`.
### Runtime API and Python bindings
+ Create runtime, non-templated accessor objects for nodes and arcs
+ Use the runtime accessors to provide python bindings
+ Create a runtime, non-templated generic arc API
+ Use the API above to accept python-defined arc types.
### Operations
+ We have JSON bindings, but no read/write/create operations. Make some templated on a traits object?
+ Add a "lint" operation (or a free function?) to validate arcs, check that consistency rules hold.
+ Add some operations that perform graph analyses, such as
+ Node degree statistics
+ Graph cuts / partitioning that breaks fewest arcs.
+ Node centrality computation
### Presentation
+ Create a node class-hierarchy subphrase generator.
+ Create an arc-traversal subphrase generator.
+ Prototype a 2-D node+arc layout? (a la the ParaView node editor)
+ Prototype a 1-D node layout with arcs routed to the side.
+ For high-level overviews, is there a subset of visual "super nodes"
that should be rendered instead of showing all nodes+arcs?
### Selection
+ Investigate designs we might use for selecting nodes
(i.e., what should the footprint of a selection be so that
non-visual nodes can be selected by picking visual nodes?
Which of these are exclusive with other selections – in the
same way volumes and faces are exclusive in the model resource?).
### Query grammar
+ Investigate how to extend the query grammar to allow nodes to
be selected based on their connectivity to other nodes along
arcs of a given type.
+ Investigate efficient use of a boost multi-index container for
querying nodes based on things besides name, type-name, and id.
(For example: properties on nodes, property values, arcs.)
The issue is how to expose methods that ensure the index is
properly updated without lots of developer pain.
### Graph theory
+ Investigate methods to expose matrix ←→ graph duality for
mathematical analysis of graphs.
+ Investigate techniques for storing edge weights.
In order to be general:
+ A single edge may have multiple weights in different contexts.
+ Maybe provide an API to get an integer for any pair of connected nodes?
Then as many fields as you want could be stored as a map.
Might also provide an API to "squeeze" assigned IDs into a
contiguous range so fields could be represented as vectors?
This seems like a good use of SMTK's query+cache mechanism,
with the cache being invalidated (or at least marked dirty)
after operations with write locks.https://gitlab.kitware.com/cmb/smtk/-/issues/470Build Error: jsonResource.cxx/Filter.h with gcc 9.3.1 on RHEL2022-04-14T03:29:20-04:00Nate deVelderBuild Error: jsonResource.cxx/Filter.h with gcc 9.3.1 on RHELHi, I'm getting a build error on RHEL using devtoolset-9 (gcc 9.3.1), has anyone seen this before, or have any suggestions for how to get past? Looks like the offending code is in Filter.h? Thanks for your help!
`
[ 21%] Building CXX ...Hi, I'm getting a build error on RHEL using devtoolset-9 (gcc 9.3.1), has anyone seen this before, or have any suggestions for how to get past? Looks like the offending code is in Filter.h? Thanks for your help!
`
[ 21%] Building CXX object smtk/CMakeFiles/smtkCore.dir/resource/json/jsonResource.cxx.o
cd /projects/wind/cmb/spack-manager/environments/cmb/smtk/spack-build-2twfesa/smtk && /projects/wind/cmb/spack-manager/spack/lib/spack/env/gcc/g++ -DJSON_DIAGNOSTICS=0 -DJSON_USE_IMPLICIT_CONVERSIONS=1 -DsmtkCor
e_EXPORTS -I/projects/wind/cmb/spack-manager/environments/cmb/smtk/spack-build-2twfesa -I/projects/wind/cmb/spack-manager/environments/cmb/smtk -isystem /projects/wind/cmb/spack-manager/environments/cmb/smtk/thi
rdparty -isystem /projects/wind/cmb/spack-manager/environments/cmb/smtk/spack-build-2twfesa/thirdparty -isystem /projects/wind/cmb/spack-manager/environments/cmb/smtk/thirdparty/pugixml -isystem /projects/wind/c
mb/spack-manager/spack/opt/spack/linux-rhel7-cascadelake/gcc-9.3.1/boost-1.68.0-vjg3t6ot4abb62qmptdq4gznyatdxrsp/include -isystem /projects/wind/cmb/spack-manager/spack/opt/spack/linux-rhel7-cascadelake/gcc-9.3.
1/nlohmann-json-3.10.5-3awswsju5y6wgyi4inzlj6sgozfq2d5l/include -isystem /projects/wind/cmb/spack-manager/spack/opt/spack/linux-rhel7-cascadelake/gcc-9.3.1/pegtl-3.2.0-swl7zr7nupdwemg2tjk4ia3f7tnmc7e7/include -i
system /projects/wind/cmb/spack-manager/spack/opt/spack/linux-rhel7-cascadelake/gcc-9.3.1/libarchive-3.5.2-43aevbzgantl6nswkotmfjrmp2rfw2gy/include -fpermissive -O3 -DNDEBUG -fPIC -fvisibility=hidden -std=c++17
-MD -MT smtk/CMakeFiles/smtkCore.dir/resource/json/jsonResource.cxx.o -MF CMakeFiles/smtkCore.dir/resource/json/jsonResource.cxx.o.d -o CMakeFiles/smtkCore.dir/resource/json/jsonResource.cxx.o -c /projects/wind/
cmb/spack-manager/environments/cmb/smtk/smtk/resource/json/jsonResource.cxx
In file included from /projects/wind/cmb/spack-manager/environments/cmb/smtk/smtk/resource/Resource.cxx:18:
/projects/wind/cmb/spack-manager/environments/cmb/smtk/smtk/resource/filter/Filter.h: In member function 'smtk::resource::filter::Rules smtk::resource::filter::Filter<GrammarType>::constructRules(const string&)'
:
/projects/wind/cmb/spack-manager/environments/cmb/smtk/smtk/resource/filter/Filter.h:96:26: error: invalid use of member function 'const std::vector<tao::pegtl::position>& tao::pegtl::parse_error::positions() co
nst' (did you forget the '()' ?)
96 | const auto p = err.positions.front();
| ~~~~^~~~~~~~~
| ()
In file included from /projects/wind/cmb/spack-manager/environments/cmb/smtk/smtk/resource/filter/Filter.h:15,
from /projects/wind/cmb/spack-manager/environments/cmb/smtk/smtk/resource/Resource.cxx:18:
/projects/wind/cmb/spack-manager/environments/cmb/smtk/smtk/resource/filter/Filter.h:100:50: error: 'struct tao::pegtl::string_input<>' has no member named 'line_as_string'
100 | << in.line_as_string(p) << "\n"
| ^~~~~~~~~~~~~~
/projects/wind/cmb/spack-manager/environments/cmb/smtk/smtk/io/Logger.h:41:11: note: in definition of macro 'smtkErrorMacro'
41 | s1 << x; /* NOLINT(bugprone-macro-parentheses) */ \
| ^
`David ThompsonDavid Thompsonhttps://gitlab.kitware.com/cmb/smtk/-/issues/466Investigate failure associated with fedora33-tidy:build2022-03-05T07:45:47-05:00Jean-Christophe Fillion-RobinInvestigate failure associated with fedora33-tidy:build
## Observation
Starting with the integration of https://gitlab.kitware.com/cmb/smtk/-/merge_requests/2666 into `master`, and also within https://gitlab.kitware.com/cmb/smtk/-/merge_requests/2665, the [fedora33-tidy:build](https://gitla...
## Observation
Starting with the integration of https://gitlab.kitware.com/cmb/smtk/-/merge_requests/2666 into `master`, and also within https://gitlab.kitware.com/cmb/smtk/-/merge_requests/2665, the [fedora33-tidy:build](https://gitlab.kitware.com/jcfr/smtk/-/jobs/6655752) error seems unrelated and is associated with the file [thirdparty/delaunay/Source/Mesh/Mesh.hh](https://github.com/tjcorona/Delaunay/blob/e3349b472af009172ce300fe9d1a36f50704078a/Source/Mesh/Mesh.hh).
## Notes
Worth noting that smtk does not build against the latest version, see history of `Mesh.hh` [here](https://github.com/tjcorona/Delaunay/commits/master/Source/Mesh/Mesh.hh) and overall history of the project [here](https://github.com/tjcorona/Delaunay)
## Questions
Should it be fixed ?
It may be worth investigatin and why did the CI started to fail without having any update to files [.gitlab](https://gitlab.kitware.com/cmb/smtk/-/commits/master/.gitlab)?
## Error
```
/builds/gitlab-kitware-sciviz-ci/thirdparty/delaunay/Source/Mesh/Mesh.hh:47:11: warning: use '= default' to define a trivial destructor [modernize-use-equals-default]
virtual ~Mesh() {}
^ ~~
= default;
/builds/gitlab-kitware-sciviz-ci/thirdparty/delaunay/Source/Mesh/Vertex.hh:39:11: warning: use '= default' to define a trivial destructor [modernize-use-equals-default]
virtual ~Vertex() {}
^ ~~
= default;
/builds/gitlab-kitware-sciviz-ci/thirdparty/delaunay/Source/Shape/Polygon.hh:42:3: warning: use '= default' to define a trivial destructor [modernize-use-equals-default]
~Polygon() {}
^ ~~
= default;
/builds/gitlab-kitware-sciviz-ci/thirdparty/delaunay/Source/Shape/Triangle.hh:37:3: warning: use '= default' to define a trivial destructor [modernize-use-equals-default]
~Triangle() {}
^ ~~
= default;
```https://gitlab.kitware.com/cmb/smtk/-/issues/464Unserializable properties should be accepted.2022-01-28T00:15:23-05:00David ThompsonUnserializable properties should be accepted.Our experience with adding a CoordinateFrame property has revealed that when a type without `from_json`/`to_json` functions is registered with the Resource's tuple of properties, compilation fails. However, the design intent was always t...Our experience with adding a CoordinateFrame property has revealed that when a type without `from_json`/`to_json` functions is registered with the Resource's tuple of properties, compilation fails. However, the design intent was always to allow properties to omit serialization if desired.
+ [ ] Fix `Properties.{h,cxx}` to accept properties without serializers.
+ [ ] Add a test.https://gitlab.kitware.com/cmb/smtk/-/issues/463QTreeView performance problems with descriptive phrases2022-01-26T11:46:59-05:00David ThompsonQTreeView performance problems with descriptive phrases+ Some badges are slow to determine applicability and they are being asked to update even when the badge is not visible. Is there a QTreeView change we can make (in tandem with `setUniformRowHeight()`) to avoid recomputes for rows not dr...+ Some badges are slow to determine applicability and they are being asked to update even when the badge is not visible. Is there a QTreeView change we can make (in tandem with `setUniformRowHeight()`) to avoid recomputes for rows not drawn?
+ The badge SVG is slow because of the `regex_replace` to deal with the secondary color; can we use QPainter to handle icon geometry?https://gitlab.kitware.com/cmb/smtk/-/issues/462Improve performance of ComponentPhraseModel2022-01-26T11:34:44-05:00David ThompsonImprove performance of ComponentPhraseModelThe `handleCreated()` method currently recomputes the set of components in the root view regardless of whether it needs to. This is causing performance problems with large models.The `handleCreated()` method currently recomputes the set of components in the root view regardless of whether it needs to. This is causing performance problems with large models.David ThompsonDavid Thompsonhttps://gitlab.kitware.com/cmb/smtk/-/issues/459Camera reset when loading resources without geometry2022-01-28T00:03:43-05:00David ThompsonCamera reset when loading resources without geometryDavid ThompsonDavid Thompsonhttps://gitlab.kitware.com/cmb/smtk/-/issues/458Disconnect builtin server messes up modelbuilder2022-01-07T08:54:59-05:00John TourtellottDisconnect builtin server messes up modelbuilderWe used to be able to disconnect the builtin server in order to completely reset modelbuilder. With the current modelbuilder, however, this puts modelbuilder in a strange state that is not usable. To reproduce:
1. Start modelbuilder
2. ...We used to be able to disconnect the builtin server in order to completely reset modelbuilder. With the current modelbuilder, however, this puts modelbuilder in a strange state that is not usable. To reproduce:
1. Start modelbuilder
2. Click the "Disconnect" toolbar button
3. Load an smtk resource, e.g., `smtk/data/models/2d/smtk/epik-trex-drummer.smtk` or create one using "File" => "New Resource".
4. In either case, the model is displayed in the render view but does NOT appear in the resource panel;
5. Also "File" => "Close Resource" does not do anything, but that shouldn't be a surprise.https://gitlab.kitware.com/cmb/smtk/-/issues/454Fix cloning from GitHub mirror when git lfs is enabled locally2021-12-27T17:41:47-05:00Jean-Christophe Fillion-RobinFix cloning from GitHub mirror when git lfs is enabled locally
Running the command
```
git clone https://github.com/Kitware/SMTK
```
leads error like the following
```
Cloning into 'SMTK'...
[...]
Downloading data/attribute/attribute_collection/Basic2DFluid.sbt (1.25 KB)
Error downloading object...
Running the command
```
git clone https://github.com/Kitware/SMTK
```
leads error like the following
```
Cloning into 'SMTK'...
[...]
Downloading data/attribute/attribute_collection/Basic2DFluid.sbt (1.25 KB)
Error downloading object: data/attribute/attribute_collection/Basic2DFluid.sbt (c75d88f): Smudge error: Error downloading data/attribute/attribute_collection/Basic2DFluid.sbt (c75d88f5e5996a8d99460fab042fcfdff8ba36f473b900dff5ea2312572d346b): [c75d88f5e5996a8d99460fab042fcfdff8ba36f473b900dff5ea2312572d346b] Object does not exist on the server: [404] Object does not exist on the server
[..]
```
when cloning on a developer workstation with git-lfs enabled:
```
$ git config --global --get-regexp "filter"
filter.lfs.process git-lfs filter-process
filter.lfs.required true
filter.lfs.clean git-lfs clean -- %f
filter.lfs.smudge git-lfs smudge -- %f
```https://gitlab.kitware.com/cmb/smtk/-/issues/453Failing build in Filter.h2022-04-13T11:29:08-04:00Mathieu Westphal (Kitware)Failing build in Filter.hBuild smtk with default cmake conf on ArchLinux fails with:
```
In file included from /home/glow/work/smtk/smtk/resource/Resource.cxx:18:
/home/glow/work/smtk/smtk/resource/filter/Filter.h: In member function `smtk::resource::filter::Ru...Build smtk with default cmake conf on ArchLinux fails with:
```
In file included from /home/glow/work/smtk/smtk/resource/Resource.cxx:18:
/home/glow/work/smtk/smtk/resource/filter/Filter.h: In member function `smtk::resource::filter::Rules smtk::resource::filter::Filter<GrammarType>::constructRules(const string&)':
/home/glow/work/smtk/smtk/resource/filter/Filter.h:96:26: error: invalid use of member function `const std::vector<tao::pegtl::position>& tao::pegtl::parse_error::positions() const' (did you forget the `()' ?)
96 | const auto p = err.positions.front();
| ~~~~^~~~~~~~~
|
```David ThompsonDavid Thompson