SMTK issueshttps://gitlab.kitware.com/cmb/smtk/-/issues2018-04-11T01:59:24-04:00https://gitlab.kitware.com/cmb/smtk/-/issues/118Need to add reset camera and better panning for mac 2 button mouse to Grab Cuts2018-04-11T01:59:24-04:00Robert M. O'BaraNeed to add reset camera and better panning for mac 2 button mouse to Grab CutsSMTK 1.1Jacob BeckerJacob Beckerhttps://gitlab.kitware.com/cmb/smtk/-/issues/113Need to Improve edge processing2018-04-11T01:59:24-04:00Robert M. O'BaraNeed to Improve edge processingWhen creating a model from the New River dem (extracting contours with value 0.01 and min length of 1000) the resulting polyline contains non-manifold features - basically the input edge should result in multiple model edges. Here is an...When creating a model from the New River dem (extracting contours with value 0.01 and min length of 1000) the resulting polyline contains non-manifold features - basically the input edge should result in multiple model edges. Here is an example of the problem.
[dec_1.smtk](/uploads/e4a91442df4c770598550d582f66916f/dec_1.smtk)SMTK 2.0David ThompsonDavid Thompsonhttps://gitlab.kitware.com/cmb/smtk/-/issues/111Strange Sorting Order in Entity List View2018-11-23T09:57:51-05:00Robert M. O'BaraStrange Sorting Order in Entity List ViewThe group order should either be Volumes, Faces, Edges, Vertices, Aux Geometry, Properties or Vertices, Edges, Faces, Volumes, Aux Geometry, PropertiesThe group order should either be Volumes, Faces, Edges, Vertices, Aux Geometry, Properties or Vertices, Edges, Faces, Volumes, Aux Geometry, PropertiesSMTK 1.1David ThompsonDavid Thompsonhttps://gitlab.kitware.com/cmb/smtk/-/issues/107Point Selection still highlighted2018-04-11T01:59:25-04:00Robert M. O'BaraPoint Selection still highlightedWhen an edge point is highlighted in a split operator - it remains highlighted when leaving the operationWhen an edge point is highlighted in a split operator - it remains highlighted when leaving the operationSMTK 1.1Yumin YuanYumin Yuanhttps://gitlab.kitware.com/cmb/smtk/-/issues/104After the contours from dem operator runs, user has difficulty selecting image2018-04-11T01:59:25-04:00Robert M. O'BaraAfter the contours from dem operator runs, user has difficulty selecting imageTry the following:
1. Load in DEM
2. Extract Contours
3. Try to make the image transparent - you will see that the selecting the image in the tree view does not have any effectTry the following:
1. Load in DEM
2. Extract Contours
3. Try to make the image transparent - you will see that the selecting the image in the tree view does not have any effectYumin YuanYumin Yuanhttps://gitlab.kitware.com/cmb/smtk/-/issues/77Select multiple points to promote/demote to/from hard nodes2018-04-11T01:59:25-04:00Amanda HinesSelect multiple points to promote/demote to/from hard nodesCurrently you can only promote/demote one point at a time by hovering over it and holding a button and clicking. We need a way to select a group of points and have the option of toggling their vertex/hard node status or set them all as h...Currently you can only promote/demote one point at a time by hovering over it and holding a button and clicking. We need a way to select a group of points and have the option of toggling their vertex/hard node status or set them all as hard nodes (do nothing for a point if it is already a hard node).Robert M. O'BaraRobert M. O'Barahttps://gitlab.kitware.com/cmb/smtk/-/issues/53Ability to draw edges that connect to existing model vertices2018-04-11T01:59:25-04:00Robert M. O'BaraAbility to draw edges that connect to existing model verticesWhen interactively creating an edge you should be able start and or stop at model vertices (this doesn't mean being able to select a point that is in the middle of edge - this might be added later).When interactively creating an edge you should be able start and or stop at model vertices (this doesn't mean being able to select a point that is in the middle of edge - this might be added later).Yumin YuanYumin Yuanhttps://gitlab.kitware.com/cmb/smtk/-/issues/51Operators should be accessible via a menu item2018-04-11T01:59:25-04:00Robert M. O'BaraOperators should be accessible via a menu itemIn this case the Save Model operator in Polygon Session should be accessible via the File menuIn this case the Save Model operator in Polygon Session should be accessible via the File menuYumin YuanYumin Yuanhttps://gitlab.kitware.com/cmb/smtk/-/issues/4Adding Modification Tracking to Attribute System2018-04-11T01:59:25-04:00Robert M. O'BaraAdding Modification Tracking to Attribute SystemNeeds to know when the attribute system needs to be savedNeeds to know when the attribute system needs to be savedRobert M. O'BaraRobert M. O'Barahttps://gitlab.kitware.com/cmb/smtk/-/issues/3Add Modification Tracking to Model2018-04-11T01:59:25-04:00Robert M. O'BaraAdd Modification Tracking to ModelNeed to know when a model needs to be saved.Need to know when a model needs to be saved.Yumin YuanYumin Yuanhttps://gitlab.kitware.com/cmb/smtk/-/issues/498Need method for acquiring Resource locks2022-09-15T01:15:17-04:00David ThompsonNeed method for acquiring Resource locksWe need a method for things other than operations to acquire locks on resources.We need a method for things other than operations to acquire locks on resources.David ThompsonDavid Thompsonhttps://gitlab.kitware.com/cmb/smtk/-/issues/527ci: tidy timing out2024-01-25T11:02:17-05:00Ben Boeckelci: tidy timing outJob [#9235260](https://gitlab.kitware.com/cmb/smtk/-/jobs/9235260) failed for da82b89018d5506d384270008c4adc0f6042cfdf:
We're nearing the timeout; we should look into `clang-tidy-cache`.
Cc: @dcthompJob [#9235260](https://gitlab.kitware.com/cmb/smtk/-/jobs/9235260) failed for da82b89018d5506d384270008c4adc0f6042cfdf:
We're nearing the timeout; we should look into `clang-tidy-cache`.
Cc: @dcthomphttps://gitlab.kitware.com/cmb/smtk/-/issues/524updateWorklet observer causes operations to crash modelbuilder.2024-01-19T14:43:16-05:00Jason LuckhardtupdateWorklet observer causes operations to crash modelbuilder.Repro Steps:
1. Create an operation with a resource result.
2. Run the operation, but don't return a resource.
3. Modelbuilder will crash.
Example Operation Result
```xml
<!-- Result -->
<include href="smtk/operation/Res...Repro Steps:
1. Create an operation with a resource result.
2. Run the operation, but don't return a resource.
3. Modelbuilder will crash.
Example Operation Result
```xml
<!-- Result -->
<include href="smtk/operation/Result.xml"/>
<AttDef Type="result(OperationTest)" BaseType="result">
<ItemDefinitions>
<Resource Name="resource" NumberOfRequiredValues="1" Extensible="true" Optional="true">
<Accepts>
<Resource Name="DummyResource"/>
</Accepts>
</Resource>
</ItemDefinitions>
</AttDef>
```
I believe a check should be added here:
![image](/uploads/101e2f3b747aa064ccb93dc48cef9df8/image.png)
Either to see if the result resource item is optional and is enabled or if the item is empty.
Any feedback is greatly appreciated thanks!https://gitlab.kitware.com/cmb/smtk/-/issues/522Enable matplotlib plugin again2023-11-27T12:53:38-05:00Ben BoeckelEnable matplotlib plugin againIt currently uses the removed (23.01) CMake API `smtk_pyoperation_xml` and needs updated.
Cc: @dcthompIt currently uses the removed (23.01) CMake API `smtk_pyoperation_xml` and needs updated.
Cc: @dcthomphttps://gitlab.kitware.com/cmb/smtk/-/issues/521Phrase models do not clean up properly upon unloading a project2023-11-17T14:28:34-05:00jwilson1881Phrase models do not clean up properly upon unloading a projectWhen a project is removed using smtk::operation::RemoveResource, smtk::operation::Operation::operate will call smtk::resource::Manager::remove on each of the project's owned resources which trigger observers from the resource manager, bu...When a project is removed using smtk::operation::RemoveResource, smtk::operation::Operation::operate will call smtk::resource::Manager::remove on each of the project's owned resources which trigger observers from the resource manager, but phrase models do not process resource manager events by default. This causes phrases to be left over in any view after the project has been unloaded.
smtk::view::PhraseModel should probably provide a default implementation of its handleResourceEvent method to cover this scenario when the project alone is being removed from the project manager by an operation.https://gitlab.kitware.com/cmb/smtk/-/issues/519FillOutAttributes Incorrect Task State2023-10-17T20:00:04-04:00John TourtellottFillOutAttributes Incorrect Task StateI have reproduced some incorrect/unexpected task system behavior reported by an outside user: a FillOutAttributes task is being set to the completable state when its dependency task is marked completed.
## 1. Load Test Project
To repro...I have reproduced some incorrect/unexpected task system behavior reported by an outside user: a FillOutAttributes task is being set to the completable state when its dependency task is marked completed.
## 1. Load Test Project
To reproduce the issue, first load this project into modelbuilder: [task-dependency.tgz](/uploads/28f1e46773ce5a5bea5c076b15fd4b02/task-dependency.tgz)
As shown in the first screenshot, the project has 3 tasks
1. Plain Task -- an `smtk::task::Task` instance. Its initial task state is `completable`.
2. Assign Attribute Resource -- an `smtk::task::GatherResources` instance that is used to connect the project's attribute resource to the third task. Its initial task state is `completable`.
3. Edit Attributes -- an `smtk::task::FillOutAttributes` instance for editing an "Elasticity" attribute in the project's attribute resource. Its initial state is `unavailable` because (i) its attribute resource has not been set via the Assign Attribute Resource task and (ii) there is a strict dependency on the Plain Task which is not completed.
![task-dependency-initial](/uploads/9868367146dc3e5fcaefc5955a5dd291/task-dependency-initial.png){width=75%}
## 2. Reproduce Incorrect Behavior.
In the Tasks View:
1. Change the "Assign Attribute Resource" task to the `completed` state.
2. Change the "Plain Task" to the `completed` state.
3. Note that the "Edit Attributes" task has changed to the `completable` state.
4. In the "Edit Attributes" controls, select `Work on this` to update the Attribute Editor.
5. Note that there is an invalid entry (Young's Modulus) in the attribute editor, which is inconsistent with the `completable` task state. The expected behavior is for the task to be `incomplete` when its attribute(s) is/are invalid.
![task-dependency-incorrect](/uploads/7dd26e93b37340aaaaa1589329bfc44b/task-dependency-incorrect.png){width=75%}Robert M. O'BaraRobert M. O'Barahttps://gitlab.kitware.com/cmb/smtk/-/issues/516Generate Cobertura coverage reports2023-07-30T21:25:37-04:00Ben BoeckelGenerate Cobertura coverage reportsSupported in [GitLab](https://docs.gitlab.com/ee/ci/yaml/artifacts_reports.html#artifactsreportscoverage_report). This will allow GitLab to render lines in the MR diff as "not being covered".
Best to use [`gcovr`](https://gcovr.com/en/s...Supported in [GitLab](https://docs.gitlab.com/ee/ci/yaml/artifacts_reports.html#artifactsreportscoverage_report). This will allow GitLab to render lines in the MR diff as "not being covered".
Best to use [`gcovr`](https://gcovr.com/en/stable/index.html).
Cc: @dcthomp @bob.obarahttps://gitlab.kitware.com/cmb/smtk/-/issues/515Investigate TestTaskGroup Issue2023-07-07T16:32:41-04:00Robert M. O'BaraInvestigate TestTaskGroup IssueCauses a failure on LinuxCauses a failure on LinuxAron HelserAron Helserhttps://gitlab.kitware.com/cmb/smtk/-/issues/512Error deserializing smtk::task::Group2023-05-30T10:49:39-04:00John TourtellottError deserializing smtk::task::GroupI don't think that children of group tasks are being deserialized. To reproduce:
* Start modelbuilder
* Load the `smtkWindTunnelPlugin`
* Load the `windtunnel-task-v0.1` project with this modified [project.smtk](/uploads/5de663b0f9228d7...I don't think that children of group tasks are being deserialized. To reproduce:
* Start modelbuilder
* Load the `smtkWindTunnelPlugin`
* Load the `windtunnel-task-v0.1` project with this modified [project.smtk](/uploads/5de663b0f9228d756ad3bac3ced3080d/project.smtk) file.
* In the console, look for the error message "ERROR: In /home/local/KHQ/john.tourtellott/projects/cmb-master/git/smtk/smtk/task/json/jsonManager.cxx, line 125: Could not deserialize: [json.exception.type_error.304] cannot use at() with array." (line number is different because I have some printf statements.)
Some details:
* The underlying cause arises in `smtk::task::Group::configure()`. Line 70 of `Group.cxx` calls `smtk::task::from_json()` passing in the "children" of the group's `Configuration` object. The "children" instance is a json _array_ object and the `smtk::task::from_json()` is expecting a json _object_ to be passed in.
* I'm not sure what the corrected logic should be. Maybe pass in the the `Configuration` object (is it a json object?) and rename "children" ==> "tasks"???David ThompsonDavid Thompsonhttps://gitlab.kitware.com/cmb/smtk/-/issues/510Wind Tunnel contract test not running2023-04-18T12:11:41-04:00John TourtellottWind Tunnel contract test not runningThe wind tunnel contract test has the wrong URL and is not testing anything now.
* The correct diff is pasted below.
* Once corrected, however, the contract test will fail because some wind tunnel tests need to initialize `smtk::common:...The wind tunnel contract test has the wrong URL and is not testing anything now.
* The correct diff is pasted below.
* Once corrected, however, the contract test will fail because some wind tunnel tests need to initialize `smtk::common::Managers` (changed by !2865).
```
diff --git a/.gitlab/ci/configure_fedora33_paraview.cmake b/.gitlab/ci/configure_fedora33_paraview.cmake
index a09043cad..be2a8186f 100644
--- a/.gitlab/ci/configure_fedora33_paraview.cmake
+++ b/.gitlab/ci/configure_fedora33_paraview.cmake
@@ -1,5 +1,5 @@
set(SMTK_PLUGIN_CONTRACT_FILE_URLS
- "https://gitlab.kitware.com/cmb/plugins/openfoam-windtunnel/-/raw/master/cmake/openfoam-windtunnel.cmake"
+ "https://gitlab.kitware.com/cmb/plugins/openfoam-windtunnel/-/raw/master/cmake/windtunnel-smtk-contract.cmake"
"https://gitlab.kitware.com/cmb/plugins/opencascade-session/-/raw/master/cmake/opencascade-smtk-contract.cmake"
"https://gitlab.kitware.com/cmb/plugins/adh-extensions/-/raw/master/CMake/adh-extensions.cmake"
"https://gitlab.kitware.com/cmb/plugins/rgg-session/-/raw/master/CMake/rgg-session.cmake"
```John TourtellottJohn Tourtellott