CMB issueshttps://gitlab.kitware.com/cmb/cmb/-/issues2017-05-22T14:20:27-04:00https://gitlab.kitware.com/cmb/cmb/-/issues/148Clear the logic in qtBaseView::showAdvancedLevel()2017-05-22T14:20:27-04:00Haocheng LIUClear the logic in qtBaseView::showAdvancedLevel()When working on `split edge` operator, I found out that `pqSplitEdgeWidget` is constructed and destructed multiple times when initializing the qtBaseView which actually is a waste. We should rebuild UI when switching to advance level is ...When working on `split edge` operator, I found out that `pqSplitEdgeWidget` is constructed and destructed multiple times when initializing the qtBaseView which actually is a waste. We should rebuild UI when switching to advance level is actually doing something.Haocheng LIUHaocheng LIUhttps://gitlab.kitware.com/cmb/cmb/-/issues/145Selection color is not shown when entities have assigned colors2017-05-15T11:47:03-04:00Haocheng LIUSelection color is not shown when entities have assigned colorsFor now, if we load a model in, we can see the **selection color** when no entity color has been assigned. After assigning colors to entities, we can no longer see the **selection color**.
It's because PV's logic is that which comes ...For now, if we load a model in, we can see the **selection color** when no entity color has been assigned. After assigning colors to entities, we can no longer see the **selection color**.
It's because PV's logic is that which comes last would be shown on the top in 2D mode. In the first case, **selection color** is the last joiner. Then after assign color operation, **entity color** is the last joiner. In 3D mode, you would see Z fighting.
Solution:
Since we have two geometryRepresentations as one for the model and another one for the selection, we would turn the block visibility of the selected entities' to be off then only show their selection representation. In this way, we avoid the above problem.4.1Haocheng LIUHaocheng LIUhttps://gitlab.kitware.com/cmb/cmb/-/issues/144Mesh tab output message2017-05-15T13:12:56-04:00Amanda HinesMesh tab output message5/9/17 Widows installer
When first clicking on the mesh tab, I get the output message below. It doesn't seem to cause any issues.![Mesh_tab_output](/uploads/54ae37035203266defc2ac05b190bf37/Mesh_tab_output.jpg)5/9/17 Widows installer
When first clicking on the mesh tab, I get the output message below. It doesn't seem to cause any issues.![Mesh_tab_output](/uploads/54ae37035203266defc2ac05b190bf37/Mesh_tab_output.jpg)4.1Haocheng LIUHaocheng LIUhttps://gitlab.kitware.com/cmb/cmb/-/issues/142Fix test failures caused by active model2017-05-01T09:21:53-04:00Haocheng LIUFix test failures caused by active model* [x] ModelBuilderOperationDomainGroup2D
* [x] ModelBuilderSelectObjectByBox* [x] ModelBuilderOperationDomainGroup2D
* [x] ModelBuilderSelectObjectByBoxHaocheng LIUHaocheng LIUhttps://gitlab.kitware.com/cmb/cmb/-/issues/140Adding concept of an active model implementation details2017-04-25T12:57:01-04:00Haocheng LIUAdding concept of an active model implementation details[related wiki page](https://gitlab.kitware.com/cmb/cmb/wikis/adding-concept-of-an-active-model)
# Active Model
* [x] store as `smtk::model::Model` in **smtk/extension/qt/qtActiveObjects**.
* [x] Changing current active model ...[related wiki page](https://gitlab.kitware.com/cmb/cmb/wikis/adding-concept-of-an-active-model)
# Active Model
* [x] store as `smtk::model::Model` in **smtk/extension/qt/qtActiveObjects**.
* [x] Changing current active model should always use function `setActiveModel` in **qtActiveObjects** which would clear all current selections.
* [x] Model level operation
- [x] Creating a new model - the new model would automatically become the Active Model
- [x] Loading in an existing model - in this case the loaded model would become the new Active Model
- [x] Closing the Active Model would make one of the existing models active (pqCMBModelManager)
- [x] Clear Data
* [ ] Model tree
- [x] **TBD:** Only the Active Model will have its model components displayed in the model tree and can have their properties changed
- [x] **TBD:** How to switch active model
- [x] active model is bolded
- [x] nonactive model is not expandable
- [ ] edit nonactive model visibility
* [x] Selection Manager
- [x] Only the Active Model can have its model entity components selected
- [x] Selection manager resets selection whenever the active model changes.
* [x] UI Manager & Attributes
- [x] **TBD:** The UI Manager need to be told there is an Active Model
- [x] This will prevent attributes from being assigned to non-active components(User case needed)
- [x] Only the Active Model can have attributes associated with it
- [x] switching active model would refresh the available list.
- [x] selecting nonactive-model entities should not be broadcast by qtSelectionManager.
- [x] show model name in currentList
- [x] Operation manager
- [x] The Operation Manager (dock widget) needs to be told there is an Active Model to display only the operations that can be applied to it and its components.(What's this?)4.1Haocheng LIUHaocheng LIUhttps://gitlab.kitware.com/cmb/cmb/-/issues/138selected edges should only render in the highlighted color2018-08-09T14:03:40-04:00T.J. Coronaselected edges should only render in the highlighted colorWhen an edge is selected, it is drawn in both the original color and the highlighted color. This causes z-fighting issues. The edge should only be drawn with the highlighted color.When an edge is selected, it is drawn in both the original color and the highlighted color. This causes z-fighting issues. The edge should only be drawn with the highlighted color.https://gitlab.kitware.com/cmb/cmb/-/issues/136CMB is not showing color properly2017-04-10T13:11:18-04:00Haocheng LIUCMB is not showing color properlyHere is the step to reproduce the bug:
* Open ModelBuilder, load test2d.cmb.
* use `assign colors` operator to assign color to **4 faces** list.
* switch `Color By` to Entity.
**first bug:** selection would not highlight correspond...Here is the step to reproduce the bug:
* Open ModelBuilder, load test2d.cmb.
* use `assign colors` operator to assign color to **4 faces** list.
* switch `Color By` to Entity.
**first bug:** selection would not highlight corresponding face in the render window. And I am pretty sure the selection is passed into selectionMgr. My guess is that we highlight selection first then draw entity by color which would override it.
* switch `Color By` to None.
**second bug:** selection would still not be highlight in render view and we have a wrongly colored face:
![Screenshot_from_2017-04-05_13-51-01](/uploads/f89b7216248945d7f315a47da79beb33/Screenshot_from_2017-04-05_13-51-01.png)
cc @dcthomp @bob.obarahttps://gitlab.kitware.com/cmb/cmb/-/issues/135Crash when applying bathymetry.2017-04-05T14:07:39-04:00Alvaro SanchezCrash when applying bathymetry.1. Open 2d/cmb/ChesapeakeBayContour.cmb.
2. Right click on the model entity and click on 'Model - Add Image'.
3. Select scene/ChesapeakeBay/ChesapeakeBay100x100.vti and Apply.
4. Right click on the model entity and click on 'apply bathy...1. Open 2d/cmb/ChesapeakeBayContour.cmb.
2. Right click on the model entity and click on 'Model - Add Image'.
3. Select scene/ChesapeakeBay/ChesapeakeBay100x100.vti and Apply.
4. Right click on the model entity and click on 'apply bathymetry'.
5. Select 'auxiliary geometry' (expanding the combo-box causes a crash).4.1https://gitlab.kitware.com/cmb/cmb/-/issues/134PointsBuilder Produces QT Signal Warnings when editing points2017-03-27T08:56:08-04:00Robert M. O'BaraPointsBuilder Produces QT Signal Warnings when editing points![Screen_Shot_2017-03-24_at_11.10.37_AMEDT](/uploads/1a820b319a174343c83e8b13eb81a816/Screen_Shot_2017-03-24_at_11.10.37_AMEDT.png)
To produce this
* Load in a Points File
* Select the Edit Tab
* Try to create a new contour![Screen_Shot_2017-03-24_at_11.10.37_AMEDT](/uploads/1a820b319a174343c83e8b13eb81a816/Screen_Shot_2017-03-24_at_11.10.37_AMEDT.png)
To produce this
* Load in a Points File
* Select the Edit Tab
* Try to create a new contour4.1Haocheng LIUHaocheng LIUhttps://gitlab.kitware.com/cmb/cmb/-/issues/133Load a model, close it and load a new model in ModelBuilder would track the ...2017-04-12T08:49:31-04:00Haocheng LIULoad a model, close it and load a new model in ModelBuilder would track the wrong model manager.Bug:
Load a model into Modelbuilder. you can get bitflags for each cell.
Close it then load a different model.
Boom! You cannot get any bitflags for any cell in the second model... Because the current manager cannot find this entity. [li...Bug:
Load a model into Modelbuilder. you can get bitflags for each cell.
Close it then load a different model.
Boom! You cannot get any bitflags for any cell in the second model... Because the current manager cannot find this entity. [link](https://gitlab.kitware.com/cmb/smtk/blob/master/smtk/model/EntityRef.cxx#L195)
Inspection(Thanks to David):
CMB is creating a new vtkSMModelManagerProxy (which is what owns the client's smtk::model::Manager) but that some part of CMB is holding on to the old smtk::model::Manager and trying to use it to fetch information about the new model entities.https://gitlab.kitware.com/cmb/cmb/-/issues/132Selection manager should not touch current list in attribute panel2017-04-05T14:09:56-04:00Haocheng LIUSelection manager should not touch current list in attribute panelHaocheng LIUHaocheng LIUhttps://gitlab.kitware.com/cmb/cmb/-/issues/130Display and Color Map tabs only appear on file open...2017-03-16T11:22:48-04:00David ThompsonDisplay and Color Map tabs only appear on file open...... not when creating an empty model/session.... not when creating an empty model/session.4.1David ThompsonDavid Thompsonhttps://gitlab.kitware.com/cmb/cmb/-/issues/129Zoom-to-data button doesn't work on images.2018-08-09T13:56:28-04:00David ThompsonZoom-to-data button doesn't work on images.## Reproducing the issue
Create a polygon session and use the "Add Image" operator to load an image (e.g., the New River DEM). Click on the image in the tree view and then click on the "zoom-to-data" button in the toolbar. Nothing happe...## Reproducing the issue
Create a polygon session and use the "Add Image" operator to load an image (e.g., the New River DEM). Click on the image in the tree view and then click on the "zoom-to-data" button in the toolbar. Nothing happens even when the image is outside the viewport.https://gitlab.kitware.com/cmb/cmb/-/issues/128In Exodus session, entity name change and color change would not be saved whe...2017-04-12T08:49:31-04:00Haocheng LIUIn Exodus session, entity name change and color change would not be saved when export the model and reload againhttps://gitlab.kitware.com/cmb/cmb/-/issues/127Cannot sort items in Open File dialog. Ex Filename/Type/Size.2017-04-12T08:49:31-04:00Haocheng LIUCannot sort items in Open File dialog. Ex Filename/Type/Size.Check pqFileDialogCheck pqFileDialogHaocheng LIUHaocheng LIUhttps://gitlab.kitware.com/cmb/cmb/-/issues/126Entity List View Todo List2017-04-12T08:49:31-04:00Haocheng LIUEntity List View Todo List* [x] entities should be sorted by a default order rather than sorted by entity numbers(descrptionPhase)
* [x] after changes are made to the entity name, the list should be sorted.* [x] entities should be sorted by a default order rather than sorted by entity numbers(descrptionPhase)
* [x] after changes are made to the entity name, the list should be sorted.Haocheng LIUHaocheng LIUhttps://gitlab.kitware.com/cmb/cmb/-/issues/125Color By's default option should not be set to None2017-04-12T08:49:31-04:00Haocheng LIUColor By's default option should not be set to NoneHaocheng LIUHaocheng LIUhttps://gitlab.kitware.com/cmb/cmb/-/issues/124Add new features for selection into CMB2018-08-09T14:07:25-04:00Haocheng LIUAdd new features for selection into CMB* [x] ZoomToBox should use `pqRenderViewSelectionReaction` rather than the old `RubberbandHelper`.
* [x] Add a new feature for `Zoom to Selection`.
* [x] add selection filter. Model/Group/Vo/F/E/Ve/Aux buttons should be added. And Op...* [x] ZoomToBox should use `pqRenderViewSelectionReaction` rather than the old `RubberbandHelper`.
* [x] Add a new feature for `Zoom to Selection`.
* [x] add selection filter. Model/Group/Vo/F/E/Ve/Aux buttons should be added. And Operator dialogue should able to communicate with these buttons.
- [x] Fix issue [updating attribute panel](https://gitlab.kitware.com/cmb/smtk/issues/123)
- [x] Model/Vo/Aux should be highlighted by wire frame(bounding box per say). F/E/Ve should be highlighted by cell.
- [ ] Rubber band should be able to select to auxGeom.
Haocheng LIUHaocheng LIUhttps://gitlab.kitware.com/cmb/cmb/-/issues/123Fix wrong key press label for Ruler on mac2017-04-12T08:49:31-04:00Haocheng LIUFix wrong key press label for Ruler on macOn mac we should use **cmd** rather than **Ctrl** to snap points.
ParaView MR [!1177](https://gitlab.kitware.com/paraview/paraview/merge_requests/1177) addresses this issue.
cc @bob.obara .On mac we should use **cmd** rather than **Ctrl** to snap points.
ParaView MR [!1177](https://gitlab.kitware.com/paraview/paraview/merge_requests/1177) addresses this issue.
cc @bob.obara .Haocheng LIUHaocheng LIUhttps://gitlab.kitware.com/cmb/cmb/-/issues/121Setting Entity Color via Model Tree View needs to be consistent with 3D Conte...2017-06-02T09:02:29-04:00Robert M. O'BaraSetting Entity Color via Model Tree View needs to be consistent with 3D Context menuSetting an entity color via the 3D View's context menu and via the Model Tree View have different defaults when the entity doesn't initially have an explicit color assigned to it:
Via 3D View Context Menu- Value is 255 and Alpha is 255
...Setting an entity color via the 3D View's context menu and via the Model Tree View have different defaults when the entity doesn't initially have an explicit color assigned to it:
Via 3D View Context Menu- Value is 255 and Alpha is 255
Via Context Menu in Tree View - Both Value and Alpha is 0
The Context menu method should behave like the 3D View.4.1Yumin YuanYumin Yuan