Skip to content
Snippets Groups Projects

WIP ACE3P plugin

Closed WIP ACE3P plugin
john.tourtellott/cmb-superbuild:ace3p-plugin into master
Closed John Tourtellott requested to merge john.tourtellott/cmb-superbuild:ace3p-plugin into master

Adds ACE3P plugin project and updates logic for installing girder_client as part of the smtk project when cumulus is enabled (via pypi).

Marked WIP because it is based on windows packaging MR (!579 (closed)), which should be merged first

Merge request reports

Loading
Loading

Activity

Filter activity
  • Approvals
  • Assignees & reviewers
  • Comments (from bots)
  • Comments (from users)
  • Commits & branches
  • Edits
  • Labels
  • Lock status
  • Mentions
  • Merge request status
  • Tracking
  • Kitware Robot
    Kitware Robot @kwrobot ·
    Owner

    Warnings:

    • the merge request is marked as a work-in-progress.

    The warnings do not need to be fixed, but it is recommended to do so.

  • John Tourtellott added 1 commit

    added 1 commit

    Compare with previous version

  • Kitware Robot
    Kitware Robot @kwrobot ·
    Owner

    Warnings:

    • the merge request is marked as a work-in-progress.

    The warnings do not need to be fixed, but it is recommended to do so.

  • John Tourtellott added 1 commit

    added 1 commit

    • 610cf695 - Make cmbworkflows and smtkace3p mutually exclusive

    Compare with previous version

  • Kitware Robot
    Kitware Robot @kwrobot ·
    Owner

    Warnings:

    • the merge request is marked as a work-in-progress.

    The warnings do not need to be fixed, but it is recommended to do so.

    • John Tourtellott
      John Tourtellott @john.tourtellott ·
      Author Developer

      @ben.boeckel I hit a new problem on Windows that you might find interesting. It turns out that my extra project step to install girder-client after smtk builds doesn't work on windows. The error message is:

      installing girder-client
'..' is not recognized as an internal or external command, operable program or batch file.

      Looking for the underlying cause, I see that the build.make file generated for smtk has this logic for the installing girder-client:

      cd C:/Users/ContainerUser/build/cmb-superbuild/superbuild && ../install/Python/python.exe -m pip install -t C:/Users/ContainerUser/build/cmb-superbuild/install/lib/python3.7/site-packages --upgrade girder-client==3.0.5

      Most notably, the path to the python.exe was generated as a relative path ../install/Python/python.exe, even though it is specified as ${superbuild_python_executable} in my smtk.cmake file. So my guess is that the shell executing this step doesn't recognize the forward slashes. Would this be a cmd shell instead of powershell? Is there some way to change/fix this? Or is there a way in cmake to convert to windows-style paths?

    • Ben Boeckel
      Ben Boeckel @ben.boeckel ·
      Maintainer

      Hmm. That should be an absolute path. Is this still happening today?

    • John Tourtellott
      John Tourtellott @john.tourtellott ·
      Author Developer

      Well gosh, I don't know, @ben.boeckel, but that's a darn good question...

      Since it has been almost a year since I worked on this MR, I suppose I should either close it or retool. But before disposing of this MR, I need to revisit the fate of MR paraview/common-superbuild!331 (closed). Your comment in Jan 2020 was "Let's test this in paraview-superbuild as well since it does have Python3 builders." Can recall what you had in mind there? I mean how to do that - is that a manual thing or can we get CI to do that?

      Edited by John Tourtellott
    • Ben Boeckel
      Ben Boeckel @ben.boeckel ·
      Maintainer

      Make a ParaView MR with the superbuild commit pointing to that branch (you probably need to rebase it at this point). Let CI churn on it (just one Windows build should be enough) and make sure things aren't broken.

    • John Tourtellott
      John Tourtellott @john.tourtellott ·
      Author Developer

      I think I understand, but I seem to be doing it wrong and need more help.

    • John Tourtellott
      John Tourtellott @john.tourtellott ·
      Author Developer

      Oh, looks like I failed to update the .gitmodules. I'll try again.

    • John Tourtellott
      John Tourtellott @john.tourtellott ·
      Author Developer

      Fixed .gitmodules, but Kitware Robot still unhappy because my common-superbuild commit no on the master branch. Would that screw up CI too? FWIW the pipeline remains blocked link.

    • Aron Helser
      Aron Helser @aron.helser ·
      Contributor

      The permission error about failed to remove .gitlab/... is a race condition. Gitlab ci is automatically checking out the repro to be tested, and it is failing to clean up the previous one. To fix it, you can use metaverse to log on to the afflicted machine (kerbin ?) and delete the checkout in c:/glr/builds/cmb/cmb-ci/ . The names of these directories on various platforms are sorta documented https://gitlab.kitware.com/cmb/smtk/-/blob/master/doc/dev/gitlab-ci.md

      Superbuild pipelines intentionally require a manual start, because they take so much time/resources to build.

    • Ben Boeckel
      Ben Boeckel @ben.boeckel ·
      Maintainer

      And the testing infrastructure knows how to check out under-test submodules. The robot is just saying it refuses to merge submodules which have not been merged.

    • Please register or sign in to reply
  • John Tourtellott added 10 commits

    added 10 commits

    • 610cf695...8c510325 - 2 commits from branch cmb:master
    • 3fcd8d6b - Add path for python3 when built in the superbuild
    • b5a255e4 - Add workaround to cmb.cmake & smtkprojectmanager.cmake for Windows build
    • b09d3207 - Add python dependency to smtkprojectmanager
    • c827456c - Add smtkace3p project to build ace3p-extensions plugin
    • 3e389346 - Add step to smtk.cmake to install girder-client from pypi
    • 5dace024 - Delete unused python projects
    • 941b265f - Fix cumulus dependencies
    • 86a84efb - Make cmbworkflows and smtkace3p mutually exclusive

    Compare with previous version

    Toggle commit list
  • Kitware Robot
    Kitware Robot @kwrobot ·
    Owner

    Warnings:

    • the merge request is marked as a work-in-progress.

    The warnings do not need to be fixed, but it is recommended to do so.

  • John Tourtellott added 1 commit

    added 1 commit

    • e9cdb3c8 - Move girder-client install from the smtk project to cumulus

    Compare with previous version

  • Kitware Robot
    Kitware Robot @kwrobot ·
    Owner

    Errors:

    • The given email (john@tortuga2.fios-router.home) for commit e9cdb3c8 has an unknown domain. Please set the user.email Git configuration value.

    Warnings:

    • the merge request is marked as a work-in-progress.

    The warnings do not need to be fixed, but it is recommended to do so.

    Please rewrite commits to fix the errors listed above (adding fixup commits will not resolve the errors) and force-push the branch again to update the merge request.

  • John Tourtellott added 1 commit

    added 1 commit

    • e968f7d0 - Installing girder-client on windows requires setuptools-scm

    Compare with previous version

  • Kitware Robot
    Kitware Robot @kwrobot ·
    Owner

    Errors:

    • The given email (john@tortuga2.fios-router.home) for commit e9cdb3c8 has an unknown domain. Please set the user.email Git configuration value.
    • The given email (john@tortuga2.fios-router.home) for commit e968f7d0 has an unknown domain. Please set the user.email Git configuration value.

    Warnings:

    • the merge request is marked as a work-in-progress.

    The warnings do not need to be fixed, but it is recommended to do so.

    Please rewrite commits to fix the errors listed above (adding fixup commits will not resolve the errors) and force-push the branch again to update the merge request.

  • John Tourtellott added 1 commit

    added 1 commit

    • 384b2e03 - And more native path conversion and escaped backslashes

    Compare with previous version

  • Kitware Robot
    Kitware Robot @kwrobot ·
    Owner

    Errors:

    • The given email (john@tortuga2.fios-router.home) for commit e9cdb3c8 has an unknown domain. Please set the user.email Git configuration value.
    • The given email (john@tortuga2.fios-router.home) for commit e968f7d0 has an unknown domain. Please set the user.email Git configuration value.
    • The given email (john@tortuga2.fios-router.home) for commit 384b2e03 has an unknown domain. Please set the user.email Git configuration value.

    Warnings:

    • the merge request is marked as a work-in-progress.

    The warnings do not need to be fixed, but it is recommended to do so.

    Please rewrite commits to fix the errors listed above (adding fixup commits will not resolve the errors) and force-push the branch again to update the merge request.

  • John Tourtellott added 1 commit

    added 1 commit

    • 893c790c - And more native path conversion and escaped backslashes

    Compare with previous version

  • Kitware Robot
    Kitware Robot @kwrobot ·
    Owner

    Errors:

    • The given email (john@tortuga2.fios-router.home) for commit e9cdb3c8 has an unknown domain. Please set the user.email Git configuration value.
    • The given email (john@tortuga2.fios-router.home) for commit e968f7d0 has an unknown domain. Please set the user.email Git configuration value.
    • The given email (john@tortuga2.fios-router.home) for commit 893c790c has an unknown domain. Please set the user.email Git configuration value.

    Warnings:

    • the merge request is marked as a work-in-progress.

    The warnings do not need to be fixed, but it is recommended to do so.

    Please rewrite commits to fix the errors listed above (adding fixup commits will not resolve the errors) and force-push the branch again to update the merge request.

  • John Tourtellott added 1 commit

    added 1 commit

    • bf4d078b - And more native path conversion and escaped backslashes

    Compare with previous version

  • Kitware Robot
    Kitware Robot @kwrobot ·
    Owner

    Errors:

    • The given email (john@tortuga2.fios-router.home) for commit e9cdb3c8 has an unknown domain. Please set the user.email Git configuration value.
    • The given email (john@tortuga2.fios-router.home) for commit e968f7d0 has an unknown domain. Please set the user.email Git configuration value.
    • The given email (john@tortuga2.fios-router.home) for commit bf4d078b has an unknown domain. Please set the user.email Git configuration value.

    Warnings:

    • the merge request is marked as a work-in-progress.

    The warnings do not need to be fixed, but it is recommended to do so.

    Please rewrite commits to fix the errors listed above (adding fixup commits will not resolve the errors) and force-push the branch again to update the merge request.

  • John Tourtellott added 1 commit

    added 1 commit

    • a59c76c2 - And more native path conversion and escaped backslashes

    Compare with previous version

  • Kitware Robot
    Kitware Robot @kwrobot ·
    Owner

    Errors:

    • The given email (john@tortuga2.fios-router.home) for commit e9cdb3c8 has an unknown domain. Please set the user.email Git configuration value.
    • The given email (john@tortuga2.fios-router.home) for commit e968f7d0 has an unknown domain. Please set the user.email Git configuration value.
    • The given email (john@tortuga2.fios-router.home) for commit a59c76c2 has an unknown domain. Please set the user.email Git configuration value.

    Warnings:

    • the merge request is marked as a work-in-progress.

    The warnings do not need to be fixed, but it is recommended to do so.

    Please rewrite commits to fix the errors listed above (adding fixup commits will not resolve the errors) and force-push the branch again to update the merge request.

  • Loading
  • Loading
  • Loading
  • Loading
  • Loading
  • Loading
  • Loading
  • Loading
  • Loading
  • Loading
Please register or sign in to reply