Warnings:
.rst
in doc/release/notes
.The warnings do not need to be fixed, but it is recommended to do so.
This topic has been reformatted and pushed; please fetch from the source repository and reset your local branch to continue with further development on the reformatted commits.
Do: reformat
Errors:
smtk/extension/qt/qtSMTKUtilities.cxx
, smtk/extension/qt/qtSMTKUtilities.h
. Post a comment ending in the line Do: reformat
to rewrite the MR source branch automatically.Warnings:
.rst
in doc/release/notes
.The warnings do not need to be fixed, but it is recommended to do so.
Please rewrite commits to fix the errors listed above (adding fixup commits will not resolve the errors) and force-push the branch again to update the merge request.
Implements a widget factory registry to extend the user interface of task nodes in the diagram editor via the styles section in the worklet JSON.
Errors:
Warnings:
.rst
in doc/release/notes
.The warnings do not need to be fixed, but it is recommended to do so.
Please rewrite commits to fix the errors listed above (adding fixup commits will not resolve the errors) and force-push the branch again to update the merge request.
This topic has been reformatted and pushed; please fetch from the source repository and reset your local branch to continue with further development on the reformatted commits.
Do: reformat
Errors:
smtk/view/PhraseModel.cxx
. Post a comment ending in the line Do: reformat
to rewrite the MR source branch automatically.Warnings:
.rst
in doc/release/notes
.The warnings do not need to be fixed, but it is recommended to do so.
Please rewrite commits to fix the errors listed above (adding fixup commits will not resolve the errors) and force-push the branch again to update the merge request.
Fixes: Modelbuilder crash when exiting project with resources
Also added an iterator section to an existing test.
Closes #530
template<typename DataT>
class SMTK_ALWAYS_EXPORT ValueItemTemplate : public ValueItem
{
//template<DataT> friend class ValueItemDefinitionTemplate;
public:
typedef DataT DataType;
typedef typename std::vector<DataT> value_type;
typedef value_type const_iterator;
typedef ValueItemDefinitionTemplate<DataType> DefType;
~ValueItemTemplate() override = default;
typename std::vector<DataT>::const_iterator begin() const { return m_values.begin(); }
typename std::vector<DataT>::const_iterator end() const { return m_values.end(); }
In the snippet above, should typedef value_type const_iterator;
actually be written as typedef typename value_type::const_iterator const_iterator;
?
If so, should the following begin()
and end()
functions be declared as:
const_iterator begin() const { return m_values.begin(); }
const_iterator end() const { return m_values.end(); }
???
Do: merge
+2
Warnings:
.rst
in doc/release/notes
.The warnings do not need to be fixed, but it is recommended to do so.
Also added an iterator section to an existing test.
Closes #530
Currently, qtDefaultTaskNode creates a context menu to allow tasks to be renamed. Instead of that code residing in a lambda, it should be in a protected method that the lambda calls so subclasses can append actions to the context menu.
Added a virtual method to qtBaseTaskNode to setup a context menu for a qtTaskNode. Closes #528
Kitware Robot (6bc70a18) at 25 Mar 16:02
Merge topic 'expandingTaskNodeWidgetContextMenu'
... and 1 more commit