Skip to content

cmUVProcessChain: Add assert() for static analysis tools

Kyle Edwards requested to merge kyle.edwards/cmake:cmuvprocesschain-iterator-fix into master

Some static analysis tools throw a false positive for an out-of-bounds item that is being dereferenced. This out-of-bounds error will never actually happen because of how cmUVProcessChain::InternalData::AddCommand() is being called. Nevertheless, this change adds an assert() to help static analysis tools be absolutely certain that the referenced item is within the vector's bounds.

This change also changes the item access to use an index rather than an iterator.

Edited by Kyle Edwards

Merge request reports