Skip to content
Snippets Groups Projects

Pass EXCLUDE_FROM_ALL from directory to targets

Merged Zack Galbreath requested to merge zackgalbreath/cmake:exclude_from_all into master

When a target is created it now inherits the EXCLUDE_FROM_ALL property from its directory. This change makes it possible to include a target in "all", even if its directory has been marked as EXCLUDE_FROM_ALL.

Merge request reports

Pipeline #128131 passed

Pipeline passed for dc688857 on zackgalbreath:exclude_from_all

Merged by Kitware RobotKitware Robot 6 years ago (Jan 25, 2019 1:06pm UTC)

Merge details

  • Changes merged into with 24b6e483.
  • Deleted the source branch.

Pipeline #128588 passed

Pipeline passed for 24b6e483 on master

Activity

Filter activity
  • Approvals
  • Assignees & reviewers
  • Comments (from bots)
  • Comments (from users)
  • Commits & branches
  • Edits
  • Labels
  • Lock status
  • Mentions
  • Merge request status
  • Tracking
  • Zack Galbreath added 85 commits

    added 85 commits

    Compare with previous version

  • Zack Galbreath added 1 commit

    added 1 commit

    • 67635e22 - Pass EXCLUDE_FROM_ALL from directory to targets

    Compare with previous version

  • Errors:

    • commit 67635e22 is not allowed because the following files are not formatted according to the 'clang-format-6.0' check: Source/cmGlobalGenerator.cxx. Post a comment ending in the line Do: reformat to rewrite the MR source branch automatically.

    Please rewrite commits to fix the errors listed above (adding fixup commits will not resolve the errors) and force-push the branch again to update the merge request.

  • Do: reformat

  • This topic has been reformatted and pushed; please fetch from the source repository and reset your local branch to continue with further development on the reformatted commits.

  • Kitware Robot added 1 commit

    added 1 commit

    • 627f33fe - Pass EXCLUDE_FROM_ALL from directory to targets

    Compare with previous version

  • Zack Galbreath resolved all discussions

    resolved all discussions

  • do: test

  • This merge request has been queued for testing. Test results may be viewed on:

    • CDash (master)
    • Buildbot (master) (only visible from inside Kitware)

    Branch-at-master: 627f33fe

  • I see my new test case fails on terfin. I'm working on reproducing this locally.

  • Zack Galbreath added 1 commit

    added 1 commit

    • 0de5203c - Pass EXCLUDE_FROM_ALL from directory to targets

    Compare with previous version

  • do: test

  • This merge request has been queued for testing. Test results may be viewed on:

    • CDash (master)
    • Buildbot (master) (only visible from inside Kitware)

    Branch-at-master: 0de5203c

  • @kyle.edwards, you may remember the conversation we had about how EXCLUDE_FROM_ALL couldn't be overridden at the target level. This MR addresses that. Would you please review these proposed changes?

  • Loading
  • Loading
  • Loading
  • Loading
  • Loading
  • Loading
  • Loading
  • Loading
  • Loading
  • Loading
  • Please register or sign in to reply
    Loading