Skip to content

WriteBasicConfigVersionFile: Add SamePatchVersion COMPATIBILITY option

Daniele E. Domenichelli requested to merge drdanz/cmake:WriteBasicConfigFile_SamePatchVersion into master

The reason for this is that ExactVersion never checks the tweak number. This makes it useless to request a package with a specific tweak number.

For example, if the version installed is 4.5.6.7, and the user is requesting 4.5.6.9, ExactVersion considers the 2 versions compatible, even if the user is requesting a newer version than the one found on the system.

The easier patch would be to modify ExactVersion to check that the tweak number requested is greater or equal than the one found on the system, but I don't know if this is a wanted behaviour (the documentation mentions this) or if someone is using this...

I also improved the unit test suite while doing these changes, since I suspected there could be other issues like this.

The only issue that I found (besides this one) is that if the version installed is, for example, "3.2" (2 numbers only), it is not considered compatible if the user requests "3.2.0". Again, I don't know if this is a bug or an expected result, therefore i did not touch it...

Merge request reports