Skip to content

VS: Fix VS_SDK_REFERENCES when target is not a Windows 10 app

Roc Ramon requested to merge rcrmn/cmake:release into master

We found a bug when generating a VS project for VS2015 with a platform different to Windows 10:

when setting the VS_SDK_REFERENCES, the outputted vcxproj was non-xml compliant

SET_PROPERTY (TARGET game PROPERTY VS_SDK_REFERENCES "Whatever Reference, Version=8.0")

resulted in the following lines in the end of the outputted file:

  <ItemGroup>
    <SDKReference Include="Whatever Reference, Version=8.0"/>
  <Import Project="$(VCTargetsPath)\Microsoft.Cpp.targets" />
  <ImportGroup Label="ExtensionTargets">
  </ImportGroup>
</Project>

Notice that the is missing a matching .

The provided change should fix this issue.

Topic-rename: vs-sdk-refs

Edited by Brad King

Merge request reports