FindOctave: module added by 3.14.0-rc{1,2} is not ready for release
While investigating #18988 (closed) I noticed several problems with FindOctave that I somehow missed during review in !2630 (merged), perhaps because I focused too much on the docs and test and not enough on the implementation.
The problems include the following:
- The handling of
REQUIRED_VARS
is incorrect. The value should be a list of cache variables, not results. - The value of
octave-config -p OCTINCLUDEDIR
is wrong on at least some platforms (see #18988 (closed)). - Results are taken directly from
octave-config
on every run rather than found viafind_*
commands and cached. - The call to
cmake_policy(VERSION 3.3)
is not appropriate in an upstream find module. If certain policies are needed they should be set viacmake_policy(PUSH)
,cmake_policy(SET)
, andcmake_policy(POP)
.
Edited by Brad King