FindOctave should not include "octave" in `Octave_INCLUDE_DIR`
On my system (debian testing + CMake master) the FindOctave
module sets the Octave_INCLUDE_DIR
to /usr/include/octave-4.4.1/octave
. This folder should be /usr/include/octave-4.4.1
instead. The same issue is inherited by the Octave::Octave
target.
As far as I know, typically the files from octave are included passing the octave
folder. For example, files generated by Swig include the files in this way:
#include <octave/oct.h>
#include <octave/version.h>
These file, at the moment, do not compile with the Octave::Octave
target.
I recommend to fix this before CMake 3.14 final release, because this folders contains files like version.h
, error.h
, utils.h
and more, that are very likely to cause conflicts. Also if people starts using it, it will be harder later to change it, keeping the compatibility and avoiding at the same time the conflicts.