Skip to content

  • Projects
  • Groups
  • Snippets
  • Help
    • Loading...
    • Help
    • Support
    • Submit feedback
    • Contribute to GitLab
  • Sign in / Register
CMake
CMake
  • Project overview
    • Project overview
    • Details
    • Activity
    • Releases
    • Cycle Analytics
  • Repository
    • Repository
    • Files
    • Commits
    • Branches
    • Tags
    • Contributors
    • Graph
    • Compare
    • Charts
  • Issues 2,686
    • Issues 2,686
    • List
    • Boards
    • Labels
    • Milestones
  • Merge Requests 24
    • Merge Requests 24
  • Packages
    • Packages
    • Container Registry
  • External Wiki
    • External Wiki
  • Members
    • Members
  • Collapse sidebar
  • Activity
  • Graph
  • Charts
  • Create a new issue
  • Commits
  • Issue Boards
  • CMake
  • CMakeCMake
  • Issues
  • #16694

Closed
Open
Opened Mar 04, 2017 by Kris Thielemans@krthie
  • Report abuse
  • New issue
Report abuse New issue

FindHDF5: Provide HDF5_<lang>_INCLUDE_DIRS

Depending on which path is used by FindHDF5, the HDF5_${__lang}_INCLUDE_DIRS variable is not always set. In particular, when using find_path(HDF5_${__lang}_INCLUDE_DIR ...) is used, but the (language-specific) _DIRS variable is not set. In all other cases, the _DIR variable is not set.

We should always set _DIRS. Optionally, we could set _DIR to _DIRS as I did before

foreach(__lang IN LISTS HDF5_LANGUAGE_BINDINGS)
   if ( HDF5_${__lang}_INCLUDE_DIRS )
       set(HDF5_${__lang}_INCLUDE_DIR "${HDF5_${__lang}_INCLUDE_DIRS}")
   endif()
endforeach()

but I guess @brad.king doesn't like that. Fine for me, as the _DIR variable wasn't always set since 00405af0 so users cannot rely on existence of the (deprecated) variable anyway.

Assignee
Assign to
None
Milestone
None
Assign milestone
Time tracking
None
Due date
None
3
Labels
triage:area-maintainer-wanted triage:feature triage:mr-welcome
Assign labels
  • View project labels
Reference: cmake/cmake#16694