1. 01 Jun, 2018 1 commit
    • Kitware Robot's avatar
      Revise C++ coding style using clang-format-6.0 · d7204e64
      Kitware Robot authored
      Run the `clang-format.bash` script to update all our C and C++ code to a
      new style defined by `.clang-format`.  Use `clang-format` version 6.0.
      
      * If you reached this commit for a line in `git blame`, re-run the blame
        operation starting at the parent of this commit to see older history
        for the content.
      
      * See the parent commit for instructions to rebase a change across this
        style transition commit.
      d7204e64
  2. 21 Mar, 2018 1 commit
  3. 16 Mar, 2018 1 commit
    • Brad King's avatar
      find_package: Use PackageName_ROOT variables as search prefixes · eb35d888
      Brad King authored
      This feature was originally added by commit v3.9.0-rc1~71^2~2 (find_*:
      Add a new PackageRoot search path group, 2017-05-03) and documented by
      commit v3.9.0-rc1~71^2 (find_*: Add docs for PackageRoot search path
      group, 2017-05-03).  However, we had to disable the feature and remove
      the documentation in commit v3.9.1~2^2 (find_*: Disable the PACKAGE_ROOT
      search path group for CMake 3.9, 2017-08-08) due to breaking projects
      that used `PackageName_ROOT` variables themselves.
      
      Add policy `CMP0074` to restore the `PackageName_ROOT` variable behavior
      in a compatible way.  Also revise the stack of root paths to store the
      paths themselves rather than the package names.  This way the policy can
      be considered at the `find_package` call site instead of individual
      `find_` calls inside a find module.
      
      Co-Author: Chuck Atkins <chuck.atkins@kitware.com>
      Issue: #17144
      eb35d888
  4. 31 Jan, 2018 1 commit
    • Pavel Solodovnikov's avatar
      Reduce raw string pointers usage. · 653b8946
      Pavel Solodovnikov authored
      * Change some functions to take `std::string` instead of
        `const char*` in the following classes: `cmMakeFile`, `cmake`,
        `cmCoreTryCompile`, `cmSystemTools`,  `cmState`, `cmLocalGenerator`
        and a few others.
      * Greatly reduce using of `const char*` overloads for
        `cmSystemTools::MakeDirectory` and `cmSystemTools::RelativePath`.
      * Remove many redundant `c_str()` conversions throughout the code.
      653b8946
  5. 26 Jan, 2018 1 commit
  6. 03 Nov, 2017 1 commit
    • luz.paz's avatar
      Fix trivial typos in text · 777e87ae
      luz.paz authored
      Some are user facing.
      
      Found using
      
          codespell -q 3 --skip="./Utilities" -I .cmake-whitelist.txt`
      
      whereby the whitelist contained:
      
          ans
          dum
          helpfull
          emmited
          emmitted
          buil
          iff
          isnt
          nto
          ot
          pathes
          substract
          te
          todays
          upto
          whitespaces
      777e87ae
  7. 25 Sep, 2017 1 commit
  8. 15 Sep, 2017 1 commit
    • Brad King's avatar
      Use C++11 override instead of CM_OVERRIDE · 0b33aee4
      Brad King authored
      We now require C++11 support including `override`.  Drop use of
      the old compatibility macro.  Convert references as follows:
      
          git grep -l CM_OVERRIDE -- '*.h' '*.hxx' '*.cxx' |
            xargs sed -i 's/CM_OVERRIDE/override/g'
      0b33aee4
  9. 12 Sep, 2017 1 commit
  10. 24 Aug, 2017 1 commit
  11. 08 Aug, 2017 1 commit
    • Brad King's avatar
      find_*: Disable the PACKAGE_ROOT search path group for CMake 3.9 · 578d95f8
      Brad King authored
      Disable the feature added by commit v3.9.0-rc1~71^2~2 (find_*: Add a new
      PackageRoot search path group, 2017-05-03) and remove documentation
      added by commit v3.9.0-rc1~71^2 (find_*: Add docs for PackageRoot search
      path group, 2017-05-03).  Unfortunately the name `<pkg>_ROOT` may
      already be set by projects for their own incompatible purposes.  Disable
      the behavior change for now to fix the regression for CMake 3.9.  We can
      restore it later with a policy.
      
      In order to keep the implementation and tests working, add an
      undocumented variable we can use in the tests to enable the behavior
      before the policy is introduced.
      
      Fixes: #17144
      578d95f8
  12. 28 Jul, 2017 1 commit
  13. 07 Jul, 2017 1 commit
    • Brad King's avatar
      find_package: Restore longer message when config files were considered · e7730d78
      Brad King authored
      Since commit v3.9.0-rc1~58^2 (find_package: shorten output for missing
      package in config mode, 2017-05-09) we print only the one line
      
          - Could NOT find Foo (missing: Foo_DIR)
      
      when package Foo cannot be found in CONFIG mode and it is not REQUIRED.
      However, in the case that package configuration files were found but not
      used, this one line message leaves out important information.  This can
      happen when a package configuration file sets `Foo_FOUND` to `FALSE` or
      when its package version file does not match the requested version.
      Restore the longer message in these cases.  Otherwise a seemingly valid
      explicit `Foo_DIR` setting appears to be silently ignored even if it was
      considered.
      
      Fixes: #17029
      e7730d78
  14. 03 Jun, 2017 1 commit
  15. 01 Jun, 2017 1 commit
  16. 26 May, 2017 1 commit
  17. 23 May, 2017 2 commits
  18. 16 May, 2017 1 commit
  19. 11 Apr, 2017 1 commit
    • Daniel Pfeifer's avatar
      Use quotes for non-system includes · 1d829c86
      Daniel Pfeifer authored
      Automate with:
      
      git grep -l '#include <cm_' -- Source \
        | xargs sed -i 's/#include <\(cm_.*\)>/#include "\1"/g'
      
      git grep -l '#include <cmsys/' -- Source \
        | xargs sed -i 's/#include <\(cmsys\/.*\)>/#include "\1"/g'
      
      git grep -l '#include <cm[A-Z]' -- Source \
        | xargs sed -i 's/#include <\(cm[A-Z].*\)>/#include "\1"/g'
      1d829c86
  20. 14 Mar, 2017 1 commit
    • Daniel Pfeifer's avatar
      fix include order of windows.h · 4b49c9a2
      Daniel Pfeifer authored
      Comments that indicate a special include order is necessary because
      GetCurrentDirectory might get redefined are outdated.  Remove those
      outdated comments and use the normal ordering of includes.
      4b49c9a2
  21. 07 Mar, 2017 1 commit
    • Steven Newbury's avatar
      Add support for x32-abi · 462cf254
      Steven Newbury authored
      Detect x32-abi through CMakeCompilerABI infrastruture and use this
      information at runtime to determine the correct library paths with
      `FIND_LIBRARY_USE_LIBX32_PATHS`.
      
      Fixes: #15994
      462cf254
  22. 26 Oct, 2016 1 commit
  23. 21 Oct, 2016 2 commits
  24. 19 Oct, 2016 2 commits
  25. 27 Sep, 2016 1 commit
    • Brad King's avatar
      Simplify CMake per-source license notices · 86578ecc
      Brad King authored
      Per-source copyright/license notice headers that spell out copyright holder
      names and years are hard to maintain and often out-of-date or plain wrong.
      Precise contributor information is already maintained automatically by the
      version control tool.  Ultimately it is the receiver of a file who is
      responsible for determining its licensing status, and per-source notices are
      merely a convenience.  Therefore it is simpler and more accurate for
      each source to have a generic notice of the license name and references to
      more detailed information on copyright holders and full license terms.
      
      Our `Copyright.txt` file now contains a list of Contributors whose names
      appeared source-level copyright notices.  It also references version control
      history for more precise information.  Therefore we no longer need to spell
      out the list of Contributors in each source file notice.
      
      Replace CMake per-source copyright/license notice headers with a short
      description of the license and links to `Copyright.txt` and online information
      available from "https://cmake.org/licensing".  The online URL also handles
      cases of modules being copied out of our source into other projects, so we
      can drop our notices about replacing links with full license text.
      
      Run the `Utilities/Scripts/filter-notices.bash` script to perform the majority
      of the replacements mechanically.  Manually fix up shebang lines and trailing
      newlines in a few files.  Manually update the notices in a few files that the
      script does not handle.
      86578ecc
  26. 16 Sep, 2016 1 commit
  27. 15 Sep, 2016 2 commits
  28. 24 Aug, 2016 1 commit
  29. 18 Jul, 2016 1 commit
  30. 29 Jun, 2016 1 commit
    • Brad King's avatar
      Avoid using KWSys auto_ptr by adopting it ourselves · b5ec5b09
      Brad King authored
      Replace use of cmsys::auto_ptr with a CM_AUTO_PTR macro that maps to
      our own implementation adopted from the KWSys auto_ptr implementation.
      Later we may be able to map CM_AUTO_PTR to std::auto_ptr on compilers
      that do not warn about it.
      
      Automate the client site conversions:
      
          git grep -l auto_ptr -- Source/ | grep -v Source/kwsys/ | xargs sed -i \
            's|cmsys::auto_ptr|CM_AUTO_PTR|;s|cmsys/auto_ptr.hxx|cm_auto_ptr.hxx|'
      b5ec5b09
  31. 28 Jun, 2016 1 commit
  32. 27 Jun, 2016 1 commit
  33. 13 Jun, 2016 2 commits
  34. 10 Jun, 2016 1 commit
  35. 16 May, 2016 1 commit
    • Kitware Robot's avatar
      Revise C++ coding style using clang-format · d9fd2f54
      Kitware Robot authored
      Run the `Utilities/Scripts/clang-format.bash` script to update
      all our C++ code to a new style defined by `.clang-format`.
      Use `clang-format` version 3.8.
      
      * If you reached this commit for a line in `git blame`, re-run the blame
        operation starting at the parent of this commit to see older history
        for the content.
      
      * See the parent commit for instructions to rebase a change across this
        style transition commit.
      d9fd2f54