1. 22 Jul, 2019 1 commit
  2. 16 Jan, 2019 1 commit
  3. 14 Nov, 2018 1 commit
    • Kyle Edwards's avatar
      find_package(): Add policy to remove the FindQt module · 0f5c1b40
      Kyle Edwards authored
      Removing FindQt.cmake gives Qt upstream a path forward to export its
      own QtConfig.cmake files which can be found by find_package()
      without having to explicitly specify CONFIG. Projects that still
      want to use Qt3/4 can call find_package(Qt[34]), include(FindQt),
      or add FindQt.cmake to their CMAKE_MODULE_PATH.
      0f5c1b40
  4. 20 Jul, 2018 1 commit
  5. 21 Mar, 2018 1 commit
    • Brad King's avatar
      find_package: Improve CMP0074 warning messages · 3f479a3c
      Brad King authored
      Policy `CMP0074` was added by commit eb35d888 (find_package: Use
      PackageName_ROOT variables as search prefixes, 2018-03-15).  Revise the
      logic to avoid warning when a `PackageName_ROOT` variable is set to
      empty since that won't change the search behavior.  Also, when we do
      warn include the variable value(s) for reference.
      3f479a3c
  6. 16 Mar, 2018 1 commit
    • Brad King's avatar
      find_package: Use PackageName_ROOT variables as search prefixes · eb35d888
      Brad King authored
      This feature was originally added by commit v3.9.0-rc1~71^2~2 (find_*:
      Add a new PackageRoot search path group, 2017-05-03) and documented by
      commit v3.9.0-rc1~71^2 (find_*: Add docs for PackageRoot search path
      group, 2017-05-03).  However, we had to disable the feature and remove
      the documentation in commit v3.9.1~2^2 (find_*: Disable the PACKAGE_ROOT
      search path group for CMake 3.9, 2017-08-08) due to breaking projects
      that used `PackageName_ROOT` variables themselves.
      
      Add policy `CMP0074` to restore the `PackageName_ROOT` variable behavior
      in a compatible way.  Also revise the stack of root paths to store the
      paths themselves rather than the package names.  This way the policy can
      be considered at the `find_package` call site instead of individual
      `find_` calls inside a find module.
      
      Co-Author: Chuck Atkins <chuck.atkins@kitware.com>
      Issue: #17144
      eb35d888
  7. 08 Aug, 2017 2 commits
    • Brad King's avatar
      find_*: Disable the PACKAGE_ROOT search path group for CMake 3.9 · 578d95f8
      Brad King authored
      Disable the feature added by commit v3.9.0-rc1~71^2~2 (find_*: Add a new
      PackageRoot search path group, 2017-05-03) and remove documentation
      added by commit v3.9.0-rc1~71^2 (find_*: Add docs for PackageRoot search
      path group, 2017-05-03).  Unfortunately the name `<pkg>_ROOT` may
      already be set by projects for their own incompatible purposes.  Disable
      the behavior change for now to fix the regression for CMake 3.9.  We can
      restore it later with a policy.
      
      In order to keep the implementation and tests working, add an
      undocumented variable we can use in the tests to enable the behavior
      before the policy is introduced.
      
      Fixes: #17144
      578d95f8
    • Brad King's avatar
  8. 02 Aug, 2017 1 commit
  9. 28 Jul, 2017 1 commit
  10. 11 Jul, 2017 1 commit
  11. 07 Jul, 2017 1 commit
    • Brad King's avatar
      find_package: Restore longer message when config files were considered · e7730d78
      Brad King authored
      Since commit v3.9.0-rc1~58^2 (find_package: shorten output for missing
      package in config mode, 2017-05-09) we print only the one line
      
          - Could NOT find Foo (missing: Foo_DIR)
      
      when package Foo cannot be found in CONFIG mode and it is not REQUIRED.
      However, in the case that package configuration files were found but not
      used, this one line message leaves out important information.  This can
      happen when a package configuration file sets `Foo_FOUND` to `FALSE` or
      when its package version file does not match the requested version.
      Restore the longer message in these cases.  Otherwise a seemingly valid
      explicit `Foo_DIR` setting appears to be silently ignored even if it was
      considered.
      
      Fixes: #17029
      e7730d78
  12. 23 May, 2017 1 commit
  13. 16 May, 2017 1 commit
  14. 18 Apr, 2016 1 commit
    • Brad King's avatar
      cmListFileBacktrace: Refactor storage to provide efficient value semantics · 7c36d206
      Brad King authored
      Since commit v3.4.0-rc1~321^2~2 (Genex: Store a backtrace, not a pointer
      to one, 2015-07-08) we treat cmListFileBacktrace instances as
      lightweight values.  This was true at the time only because the
      backtrace information was kept in the cmState snapshot hierarchy.
      However, that forced us to accumulate a lot of otherwise short-lived
      snapshots just to have the backtrace fields available for reference by
      cmListFileBacktrace instances.  Recent refactoring made backtrace
      instances independent of the snapshot hierarchy to avoid accumulating
      short-lived snapshots.  This came at the cost of making backtrace values
      heavy again, leading to lots of string coying and slower execution.
      
      Fix this by refactoring cmListFileBacktrace to provide value semantics
      with efficient shared storage underneath.  Teach cmMakefile to maintain
      its call stack using an instance of cmListFileBacktrace.  This approach
      allows the current backtrace to be efficiently saved whenever it is
      needed.
      
      Also teach cmListFileBacktrace the notion of a file-level scope.  This
      is useful for messages about the whole file (e.g. during parsing) that
      are not specific to any line within it.  Push the CMakeLists.txt scope
      for each directory and never pop it.  This ensures that we always have
      some context information and simplifies cmMakefile::IssueMessage.
      Push/pop a file-level scope as each included file is processed.  This
      supersedes cmParseFileScope and improves diagnostic message context
      information in a few places.  Fix the corresponding test cases to expect
      the improved output.
      7c36d206
  15. 24 Nov, 2015 1 commit
  16. 13 Aug, 2013 1 commit
  17. 19 Mar, 2012 1 commit
  18. 13 Mar, 2012 1 commit
  19. 12 Mar, 2012 1 commit