1. 08 Nov, 2019 1 commit
  2. 01 Oct, 2019 1 commit
  3. 16 Sep, 2019 1 commit
  4. 22 Aug, 2019 1 commit
    • Sebastian Holtermann's avatar
      Source sweep: Use cmStrCat for string concatenation · 9b334397
      Sebastian Holtermann authored
      This patch is generated by a python script that uses regular expressions to
      search for string concatenation patterns of the kind
      
      ```
      std::string str = <ARG0>;
      str += <ARG1>;
      str += <ARG2>;
      ...
      ```
      
      and replaces them with a single `cmStrCat` call
      
      ```
      std::string str = cmStrCat(<ARG0>, <ARG1>, <ARG2>, ...);
      ```
      
      If any `<ARGX>` is itself a concatenated string of the kind
      
      ```
      a + b + c + ...;
      ```
      
      then `<ARGX>` is split into multiple arguments for the `cmStrCat` call.
      
      If there's a sequence of literals in the `<ARGX>`, then all literals in the
      sequence are concatenated and merged into a single literal argument for
      the `cmStrCat` call.
      
      Single character strings are converted to single char arguments for
      the `cmStrCat` call.
      
      `std::to_string(...)` wrappings are removed from `cmStrCat` arguments,
      because it supports numeric types as well as string types.
      
      `arg.substr(x)` arguments to `cmStrCat` are replaced with
      `cm::string_view(arg).substr(x)`
      9b334397
  5. 06 Feb, 2019 1 commit
  6. 25 Jan, 2019 1 commit
    • wahikihiki's avatar
      clang-tidy: Use `= default` · 55671b41
      wahikihiki authored
      Suppress some cases in `Source/cmGeneratorExpressionNode.cxx` and
      `Source/cmUVHandlePtr.h` where a few older compilers require a
      user-defined default constructor (with `{}`).
      55671b41
  7. 17 Jan, 2019 1 commit
  8. 27 Nov, 2018 1 commit
  9. 01 Jun, 2018 1 commit
    • Kitware Robot's avatar
      Revise C++ coding style using clang-format-6.0 · d7204e64
      Kitware Robot authored
      Run the `clang-format.bash` script to update all our C and C++ code to a
      new style defined by `.clang-format`.  Use `clang-format` version 6.0.
      
      * If you reached this commit for a line in `git blame`, re-run the blame
        operation starting at the parent of this commit to see older history
        for the content.
      
      * See the parent commit for instructions to rebase a change across this
        style transition commit.
      d7204e64
  10. 23 Jan, 2018 1 commit
  11. 05 Oct, 2017 1 commit
    • Brad King's avatar
      CPack: Fix PackageMaker .dmg HFS+ creation on macOS APFS hosts · 4f2a983c
      Brad King authored
      When running `hdiutil create`, specify the HFS+ filesystem explicitly.
      Otherwise `hdiutil` may choose a filesystem based on the host.  We do
      not want to create APFS images for `.dmg` packages because they may not
      mount on macOS versions prior to 10.12.
      
      This was missed in commit 39b50975 (CPack: Fix .dmg HFS+ creation on
      macOS APFS hosts, 2017-10-02).
      
      Reported-by: Alan Garny
      4f2a983c
  12. 28 Sep, 2017 1 commit
  13. 19 Sep, 2017 1 commit
  14. 11 Apr, 2017 1 commit
    • Daniel Pfeifer's avatar
      Use quotes for non-system includes · 1d829c86
      Daniel Pfeifer authored
      Automate with:
      
      git grep -l '#include <cm_' -- Source \
        | xargs sed -i 's/#include <\(cm_.*\)>/#include "\1"/g'
      
      git grep -l '#include <cmsys/' -- Source \
        | xargs sed -i 's/#include <\(cmsys\/.*\)>/#include "\1"/g'
      
      git grep -l '#include <cm[A-Z]' -- Source \
        | xargs sed -i 's/#include <\(cm[A-Z].*\)>/#include "\1"/g'
      1d829c86
  15. 22 Nov, 2016 1 commit
  16. 27 Sep, 2016 1 commit
    • Brad King's avatar
      Simplify CMake per-source license notices · 86578ecc
      Brad King authored
      Per-source copyright/license notice headers that spell out copyright holder
      names and years are hard to maintain and often out-of-date or plain wrong.
      Precise contributor information is already maintained automatically by the
      version control tool.  Ultimately it is the receiver of a file who is
      responsible for determining its licensing status, and per-source notices are
      merely a convenience.  Therefore it is simpler and more accurate for
      each source to have a generic notice of the license name and references to
      more detailed information on copyright holders and full license terms.
      
      Our `Copyright.txt` file now contains a list of Contributors whose names
      appeared source-level copyright notices.  It also references version control
      history for more precise information.  Therefore we no longer need to spell
      out the list of Contributors in each source file notice.
      
      Replace CMake per-source copyright/license notice headers with a short
      description of the license and links to `Copyright.txt` and online information
      available from "https://cmake.org/licensing".  The online URL also handles
      cases of modules being copied out of our source into other projects, so we
      can drop our notices about replacing links with full license text.
      
      Run the `Utilities/Scripts/filter-notices.bash` script to perform the majority
      of the replacements mechanically.  Manually fix up shebang lines and trailing
      newlines in a few files.  Manually update the notices in a few files that the
      script does not handle.
      86578ecc
  17. 04 Sep, 2016 1 commit
  18. 09 Jun, 2016 1 commit
  19. 06 Jun, 2016 1 commit
  20. 03 Jun, 2016 1 commit
  21. 01 Jun, 2016 1 commit
  22. 16 May, 2016 1 commit
    • Kitware Robot's avatar
      Revise C++ coding style using clang-format · d9fd2f54
      Kitware Robot authored
      Run the `Utilities/Scripts/clang-format.bash` script to update
      all our C++ code to a new style defined by `.clang-format`.
      Use `clang-format` version 3.8.
      
      * If you reached this commit for a line in `git blame`, re-run the blame
        operation starting at the parent of this commit to see older history
        for the content.
      
      * See the parent commit for instructions to rebase a change across this
        style transition commit.
      d9fd2f54
  23. 09 May, 2016 1 commit
    • Brad King's avatar
      Remove `//------...` horizontal separator comments · 0ac18d40
      Brad King authored
      Modern editors provide plenty of ways to visually separate functions.
      Drop the explicit comments that previously served this purpose.
      Use the following command to automate the change:
      
          $ git ls-files -z -- \
              "*.c" "*.cc" "*.cpp" "*.cxx" "*.h" "*.hh" "*.hpp" "*.hxx" |
            egrep -z -v "^Source/cmCommandArgumentLexer\." |
            egrep -z -v "^Source/cmCommandArgumentParser(\.y|\.cxx|Tokens\.h)" |
            egrep -z -v "^Source/cmDependsJavaLexer\." |
            egrep -z -v "^Source/cmDependsJavaParser(\.y|\.cxx|Tokens\.h)" |
            egrep -z -v "^Source/cmExprLexer\." |
            egrep -z -v "^Source/cmExprParser(\.y|\.cxx|Tokens\.h)" |
            egrep -z -v "^Source/cmFortranLexer\." |
            egrep -z -v "^Source/cmFortranParser(\.y|\.cxx|Tokens\.h)" |
            egrep -z -v "^Source/cmListFileLexer\." |
            egrep -z -v "^Source/cm_sha2" |
            egrep -z -v "^Source/(kwsys|CursesDialog/form)/" |
            egrep -z -v "^Utilities/(KW|cm).*/" |
            xargs -0 sed -i '/^\(\/\/---*\|\/\*---*\*\/\)$/ {d;}'
      
      This avoids modifying third-party sources and generated sources.
      0ac18d40
  24. 29 Apr, 2016 1 commit
    • Brad King's avatar
      Format include directive blocks and ordering with clang-format · e1c77472
      Brad King authored
      Sort include directives within each block (separated by a blank line) in
      lexicographic order (except to prioritize `sys/types.h` first).  First
      run `clang-format` with the config file:
      
          ---
          SortIncludes: false
          ...
      
      Commit the result temporarily.  Then run `clang-format` again with:
      
          ---
          SortIncludes: true
          IncludeCategories:
            - Regex:    'sys/types.h'
              Priority: -1
          ...
      
      Commit the result temporarily.  Start a new branch and cherry-pick the
      second commit.  Manually resolve conflicts to preserve indentation of
      re-ordered includes.  This cleans up the include ordering without
      changing any other style.
      
      Use the following command to run `clang-format`:
      
          $ git ls-files -z -- \
              '*.c' '*.cc' '*.cpp' '*.cxx' '*.h' '*.hh' '*.hpp' '*.hxx' |
            egrep -z -v '(Lexer|Parser|ParserHelper)\.' |
            egrep -z -v '^Source/cm_sha2' |
            egrep -z -v '^Source/(kwsys|CursesDialog/form)/' |
            egrep -z -v '^Utilities/(KW|cm).*/' |
            egrep -z -v '^Tests/Module/GenerateExportHeader' |
            egrep -z -v '^Tests/RunCMake/CommandLine/cmake_depends/test_UTF-16LE.h' |
            xargs -0 clang-format -i
      
      This selects source files that do not come from a third-party.
      Inspired-by: Daniel Pfeifer's avatarDaniel Pfeifer <daniel@pfeifer-mail.de>
      e1c77472
  25. 05 Oct, 2015 1 commit
  26. 20 Apr, 2015 1 commit
  27. 12 Jan, 2015 1 commit
  28. 11 Jan, 2015 1 commit
  29. 22 Dec, 2014 1 commit
  30. 08 Mar, 2014 2 commits
  31. 07 Jan, 2014 1 commit
  32. 31 Oct, 2012 1 commit
    • Clinton Stimpson's avatar
      PackageMaker: Enable postflight script in component mode (#12375) · 4374441f
      Clinton Stimpson authored
      Previously, setting CPACK_POSTFLIGHT_SCRIPT had no effect in
      component mode, when CPACK_COMPONENTS_ALL was set.
      
      In component mode, a .mpkg is created that contains multiple .pkg's.
      Because postflight scripts only work in a .pkg, add another .pkg to the
      .mpkg and put the postflight script in that.
      This is the same approach taken by the PackageMaker GUI when adding
      a postflight script to a metapackage.
      4374441f
  33. 13 Aug, 2012 1 commit
    • Kitware Robot's avatar
      Remove trailing whitespace from most CMake and C/C++ code · 7bbaa428
      Kitware Robot authored
      Our Git commit hooks disallow modification or addition of lines with
      trailing whitespace.  Wipe out all remnants of trailing whitespace
      everywhere except third-party code.
      
      Run the following shell code:
      
      git ls-files -z -- \
       bootstrap doxygen.config '*.readme' \
       '*.c' '*.cmake' '*.cpp' '*.cxx' \
       '*.el' '*.f' '*.f90' '*.h' '*.in' '*.in.l' '*.java' \
       '*.mm' '*.pike' '*.py' '*.txt' '*.vim' |
      egrep -z -v '^(Utilities/cm|Source/(kwsys|CursesDialog/form)/)' |
      egrep -z -v '^(Modules/CPack\..*\.in)' |
      xargs -0 sed -i 's/ \+$//'
      7bbaa428
  34. 13 Mar, 2012 1 commit
  35. 09 Mar, 2012 1 commit
    • David Cole's avatar
      CPack: Fix retry logic when calls to hdiutil fail · 05a76d53
      David Cole authored
      The long-standing sporadic failures of CPack tests on the Mac dashboards
      are caused by an occasional problem running hdiutil. To compensate for
      this, a retry loop was added in the code in a previous commit: a9fa71a4
      ... but the logic for breaking out of the retry loop was flawed, breaking
      out of the loop (and not retrying) when the hdiutil command returns an
      error instead of when it returns success.
      
      This commit fixes the flawed logic, bumps up the number of retries from
      4 to 10, and adds a half-second delay in between retries.
      
      The delay is specifically added in case a virus checker or spotlight indexer
      is temporarily causing the hdiutil failure by hanging onto a newly created
      file longer than hdiutil expects it to.
      
      As with all sporadically occurring issues, we'll never know if this is
      really fixed all the way. But I'll be happy even if we can only get it to
      happen just a bit less often.
      05a76d53
  36. 08 Mar, 2012 1 commit
    • David Cole's avatar
      Xcode: Detect new default locations of Xcode 4.3 bits and pieces (#12621) · 4693cf84
      David Cole authored
      Xcode 4.3 installs into "/Applications" by default, from the Mac App Store.
      
      Also, the paths to the available SDKs changed: they are now within the
      Xcode.app bundle.
      
      PackageMaker is installed as a separate program, and may be installed
      anywhere. It is not installed with Xcode 4.3 by default anymore.
      Download the "Auxiliary Tools for Xcode" to get PackageMaker.
      Put PackageMaker inside the Xcode.app bundle, in its nested Applications
      folder, or put it alongside Xcode in "/Applications" and CMake will find
      it.
      
      Update references to "find" paths: add new possible locations for finding
      Xcode.app and PackageMaker.app. Prefer the most recent version's locations
      first, but keep the old locations as fallback search paths, too.
      
      Thanks to all the contributors who provided and tested out various patches
      for fixing this issue. Especially, but by no means limited to:
      Francisco Requena Espí, Jamie Kirkpatrick and drfrogsplat.
      4693cf84
  37. 03 Feb, 2011 1 commit
  38. 11 Aug, 2010 1 commit
    • Eric Noulard's avatar
      CPack: Refactor API in order to handle multi-file packages · cd7b8a03
      Eric Noulard authored
      The multi-argument CompressFiles(...) method has been replace by the
      no-argument PackageFiles() method and 3 more member variables.  This
      will enable implemention of multi-package generators.  Now each specific
      generator (which overloads PackageFiles()) may decide to change the name
      and/or the number of generated package files.
      cd7b8a03
  39. 09 Oct, 2009 1 commit