1. 03 Aug, 2017 2 commits
  2. 07 Jul, 2017 2 commits
  3. 16 Jun, 2017 1 commit
    • Chuck Atkins's avatar
      FindHDF5: Fix parallel detection when primary compiler is an HDF5 wrapper · 8b9d8c4d
      Chuck Atkins authored
      This is covering a different use case where your primary compilers are
      HDF5 wrappers, as is the case when using the Cray Programming
      Environment. The existing code tries to query the compiler using options
      only available to h5cc and friends, which doesn't work when your wrapper
      is not h5cc, as is the case with the CrayPE. This change instead pulls
      strings out of a test binary when testing for "is your regular compiler
      an HDF5 wrapper" while the "query wrapper for options" is reserved for
      the "I found the hdf5 wrappers but they're not your main compiler" mode.
      8b9d8c4d
  4. 26 Apr, 2017 1 commit
  5. 21 Mar, 2017 3 commits
  6. 15 Mar, 2017 1 commit
  7. 06 Mar, 2017 2 commits
    • Kris Thielemans's avatar
      FindHDF5: set HDF5_<lang>_INCLUDE_DIRS in all cases · c6bef559
      Kris Thielemans authored
      In the case that we're using `find_path` to find the include directory,
      only the `_DIR` variable was set, while in all other cases only the
      `_DIRS` variable was set.  Set the `_DIRS` variable in all cases (while
      keeping `_DIR` as result of `find_path`).  Also document the `_DIRS`
      variable.
      
      Fixes: #16694
      c6bef559
    • Kris Thielemans's avatar
      FindHDF5: Restore `-D` in HDF5_DEFINITIONS · ea2a8dd2
      Kris Thielemans authored
      Changes in commit v3.8.0-rc1~7^2~5 (FindHDF5: Fix command-line parsing
      argument extraction order, 2017-02-02) accidentally dropped `-D` from
      preprocessor definition flags extracted from the HDF5 compiler wrappers.
      
      Fixes: #16693
      ea2a8dd2
  8. 01 Mar, 2017 7 commits
  9. 28 Feb, 2017 2 commits
  10. 17 Feb, 2017 2 commits
    • Brad King's avatar
      FindHDF5: Fix search for language-specific header file · 96d61393
      Brad King authored
      Refactoring in commit v3.6.0-rc1~85^2 (HDF5: Refactor the use of
      compiler wrappers, 2016-04-04) converted code of the form
      
          if(${LANGUAGE} MATCHES ...)
      
      to
      
          if(LANGUAGE MATCHES ...)
      
      However, `LANGUAGE` is a foreach() loop variable and not a normal
      variable so auto-dereference does not occur.  Restore the explicit `${}`
      syntax and use the new name of the loop variable that has changed since
      then too.
      
      Fixes: #16651
      96d61393
    • Brad King's avatar
      FindHDF5: Restore HDF5_<LANG>_INCLUDE_DIR advanced cache entry mark · 28bb68e3
      Brad King authored
      Refactoring in commit v3.6.0-rc1~72^2 (HDF5: Rework component searching
      to correctly find HL for all bindings, 2016-05-12) renamed the language
      loop variable used to construct the name of `HDF5_<LANG>_INCLUDE_DIR`
      but forgot to update it in the `mark_as_advanced` call.  Fix it now.
      
      Issue: #16651
      28bb68e3
  11. 03 Feb, 2017 6 commits
    • Brad King's avatar
      FindHDF5: Restore HDF5_INCLUDE_DIR in all code paths · cf0d8f1f
      Brad King authored
      This compatibility variable should be set no matter which method was
      used to find HDF5.  Even if `HDF5_INCLUDE_DIRS` was set by copying the
      `HDF5_INCLUDE_DIR` value from `hdf5-config.cmake` it will not hurt to
      copy the same value back.
      
      Issue: #16566
      cf0d8f1f
    • Brad King's avatar
      FindHDF5: Restore fallback to static libraries · 5564c017
      Brad King authored
      Since commit v3.6.1~6^2~2 (FindHDF5: Fix h5cc arg parsing to work with
      homebrew on Mac, 2016-07-11) we treated `HDF5_USE_STATIC_LIBRARIES` OFF
      as a requirement for shared libraries.  It is just supposed to be a
      preference.  Even if `HDF5_USE_STATIC_LIBRARIES` is not set we should
      still fall back to finding static libraries if shared libraries are not
      available.
      
      Issue: #16566
      5564c017
    • Brad King's avatar
      FindHDF5: Fix search with HDF5_ROOT · 4908969f
      Brad King authored
      Refactoring in commit v3.6.0-rc1~72^2 (HDF5: Rework component searching
      to correctly find HL for all bindings, 2016-05-12) turned off a large
      amount of its logic when HDF5_ROOT is set.  This caused use of the hdf5
      compiler wrapper to extract all needed libraries (e.g. z, dl as
      dependencies of hdf5 static libraries) to be skipped when using
      HDF5_ROOT.
      
      Fix the search logic to honor HDF5_ROOT in all code paths.  Restrict the
      search for hdf5-specific components to this root, but allow external
      libraries to be found anywhere.
      
      Fixes: #16566
      4908969f
    • Brad King's avatar
      FindHDF5: Use keywords in find_library calls · 77f6d22a
      Brad King authored
      Clarify the purpose of each argument.
      77f6d22a
    • Brad King's avatar
      FindHDF5: Initialize/finalize internal search options variable · 3d5ad723
      Brad King authored
      While at it, use a more private name.
      3d5ad723
    • Brad King's avatar
      FindHDF5: Fix command-line parsing argument extraction order · ae89967f
      Brad King authored
      Re-implement our internal `_HDF5_parse_compile_line` helper to process
      command line arguments all at once and in order.  Otherwise the
      libraries named by absolute path and those named by `-l` arguments are
      not kept in order.
      
      The new implementation will not handle separate arguments like
      `-I /path/to/include/dir` but I have not seen the HDF5 compiler
      wrappers produce this form.  If necessary the parsing loop can
      be extended with a state variable to keep track of such pairs.
      ae89967f
  12. 16 Jan, 2017 1 commit
  13. 02 Nov, 2016 1 commit
    • Brad King's avatar
      FindHDF5: Restore pre-3.6 behavior of finding only C by default · ff3ccc1f
      Brad King authored
      Refactoring in commit v3.6.0-rc1~72^2 (HDF5: Rework component searching
      to correctly find HL for all bindings, 2016-05-12) changed the default
      behavior from finding only the C bindings to finding everything for the
      enabled languages.  Restore the original behavior for compatibility and
      because many projects need only the C bindings.
      
      Closes: #16397
      ff3ccc1f
  14. 27 Sep, 2016 1 commit
    • Brad King's avatar
      Simplify CMake per-source license notices · 86578ecc
      Brad King authored
      Per-source copyright/license notice headers that spell out copyright holder
      names and years are hard to maintain and often out-of-date or plain wrong.
      Precise contributor information is already maintained automatically by the
      version control tool.  Ultimately it is the receiver of a file who is
      responsible for determining its licensing status, and per-source notices are
      merely a convenience.  Therefore it is simpler and more accurate for
      each source to have a generic notice of the license name and references to
      more detailed information on copyright holders and full license terms.
      
      Our `Copyright.txt` file now contains a list of Contributors whose names
      appeared source-level copyright notices.  It also references version control
      history for more precise information.  Therefore we no longer need to spell
      out the list of Contributors in each source file notice.
      
      Replace CMake per-source copyright/license notice headers with a short
      description of the license and links to `Copyright.txt` and online information
      available from "https://cmake.org/licensing".  The online URL also handles
      cases of modules being copied out of our source into other projects, so we
      can drop our notices about replacing links with full license text.
      
      Run the `Utilities/Scripts/filter-notices.bash` script to perform the majority
      of the replacements mechanically.  Manually fix up shebang lines and trailing
      newlines in a few files.  Manually update the notices in a few files that the
      script does not handle.
      86578ecc
  15. 02 Sep, 2016 2 commits
    • Brad King's avatar
      FindHDF5: Fix regression in finding hdf5hl_fortran · befe8648
      Brad King authored
      Refactoring in commit v3.6.0-rc1~72^2 (HDF5: Rework component searching
      to correctly find HL for all bindings, 2016-05-12) accidentally dropped
      the name `hdf5hl_fortran` from the list of library names and replaced it
      with `hdf5_hl_fortran`.  IIUC the latter name is when HDF5 is built with
      CMake and the former name is for other build systems.  Since this is the
      non-CMake code path, user the former name.
      
      Closes: #16233
      befe8648
    • Brad King's avatar
      FindHDF5: Fix regression in providing HDF5_IS_PARALLEL · b61eab24
      Brad King authored
      Since commit v3.6.0-rc1~85^2 (HDF5: Refactor the use of compiler
      wrappers, 2016-04-01) we have additional code paths that find HDF5 and
      suppress the original search logic.  Report HDF5_IS_PARALLEL from these
      other code paths too.
      
      Closes: #16257
      b61eab24
  16. 15 Aug, 2016 1 commit
  17. 02 Aug, 2016 1 commit
  18. 12 Jul, 2016 3 commits
  19. 24 Jun, 2016 1 commit