1. 03 Jul, 2019 1 commit
  2. 25 Jun, 2019 1 commit
  3. 08 May, 2019 1 commit
  4. 13 Dec, 2018 1 commit
    • Kyle Edwards's avatar
      CMakeParseArguments: Remove superfluous includes of CMakeParseArguments · 88b40744
      Kyle Edwards authored
      Because cmake_parse_arguments() has been implemented as a native
      command, there is no need to include(CMakeParseArguments) anymore.
      Its inclusion has been removed from several CMake modules.
      Tests/CMakeOnly/CMakeLists.txt has been changed to include the
      *building* CMake's copy of CMakeParseArguments rather than the
      *built* CMake's copy. This file included the *built* copy because
      when this file was introduced, CMake could still be built with versions
      that didn't supply cmake_parse_arguments(). Now, CMake requires 3.1 or
      greater, where cmake_parse_arguments() existed but was still in the
      form of a module, so we include it from the *building* CMake.
  5. 31 Oct, 2018 1 commit
    • Brad King's avatar
      FindProtobuf: Add missing link dependencies on threads · 03454b0d
      Brad King authored
      Protobuf headers have dependencies on threads.  On UNIX platforms this
      requires linking to a threads library.  We've long done this in the
      `Protobuf_LIBRARIES` result variable.  However, the imported targets
      added by commit v3.9.0-rc1~81^2~2 (FindProtobuf: add targets,
      2017-05-17) and commit v3.9.0-rc1~68^2 (FindProtobuf: Rename imported
      targets to match upstream names, 2017-05-22) were missing a dependency
      on threads.
      Add the dependency to the imported targets, and to the variables
      `Protobuf_LITE_LIBRARIES` and `Protobuf_PROTOC_LIBRARIES`.  While this
      did not seem to matter in practice for a long time, protobuf 3.6 throws
      exceptions in some cases when threads are missing.
      Fixes: #18533
  6. 22 Oct, 2018 1 commit
  7. 16 Jul, 2018 4 commits
  8. 06 Oct, 2017 1 commit
  9. 02 Oct, 2017 2 commits
    • Peter Mitrano's avatar
      FindProtobuf: add flag to allow descriptor files to be generated · 1299f4cc
      Peter Mitrano authored
      - The .desc files will be in the same folder as the generated .cc and .h files.
      - Paths to generate .desc files are stored in a variable passed in
      - This is only implemented for C++
      - Remove legacy ARGS
      - Add test that generates and uses C++ protobuf message
      - Add test that checks that the generated .desc file can be instantiated
        with DynamicMessageFactory
      - Add Help rst for new feature
    • Brad King's avatar
      FindProtobuf: Refactor custom command output listing · 4e91be95
      Brad King authored
      Reduce duplication by storing the custom command outputs in variables.
      Also, since custom command outputs are automatically marked as generated
      we do not need to do so explicitly.
  10. 12 Jul, 2017 1 commit
  11. 26 May, 2017 1 commit
  12. 22 May, 2017 1 commit
  13. 18 May, 2017 1 commit
  14. 06 Feb, 2017 1 commit
  15. 10 Oct, 2016 1 commit
  16. 07 Oct, 2016 1 commit
    • Martin Joly's avatar
      FindProtobuf: Fix protobuf_generate_*() to handle subdirs · 2b9dad69
      Martin Joly authored
      The change in commit v3.7.0-rc1~513^2 (FindProtobuf: fix
      protobuf_generate_*() to handle proto files in subdirs, 2016-06-09)
      incorrectly adds subdirectories to the path of the generated files when
      `*.proto` files are passed to `protobuf_generate_*` with subdirectories.
      This behavior is not correct when `PROTOBUF_GENERATE_CPP_APPEND_PATH` is
      True (default behavior) as `protoc` will generate output file in the
      current build directory.
  17. 27 Sep, 2016 1 commit
    • Brad King's avatar
      Simplify CMake per-source license notices · 86578ecc
      Brad King authored
      Per-source copyright/license notice headers that spell out copyright holder
      names and years are hard to maintain and often out-of-date or plain wrong.
      Precise contributor information is already maintained automatically by the
      version control tool.  Ultimately it is the receiver of a file who is
      responsible for determining its licensing status, and per-source notices are
      merely a convenience.  Therefore it is simpler and more accurate for
      each source to have a generic notice of the license name and references to
      more detailed information on copyright holders and full license terms.
      Our `Copyright.txt` file now contains a list of Contributors whose names
      appeared source-level copyright notices.  It also references version control
      history for more precise information.  Therefore we no longer need to spell
      out the list of Contributors in each source file notice.
      Replace CMake per-source copyright/license notice headers with a short
      description of the license and links to `Copyright.txt` and online information
      available from "https://cmake.org/licensing".  The online URL also handles
      cases of modules being copied out of our source into other projects, so we
      can drop our notices about replacing links with full license text.
      Run the `Utilities/Scripts/filter-notices.bash` script to perform the majority
      of the replacements mechanically.  Manually fix up shebang lines and trailing
      newlines in a few files.  Manually update the notices in a few files that the
      script does not handle.
  18. 02 Aug, 2016 1 commit
  19. 09 Jun, 2016 1 commit
  20. 07 Mar, 2016 1 commit
    • Antonio Perez Barrero's avatar
      FindProtobuf: Rename variables to match case of module name · a7b09e7f
      Antonio Perez Barrero authored
      Use recommended case for variable names. i.e. matching name of the
      module as passed to `find_package`.
      For backwards compatibility, the upper case versions of both input and
      output variables are used and defined when appropriate.  Skip this for
      the _FOUND variable because FPHSA already does it.  Skip this for the
      _VERSION variable because that was recently added and never available
      with the old name in a release of CMake.
  21. 16 Feb, 2016 1 commit
    • Antonio Perez Barrero's avatar
      FindProtobuf: check version · bb7a41ab
      Antonio Perez Barrero authored
      Check found libraries version to match user required version.
      Protobuf compiler executable version is checked to be aligned with found
      libraries, raising a warning message otherwise.
  22. 11 Feb, 2016 1 commit
  23. 11 Dec, 2015 1 commit
  24. 15 Sep, 2015 1 commit
  25. 11 Aug, 2015 1 commit
  26. 06 Nov, 2014 1 commit
  27. 18 Sep, 2014 1 commit
    • Michael Hanselmann's avatar
      FindProtobuf: Make outputs depend on protoc executable · e380d7c5
      Michael Hanselmann authored
      After updating from Protocol Buffers 2.5.0 to 2.6.0 compilation of the
      generated source failed: "This file was generated by an older version of
      protoc which is incompatible with your Protocol Buffer headers. Please
      regenerate this file with a newer version of protoc.".
      Turns out the source and headers generated by way of
      FindProtobuf.cmake:PROTOBUF_GENERATE_CPP aren't updated. Adding a
      dependency on the compiler executable fixes this issue.
  28. 15 Oct, 2013 1 commit
  29. 24 May, 2013 1 commit
    • Matthew Woehlke's avatar
      FindProtobuf: also find pthread · 8961c4b6
      Matthew Woehlke authored
      Modify FindProtobuf.cmake to find the pthread library on UNIX platforms,
      and to add the same to PROTOBUF_LIBRARIES, as this is a link dependency
      of libraries using the protobuf headers.
  30. 13 Aug, 2012 2 commits
    • Kitware Robot's avatar
      Remove CMake-language block-end command arguments · 9db31162
      Kitware Robot authored
      Ancient versions of CMake required else(), endif(), and similar block
      termination commands to have arguments matching the command starting the
      block.  This is no longer the preferred style.
      Run the following shell code:
      for c in else endif endforeach endfunction endmacro endwhile; do
          echo 's/\b'"$c"'\(\s*\)(.\+)/'"$c"'\1()/'
      done >convert.sed &&
      git ls-files -z -- bootstrap '*.cmake' '*.cmake.in' '*CMakeLists.txt' |
      egrep -z -v '^(Utilities/cm|Source/kwsys/)' |
      egrep -z -v 'Tests/CMakeTests/While-Endwhile-' |
      xargs -0 sed -i -f convert.sed &&
      rm convert.sed
    • Kitware Robot's avatar
      Remove trailing whitespace from most CMake and C/C++ code · 7bbaa428
      Kitware Robot authored
      Our Git commit hooks disallow modification or addition of lines with
      trailing whitespace.  Wipe out all remnants of trailing whitespace
      everywhere except third-party code.
      Run the following shell code:
      git ls-files -z -- \
       bootstrap doxygen.config '*.readme' \
       '*.c' '*.cmake' '*.cpp' '*.cxx' \
       '*.el' '*.f' '*.f90' '*.h' '*.in' '*.in.l' '*.java' \
       '*.mm' '*.pike' '*.py' '*.txt' '*.vim' |
      egrep -z -v '^(Utilities/cm|Source/(kwsys|CursesDialog/form)/)' |
      egrep -z -v '^(Modules/CPack\..*\.in)' |
      xargs -0 sed -i 's/ \+$//'
  31. 03 Jan, 2012 1 commit
  32. 18 Dec, 2011 1 commit
  33. 12 Oct, 2011 1 commit
  34. 14 Jun, 2011 1 commit
  35. 26 May, 2011 1 commit