1. 23 Apr, 2019 1 commit
  2. 07 Feb, 2019 2 commits
  3. 06 Dec, 2018 1 commit
    • Baptiste Mouginot's avatar
      FindHDF5: Fix search for static hdf5_hl on Windows · 4e174e09
      Baptiste Mouginot authored
      The change in commit v3.10.0-rc1~411^2~1 (FindHDF5: Add support for
      HDF5_USE_STATIC_LIBRARIES on Windows, 2017-07-03) accidentally left
      out a `lib` prefix on the static library name of `hdf5_hl`.  It was
      done correctly already for the main `hdf5` library.
      4e174e09
  4. 22 Oct, 2018 1 commit
  5. 08 Nov, 2017 1 commit
    • Axel Huebl's avatar
      FindHDF5: Fix H5_VERSION on Patch in C · a6abb6c8
      Axel Huebl authored
      Fix a typo from commit v3.6.0-rc1~85^2 (HDF5: Refactor the use of
      compiler wrappers, 2016-04-04) that accidentally used the HDF5 C++
      version (which could be empty) while detecting the C patch version.
      The detection failed for patch releases, such as `1.10.0-patch1`
      becoming `.1` instead of `1.10.0.1`.
      a6abb6c8
  6. 03 Nov, 2017 1 commit
    • luz.paz's avatar
      Fix trivial typos in text · 777e87ae
      luz.paz authored
      Some are user facing.
      
      Found using
      
          codespell -q 3 --skip="./Utilities" -I .cmake-whitelist.txt`
      
      whereby the whitelist contained:
      
          ans
          dum
          helpfull
          emmited
          emmitted
          buil
          iff
          isnt
          nto
          ot
          pathes
          substract
          te
          todays
          upto
          whitespaces
      777e87ae
  7. 03 Aug, 2017 4 commits
  8. 07 Jul, 2017 2 commits
  9. 16 Jun, 2017 1 commit
    • Chuck Atkins's avatar
      FindHDF5: Fix parallel detection when primary compiler is an HDF5 wrapper · 8b9d8c4d
      Chuck Atkins authored
      This is covering a different use case where your primary compilers are
      HDF5 wrappers, as is the case when using the Cray Programming
      Environment. The existing code tries to query the compiler using options
      only available to h5cc and friends, which doesn't work when your wrapper
      is not h5cc, as is the case with the CrayPE. This change instead pulls
      strings out of a test binary when testing for "is your regular compiler
      an HDF5 wrapper" while the "query wrapper for options" is reserved for
      the "I found the hdf5 wrappers but they're not your main compiler" mode.
      8b9d8c4d
  10. 26 Apr, 2017 1 commit
  11. 21 Mar, 2017 3 commits
  12. 15 Mar, 2017 1 commit
  13. 06 Mar, 2017 2 commits
    • Kris Thielemans's avatar
      FindHDF5: set HDF5_<lang>_INCLUDE_DIRS in all cases · c6bef559
      Kris Thielemans authored
      In the case that we're using `find_path` to find the include directory,
      only the `_DIR` variable was set, while in all other cases only the
      `_DIRS` variable was set.  Set the `_DIRS` variable in all cases (while
      keeping `_DIR` as result of `find_path`).  Also document the `_DIRS`
      variable.
      
      Fixes: #16694
      c6bef559
    • Kris Thielemans's avatar
      FindHDF5: Restore `-D` in HDF5_DEFINITIONS · ea2a8dd2
      Kris Thielemans authored
      Changes in commit v3.8.0-rc1~7^2~5 (FindHDF5: Fix command-line parsing
      argument extraction order, 2017-02-02) accidentally dropped `-D` from
      preprocessor definition flags extracted from the HDF5 compiler wrappers.
      
      Fixes: #16693
      ea2a8dd2
  14. 01 Mar, 2017 7 commits
  15. 28 Feb, 2017 2 commits
  16. 17 Feb, 2017 2 commits
    • Brad King's avatar
      FindHDF5: Fix search for language-specific header file · 96d61393
      Brad King authored
      Refactoring in commit v3.6.0-rc1~85^2 (HDF5: Refactor the use of
      compiler wrappers, 2016-04-04) converted code of the form
      
          if(${LANGUAGE} MATCHES ...)
      
      to
      
          if(LANGUAGE MATCHES ...)
      
      However, `LANGUAGE` is a foreach() loop variable and not a normal
      variable so auto-dereference does not occur.  Restore the explicit `${}`
      syntax and use the new name of the loop variable that has changed since
      then too.
      
      Fixes: #16651
      96d61393
    • Brad King's avatar
      FindHDF5: Restore HDF5_<LANG>_INCLUDE_DIR advanced cache entry mark · 28bb68e3
      Brad King authored
      Refactoring in commit v3.6.0-rc1~72^2 (HDF5: Rework component searching
      to correctly find HL for all bindings, 2016-05-12) renamed the language
      loop variable used to construct the name of `HDF5_<LANG>_INCLUDE_DIR`
      but forgot to update it in the `mark_as_advanced` call.  Fix it now.
      
      Issue: #16651
      28bb68e3
  17. 03 Feb, 2017 6 commits
    • Brad King's avatar
      FindHDF5: Restore HDF5_INCLUDE_DIR in all code paths · cf0d8f1f
      Brad King authored
      This compatibility variable should be set no matter which method was
      used to find HDF5.  Even if `HDF5_INCLUDE_DIRS` was set by copying the
      `HDF5_INCLUDE_DIR` value from `hdf5-config.cmake` it will not hurt to
      copy the same value back.
      
      Issue: #16566
      cf0d8f1f
    • Brad King's avatar
      FindHDF5: Restore fallback to static libraries · 5564c017
      Brad King authored
      Since commit v3.6.1~6^2~2 (FindHDF5: Fix h5cc arg parsing to work with
      homebrew on Mac, 2016-07-11) we treated `HDF5_USE_STATIC_LIBRARIES` OFF
      as a requirement for shared libraries.  It is just supposed to be a
      preference.  Even if `HDF5_USE_STATIC_LIBRARIES` is not set we should
      still fall back to finding static libraries if shared libraries are not
      available.
      
      Issue: #16566
      5564c017
    • Brad King's avatar
      FindHDF5: Fix search with HDF5_ROOT · 4908969f
      Brad King authored
      Refactoring in commit v3.6.0-rc1~72^2 (HDF5: Rework component searching
      to correctly find HL for all bindings, 2016-05-12) turned off a large
      amount of its logic when HDF5_ROOT is set.  This caused use of the hdf5
      compiler wrapper to extract all needed libraries (e.g. z, dl as
      dependencies of hdf5 static libraries) to be skipped when using
      HDF5_ROOT.
      
      Fix the search logic to honor HDF5_ROOT in all code paths.  Restrict the
      search for hdf5-specific components to this root, but allow external
      libraries to be found anywhere.
      
      Fixes: #16566
      4908969f
    • Brad King's avatar
      FindHDF5: Use keywords in find_library calls · 77f6d22a
      Brad King authored
      Clarify the purpose of each argument.
      77f6d22a
    • Brad King's avatar
      FindHDF5: Initialize/finalize internal search options variable · 3d5ad723
      Brad King authored
      While at it, use a more private name.
      3d5ad723
    • Brad King's avatar
      FindHDF5: Fix command-line parsing argument extraction order · ae89967f
      Brad King authored
      Re-implement our internal `_HDF5_parse_compile_line` helper to process
      command line arguments all at once and in order.  Otherwise the
      libraries named by absolute path and those named by `-l` arguments are
      not kept in order.
      
      The new implementation will not handle separate arguments like
      `-I /path/to/include/dir` but I have not seen the HDF5 compiler
      wrappers produce this form.  If necessary the parsing loop can
      be extended with a state variable to keep track of such pairs.
      ae89967f
  18. 16 Jan, 2017 1 commit
  19. 02 Nov, 2016 1 commit
    • Brad King's avatar
      FindHDF5: Restore pre-3.6 behavior of finding only C by default · ff3ccc1f
      Brad King authored
      Refactoring in commit v3.6.0-rc1~72^2 (HDF5: Rework component searching
      to correctly find HL for all bindings, 2016-05-12) changed the default
      behavior from finding only the C bindings to finding everything for the
      enabled languages.  Restore the original behavior for compatibility and
      because many projects need only the C bindings.
      
      Closes: #16397
      ff3ccc1f