1. 19 Oct, 2016 2 commits
  2. 27 Sep, 2016 1 commit
    • Brad King's avatar
      Simplify CMake per-source license notices · 86578ecc
      Brad King authored
      Per-source copyright/license notice headers that spell out copyright holder
      names and years are hard to maintain and often out-of-date or plain wrong.
      Precise contributor information is already maintained automatically by the
      version control tool.  Ultimately it is the receiver of a file who is
      responsible for determining its licensing status, and per-source notices are
      merely a convenience.  Therefore it is simpler and more accurate for
      each source to have a generic notice of the license name and references to
      more detailed information on copyright holders and full license terms.
      
      Our `Copyright.txt` file now contains a list of Contributors whose names
      appeared source-level copyright notices.  It also references version control
      history for more precise information.  Therefore we no longer need to spell
      out the list of Contributors in each source file notice.
      
      Replace CMake per-source copyright/license notice headers with a short
      description of the license and links to `Copyright.txt` and online information
      available from "https://cmake.org/licensing".  The online URL also handles
      cases of modules being copied out of our source into other projects, so we
      can drop our notices about replacing links with full license text.
      
      Run the `Utilities/Scripts/filter-notices.bash` script to perform the majority
      of the replacements mechanically.  Manually fix up shebang lines and trailing
      newlines in a few files.  Manually update the notices in a few files that the
      script does not handle.
      86578ecc
  3. 23 Aug, 2016 1 commit
  4. 28 Jun, 2016 1 commit
  5. 16 May, 2016 1 commit
    • Kitware Robot's avatar
      Revise C++ coding style using clang-format · d9fd2f54
      Kitware Robot authored
      Run the `Utilities/Scripts/clang-format.bash` script to update
      all our C++ code to a new style defined by `.clang-format`.
      Use `clang-format` version 3.8.
      
      * If you reached this commit for a line in `git blame`, re-run the blame
        operation starting at the parent of this commit to see older history
        for the content.
      
      * See the parent commit for instructions to rebase a change across this
        style transition commit.
      d9fd2f54
  6. 09 May, 2016 1 commit
    • Brad King's avatar
      Remove `//------...` horizontal separator comments · 0ac18d40
      Brad King authored
      Modern editors provide plenty of ways to visually separate functions.
      Drop the explicit comments that previously served this purpose.
      Use the following command to automate the change:
      
          $ git ls-files -z -- \
              "*.c" "*.cc" "*.cpp" "*.cxx" "*.h" "*.hh" "*.hpp" "*.hxx" |
            egrep -z -v "^Source/cmCommandArgumentLexer\." |
            egrep -z -v "^Source/cmCommandArgumentParser(\.y|\.cxx|Tokens\.h)" |
            egrep -z -v "^Source/cmDependsJavaLexer\." |
            egrep -z -v "^Source/cmDependsJavaParser(\.y|\.cxx|Tokens\.h)" |
            egrep -z -v "^Source/cmExprLexer\." |
            egrep -z -v "^Source/cmExprParser(\.y|\.cxx|Tokens\.h)" |
            egrep -z -v "^Source/cmFortranLexer\." |
            egrep -z -v "^Source/cmFortranParser(\.y|\.cxx|Tokens\.h)" |
            egrep -z -v "^Source/cmListFileLexer\." |
            egrep -z -v "^Source/cm_sha2" |
            egrep -z -v "^Source/(kwsys|CursesDialog/form)/" |
            egrep -z -v "^Utilities/(KW|cm).*/" |
            xargs -0 sed -i '/^\(\/\/---*\|\/\*---*\*\/\)$/ {d;}'
      
      This avoids modifying third-party sources and generated sources.
      0ac18d40
  7. 29 Apr, 2016 1 commit
    • Brad King's avatar
      Format include directive blocks and ordering with clang-format · e1c77472
      Brad King authored
      Sort include directives within each block (separated by a blank line) in
      lexicographic order (except to prioritize `sys/types.h` first).  First
      run `clang-format` with the config file:
      
          ---
          SortIncludes: false
          ...
      
      Commit the result temporarily.  Then run `clang-format` again with:
      
          ---
          SortIncludes: true
          IncludeCategories:
            - Regex:    'sys/types.h'
              Priority: -1
          ...
      
      Commit the result temporarily.  Start a new branch and cherry-pick the
      second commit.  Manually resolve conflicts to preserve indentation of
      re-ordered includes.  This cleans up the include ordering without
      changing any other style.
      
      Use the following command to run `clang-format`:
      
          $ git ls-files -z -- \
              '*.c' '*.cc' '*.cpp' '*.cxx' '*.h' '*.hh' '*.hpp' '*.hxx' |
            egrep -z -v '(Lexer|Parser|ParserHelper)\.' |
            egrep -z -v '^Source/cm_sha2' |
            egrep -z -v '^Source/(kwsys|CursesDialog/form)/' |
            egrep -z -v '^Utilities/(KW|cm).*/' |
            egrep -z -v '^Tests/Module/GenerateExportHeader' |
            egrep -z -v '^Tests/RunCMake/CommandLine/cmake_depends/test_UTF-16LE.h' |
            xargs -0 clang-format -i
      
      This selects source files that do not come from a third-party.
      Inspired-by: Daniel Pfeifer's avatarDaniel Pfeifer <daniel@pfeifer-mail.de>
      e1c77472
  8. 04 Feb, 2016 1 commit
  9. 20 Oct, 2015 1 commit
  10. 14 Oct, 2015 2 commits
    • Stephen Kelly's avatar
      cmState: Move TargetType enum from cmTarget. · eac15298
      Stephen Kelly authored
      Mostly automated:
      
       values=( "EXECUTABLE" "STATIC_LIBRARY" "SHARED_LIBRARY" "MODULE_LIBRARY" "OBJECT_LIBRARY" "UTILITY" "GLOBAL_TARGET" "INTERFACE_LIBRARY" "UNKNOWN_LIBRARY" "TargetType")
       for i in "${values[@]}"; do     git grep -l cmTarget::$i | xargs sed -i "s|cmTarget::$i|cmState::$i|g"; done
      eac15298
    • Stephen Kelly's avatar
      cmTarget: Move link type enum out. · 482b3811
      Stephen Kelly authored
      Remove a reason for generate time code to depend on the cmTarget header/type.
      482b3811
  11. 12 Oct, 2015 3 commits
  12. 10 Oct, 2015 2 commits
  13. 26 Aug, 2015 4 commits
  14. 25 Aug, 2015 1 commit
  15. 20 Aug, 2015 1 commit
  16. 05 Aug, 2015 1 commit
  17. 03 May, 2015 1 commit
  18. 10 Mar, 2015 1 commit
  19. 20 Feb, 2015 1 commit
  20. 06 Feb, 2015 1 commit
  21. 05 Feb, 2015 1 commit
  22. 18 Jan, 2015 1 commit
  23. 13 Jan, 2015 1 commit
  24. 11 Jan, 2015 2 commits
  25. 18 Dec, 2014 1 commit
  26. 12 Dec, 2014 1 commit
    • Chuck Atkins's avatar
      Misc. fixes for the Oracle / Sun compiler. · 97b65f81
      Chuck Atkins authored
      A few pieces of code have some ambiguous type deduction that seems to
      resolve correctly for most compilers but not for the Oracle compiler.
      This makes those few instances more explicit.
      97b65f81
  27. 10 Nov, 2014 1 commit
    • Daniele E. Domenichelli's avatar
      Fix link line order when shared libraries are de-duplicated · 4db31095
      Daniele E. Domenichelli authored
      Since commit v3.1.0-rc1~227^2~1 (De-duplicate shared library targets in
      generated link lines, 2014-07-30) we de-duplicate shared library targets
      on the link line.  However, some toolchains will fail linking if an
      executable is linking to a shared library that is not used directly and
      a static library that depends on the shared one.  The linker may not
      keep the reference to the shared library the first time and then the
      symbols needed by the static library may not be found.
      
      Fix this by reversing the direction of the for loop that removes the
      duplicate shared libraries, in order to ensure that the last occurrence
      of the library is left instead of the first one.
      
      Extend Tests/Dependency with a case covering this behavior.  Create an
      executable that links to a shared library and a static library but only
      needs the shared library as a dependency of the static library.
      
      Co-Author: Brad King <brad.king@kitware.com>
      4db31095
  28. 30 Jul, 2014 1 commit
  29. 07 Jul, 2014 1 commit
  30. 23 Jun, 2014 2 commits
    • Brad King's avatar
      cmTarget: Lookup targets in LinkInterface and LinkImplementation · d912220e
      Brad King authored
      Instead of storing just the string names in these structures, lookup any
      target associated with each item and store its cmTarget pointer.  Use
      the cmLinkItem class to hold the name and pointer together.  Update
      client sites to use the pre-stored lookup result instead of looking up
      the target name again.
      
      Create a cmTarget::LookupLinkItems helper method to handle the lookup.
      Since lookups are now moving from cmComputeLinkDepends::AddLinkEntries
      to cmTarget::LookupLinkItems, move use of CheckCMP0004 to the latter.
      This drops use of CheckCMP0004 from entries added for _LIB_DEPENDS
      variables by cmComputeLinkDepends::AddVarLinkEntries, but I do not
      think that use was intentional originally anyway.
      d912220e
    • Brad King's avatar
      cmTarget: Add method to lookup other targets in a target's scope · 069d60fe
      Brad King authored
      Move the main implementation of cmComputeLinkDepends::FindTargetToLink
      into cmTarget.
      069d60fe