1. 05 Apr, 2018 1 commit
    • jrp2014's avatar
      Add in-class initialization of some members · b0676cc5
      jrp2014 authored
      Several class constructors leave members uninitialized.  The members are
      initialized before use in methods, but it is clearer and less
      error-prone to initialize them at their definition site.
      b0676cc5
  2. 26 Oct, 2017 1 commit
    • Deniz Bahadir's avatar
      Teach target_* commands to set INTERFACE properties of IMPORTED targets · fe4b25ec
      Deniz Bahadir authored
      Now, several `INTERFACE_*` properties can be set on `IMPORTED` targets,
      not only via `set_property` and `set_target_properties` but also via
      `target_compile_definitions`, `target_compile_features`,
      `target_compile_options`, `target_include_directories`, `target_sources`
      and `target_link_libraries`.
      
      Fixes: #15689
      Issue: #17197
      fe4b25ec
  3. 11 Apr, 2017 1 commit
    • Daniel Pfeifer's avatar
      Use quotes for non-system includes · 1d829c86
      Daniel Pfeifer authored
      Automate with:
      
      git grep -l '#include <cm_' -- Source \
        | xargs sed -i 's/#include <\(cm_.*\)>/#include "\1"/g'
      
      git grep -l '#include <cmsys/' -- Source \
        | xargs sed -i 's/#include <\(cmsys\/.*\)>/#include "\1"/g'
      
      git grep -l '#include <cm[A-Z]' -- Source \
        | xargs sed -i 's/#include <\(cm[A-Z].*\)>/#include "\1"/g'
      1d829c86
  4. 08 Nov, 2016 1 commit
  5. 22 Oct, 2016 1 commit
  6. 27 Sep, 2016 1 commit
    • Brad King's avatar
      Simplify CMake per-source license notices · 86578ecc
      Brad King authored
      Per-source copyright/license notice headers that spell out copyright holder
      names and years are hard to maintain and often out-of-date or plain wrong.
      Precise contributor information is already maintained automatically by the
      version control tool.  Ultimately it is the receiver of a file who is
      responsible for determining its licensing status, and per-source notices are
      merely a convenience.  Therefore it is simpler and more accurate for
      each source to have a generic notice of the license name and references to
      more detailed information on copyright holders and full license terms.
      
      Our `Copyright.txt` file now contains a list of Contributors whose names
      appeared source-level copyright notices.  It also references version control
      history for more precise information.  Therefore we no longer need to spell
      out the list of Contributors in each source file notice.
      
      Replace CMake per-source copyright/license notice headers with a short
      description of the license and links to `Copyright.txt` and online information
      available from "https://cmake.org/licensing".  The online URL also handles
      cases of modules being copied out of our source into other projects, so we
      can drop our notices about replacing links with full license text.
      
      Run the `Utilities/Scripts/filter-notices.bash` script to perform the majority
      of the replacements mechanically.  Manually fix up shebang lines and trailing
      newlines in a few files.  Manually update the notices in a few files that the
      script does not handle.
      86578ecc
  7. 16 May, 2016 1 commit
    • Kitware Robot's avatar
      Revise C++ coding style using clang-format · d9fd2f54
      Kitware Robot authored
      Run the `Utilities/Scripts/clang-format.bash` script to update
      all our C++ code to a new style defined by `.clang-format`.
      Use `clang-format` version 3.8.
      
      * If you reached this commit for a line in `git blame`, re-run the blame
        operation starting at the parent of this commit to see older history
        for the content.
      
      * See the parent commit for instructions to rebase a change across this
        style transition commit.
      d9fd2f54
  8. 09 May, 2016 1 commit
    • Brad King's avatar
      Remove `//------...` horizontal separator comments · 0ac18d40
      Brad King authored
      Modern editors provide plenty of ways to visually separate functions.
      Drop the explicit comments that previously served this purpose.
      Use the following command to automate the change:
      
          $ git ls-files -z -- \
              "*.c" "*.cc" "*.cpp" "*.cxx" "*.h" "*.hh" "*.hpp" "*.hxx" |
            egrep -z -v "^Source/cmCommandArgumentLexer\." |
            egrep -z -v "^Source/cmCommandArgumentParser(\.y|\.cxx|Tokens\.h)" |
            egrep -z -v "^Source/cmDependsJavaLexer\." |
            egrep -z -v "^Source/cmDependsJavaParser(\.y|\.cxx|Tokens\.h)" |
            egrep -z -v "^Source/cmExprLexer\." |
            egrep -z -v "^Source/cmExprParser(\.y|\.cxx|Tokens\.h)" |
            egrep -z -v "^Source/cmFortranLexer\." |
            egrep -z -v "^Source/cmFortranParser(\.y|\.cxx|Tokens\.h)" |
            egrep -z -v "^Source/cmListFileLexer\." |
            egrep -z -v "^Source/cm_sha2" |
            egrep -z -v "^Source/(kwsys|CursesDialog/form)/" |
            egrep -z -v "^Utilities/(KW|cm).*/" |
            xargs -0 sed -i '/^\(\/\/---*\|\/\*---*\*\/\)$/ {d;}'
      
      This avoids modifying third-party sources and generated sources.
      0ac18d40
  9. 07 Apr, 2014 1 commit
  10. 08 Mar, 2014 1 commit
  11. 16 Oct, 2013 1 commit
    • Brad King's avatar
      Drop builtin command documentation · e33d8d2d
      Brad King authored
      Drop all GetTerseDocumentation and GetFullDocumentation methods from
      commands.  The command documentation is now in Help/command/*.rst files.
      e33d8d2d
  12. 02 Jul, 2013 2 commits
  13. 31 Jan, 2013 1 commit
    • Brad King's avatar
      Fix use of cmTypeMacro in new command classes · 9397270d
      Brad King authored
      Both commit 8a37ebec (Add the target_include_directories command,
      2013-01-01) and commit fc61a7a7 (Add the target_compile_definitions
      command, 2013-01-08) added command implementations deriving from the new
      cmTargetPropCommandBase class.  Fix cmTypeMacro declarations of the
      inheritance relationship.
      9397270d
  14. 29 Jan, 2013 3 commits
  15. 21 Jan, 2013 1 commit
    • Stephen Kelly's avatar
      Disallow porcelain to populate includes and defines of IMPORTED targets. · b98d14d4
      Stephen Kelly authored
      With similar reasoning to the parent commit, as downstreams, we can't
      determine what $<CONFIG> generator expressions would be appropriate.
      
      Upstream would have populated the INTERFACE_INCLUDE_DIRECTORIES with
      config-specific generator expressions, possibly appropriate for
      their DEBUG_CONFIGURATIONS. In theory, if we would add include
      directories for a DEBUG intent, we would have to match the upstream
      configurations for that.
      
      Rather than attempting to discover the appropriate configurations
      at this time, simplify the feature instead. The use of IMPORTED targets
      with these commands could still be added in the future if targets
      would export their DEBUG_CONFIGURATIONS somehow.
      b98d14d4
  16. 13 Jan, 2013 1 commit
  17. 10 Jan, 2013 1 commit