1. 18 Aug, 2019 1 commit
  2. 14 Aug, 2019 1 commit
  3. 24 Jul, 2019 1 commit
    • Sebastian Holtermann's avatar
      cmMakefile: Let AddDefinition accept a value as cm::string_view · e91bfe44
      Sebastian Holtermann authored
      This changes `cmMakefile::AddDefinition` to take a `cm::string_view` as value
      argument instead of a `const char *`.
      
      Benefits are:
      - `std::string` can be passed to `cmMakefile::AddDefinition` directly without
        the `c_str()` plus string length recomputation fallback.
      - Lengths of literals passed to `cmMakefile::AddDefinition` can be computed at
        compile time.
      
      In various sources uses of `cmMakefile::AddDefinition` are adapted to avoid
      `std::string::c_str` calls and the `std::string` is passed directly.
      Uses of `cmMakefile::AddDefinition`, where a `nullptr` `const char*` might
      be passed to `cmMakefile::AddDefinition` are extended with `nullptr` checks.
      e91bfe44
  4. 15 May, 2019 1 commit
  5. 21 Feb, 2019 1 commit
  6. 20 Feb, 2019 1 commit
  7. 07 Feb, 2019 1 commit
  8. 06 Feb, 2019 1 commit
  9. 23 Jan, 2019 1 commit
  10. 21 Jan, 2019 1 commit
  11. 17 Jan, 2019 1 commit
  12. 16 Jan, 2019 1 commit
  13. 01 Dec, 2018 1 commit
  14. 31 Jan, 2018 1 commit
    • Pavel Solodovnikov's avatar
      Reduce raw string pointers usage. · 653b8946
      Pavel Solodovnikov authored
      * Change some functions to take `std::string` instead of
        `const char*` in the following classes: `cmMakeFile`, `cmake`,
        `cmCoreTryCompile`, `cmSystemTools`,  `cmState`, `cmLocalGenerator`
        and a few others.
      * Greatly reduce using of `const char*` overloads for
        `cmSystemTools::MakeDirectory` and `cmSystemTools::RelativePath`.
      * Remove many redundant `c_str()` conversions throughout the code.
      653b8946
  15. 23 Jan, 2018 1 commit
  16. 08 Oct, 2017 1 commit
  17. 15 Sep, 2017 1 commit
  18. 24 Aug, 2017 1 commit
  19. 11 Apr, 2017 1 commit
    • Daniel Pfeifer's avatar
      Use quotes for non-system includes · 1d829c86
      Daniel Pfeifer authored
      Automate with:
      
      git grep -l '#include <cm_' -- Source \
        | xargs sed -i 's/#include <\(cm_.*\)>/#include "\1"/g'
      
      git grep -l '#include <cmsys/' -- Source \
        | xargs sed -i 's/#include <\(cmsys\/.*\)>/#include "\1"/g'
      
      git grep -l '#include <cm[A-Z]' -- Source \
        | xargs sed -i 's/#include <\(cm[A-Z].*\)>/#include "\1"/g'
      1d829c86
  20. 30 Oct, 2016 1 commit
  21. 26 Oct, 2016 1 commit
  22. 21 Oct, 2016 1 commit
  23. 19 Oct, 2016 1 commit
  24. 27 Sep, 2016 1 commit
    • Brad King's avatar
      Simplify CMake per-source license notices · 86578ecc
      Brad King authored
      Per-source copyright/license notice headers that spell out copyright holder
      names and years are hard to maintain and often out-of-date or plain wrong.
      Precise contributor information is already maintained automatically by the
      version control tool.  Ultimately it is the receiver of a file who is
      responsible for determining its licensing status, and per-source notices are
      merely a convenience.  Therefore it is simpler and more accurate for
      each source to have a generic notice of the license name and references to
      more detailed information on copyright holders and full license terms.
      
      Our `Copyright.txt` file now contains a list of Contributors whose names
      appeared source-level copyright notices.  It also references version control
      history for more precise information.  Therefore we no longer need to spell
      out the list of Contributors in each source file notice.
      
      Replace CMake per-source copyright/license notice headers with a short
      description of the license and links to `Copyright.txt` and online information
      available from "https://cmake.org/licensing".  The online URL also handles
      cases of modules being copied out of our source into other projects, so we
      can drop our notices about replacing links with full license text.
      
      Run the `Utilities/Scripts/filter-notices.bash` script to perform the majority
      of the replacements mechanically.  Manually fix up shebang lines and trailing
      newlines in a few files.  Manually update the notices in a few files that the
      script does not handle.
      86578ecc
  25. 28 Jun, 2016 1 commit
  26. 16 May, 2016 1 commit
    • Kitware Robot's avatar
      Revise C++ coding style using clang-format · d9fd2f54
      Kitware Robot authored
      Run the `Utilities/Scripts/clang-format.bash` script to update
      all our C++ code to a new style defined by `.clang-format`.
      Use `clang-format` version 3.8.
      
      * If you reached this commit for a line in `git blame`, re-run the blame
        operation starting at the parent of this commit to see older history
        for the content.
      
      * See the parent commit for instructions to rebase a change across this
        style transition commit.
      d9fd2f54
  27. 06 May, 2016 1 commit
    • Brad King's avatar
      Isolate formatted streaming blocks with clang-format off/on · 64b55203
      Brad King authored
      The clang-format tool can do a good job formatting most code, but
      well-organized streaming blocks are best left manually formatted.
      
      Find blocks of the form
      
          os <<
            "...\n"
            "...\n"
            ;
      
      using the command
      
          $ git ls-files -z -- Source |
            egrep -v -z '^Source/kwsys/' |
            xargs -0 pcregrep -M --color=always -B 1 -A 1 -n \
              '<<[^\n]*\n(^ *("[^\n]*("|<<|;)$|;)\n){2,}'
      
      Find blocks of the form
      
          os << "...\n"
             << "...\n"
             << "...\n";
      
      using the command
      
          $ git ls-files -z -- Source |
            egrep -v -z '^Source/kwsys/' |
            xargs -0 pcregrep -M --color=always -B 1 -A 1 -n \
              '<<[^\n]*\n(^ *<<[^\n]*(\\n"|<<|;)$\n){2,}'
      
      Surround such blocks with the pair
      
          /* clang-format off */
          ...
          /* clang-format on */
      
      in order to protect them from update by clang-format.  Use the C-style
      `/*...*/` comments instead of C++-style `//...` comments in order to
      prevent them from ever being swallowed by re-formatting of surrounding
      comments.
      64b55203
  28. 29 Apr, 2016 1 commit
    • Brad King's avatar
      Source: Stabilize include order · 180538c7
      Brad King authored
      Each source file has a logical first include file.  Include it in an
      isolated block so that tools that sort includes do not move them.
      180538c7
  29. 19 Feb, 2016 1 commit
    • Brad King's avatar
      try_compile: Add option to control type of target · 7f1bd9fe
      Brad King authored
      Create a `CMAKE_TRY_COMPILE_TARGET_TYPE` option to specify use
      of `add_library(... STATIC ...)` for the generated test project.
      This will be useful for cross-compiling toolchains that cannot
      link a binary without custom flags or scripts.
      7f1bd9fe
  30. 19 May, 2015 1 commit
  31. 20 Apr, 2015 1 commit
  32. 13 Apr, 2015 2 commits
  33. 08 Apr, 2015 2 commits
  34. 07 Apr, 2015 1 commit
    • Brad King's avatar
      Revert topic 'refactor-cache-api' · 3347c5e4
      Brad King authored
      This topic was never tested without some follow-up commits.  The
      GetCacheEntryValue API returns a pointer to memory freed on return.
      It will have to be revised along with the rest of the original topic.
      3347c5e4
  35. 06 Apr, 2015 1 commit
  36. 26 Jan, 2015 1 commit
    • Matt McCormick's avatar
      try_run: Add support for LINK_LIBRARIES option. · e2b1f058
      Matt McCormick authored
      Most functionality is already implemented in Source/cmCoreTryCompile.{h,cxx}.
      Document and improve argument parsing.
      
      This functionality is already being used by a number of modules, like
      CheckCSourceCompiles.cmake, but it is not documented.
      e2b1f058
  37. 18 Jan, 2015 2 commits