1. 06 Aug, 2019 1 commit
  2. 31 Jul, 2019 1 commit
  3. 30 Jul, 2019 4 commits
  4. 21 Jul, 2019 2 commits
  5. 17 Jul, 2019 1 commit
  6. 14 Jul, 2019 1 commit
  7. 10 Jul, 2019 1 commit
    • Brad King's avatar
      IWYU: Fix handling of <memory> standard header · 71fbebd1
      Brad King authored
      An old workaround for `std::allocator_traits<>::value_type` lints from
      IWYU on `std::vector<>` usage breaks IWYU's handling of `<memory>`.
      Convert the workaround to use the same approach we already use for a
      workaround of `std::__decay_and_strip<>::::__type` lints.  Then update
      the `<memory>` inclusions to follow the now-correct IWYU lints.
      71fbebd1
  8. 16 Jan, 2019 1 commit
  9. 20 Nov, 2018 1 commit
  10. 22 May, 2018 1 commit
    • florian jacomme's avatar
      Revise implementation of case-insensitive command names · b1a05d6c
      florian jacomme authored
      Store both the as-written and lower-case command names and use
      the latter to avoid case-insensitive string comparisons.
      
      With this I obtain 2-6% speed increase (on Windows) for the configure
      step with no significant changes in memory usage.  A case-insensitive
      comparison is a lot slower than just calling `==` because the operator
      will use things like memcmp, so prefer the latter.
      
      The `cmSystemTools::LowerCase` function allocates a new string each time
      it is called, so before this change we were allocating in:
      
      * cmMakefile::Configure two times for each function
        (to look for `cmake_minimum_required` and `project`)
      * cmMakefile::ExecuteCommand twice by function by calling
        cmState::GetCommand and copying the name
      
      Now we are only allocating once by function instead of four.
      b1a05d6c
  11. 25 Sep, 2017 1 commit
  12. 12 Sep, 2017 1 commit
  13. 09 May, 2017 1 commit
  14. 22 Mar, 2017 1 commit
  15. 26 Oct, 2016 1 commit
  16. 21 Oct, 2016 1 commit
  17. 27 Sep, 2016 1 commit
    • Brad King's avatar
      Simplify CMake per-source license notices · 86578ecc
      Brad King authored
      Per-source copyright/license notice headers that spell out copyright holder
      names and years are hard to maintain and often out-of-date or plain wrong.
      Precise contributor information is already maintained automatically by the
      version control tool.  Ultimately it is the receiver of a file who is
      responsible for determining its licensing status, and per-source notices are
      merely a convenience.  Therefore it is simpler and more accurate for
      each source to have a generic notice of the license name and references to
      more detailed information on copyright holders and full license terms.
      
      Our `Copyright.txt` file now contains a list of Contributors whose names
      appeared source-level copyright notices.  It also references version control
      history for more precise information.  Therefore we no longer need to spell
      out the list of Contributors in each source file notice.
      
      Replace CMake per-source copyright/license notice headers with a short
      description of the license and links to `Copyright.txt` and online information
      available from "https://cmake.org/licensing".  The online URL also handles
      cases of modules being copied out of our source into other projects, so we
      can drop our notices about replacing links with full license text.
      
      Run the `Utilities/Scripts/filter-notices.bash` script to perform the majority
      of the replacements mechanically.  Manually fix up shebang lines and trailing
      newlines in a few files.  Manually update the notices in a few files that the
      script does not handle.
      86578ecc
  18. 16 Sep, 2016 1 commit
  19. 29 Jun, 2016 1 commit
    • Brad King's avatar
      Avoid using KWSys auto_ptr by adopting it ourselves · b5ec5b09
      Brad King authored
      Replace use of cmsys::auto_ptr with a CM_AUTO_PTR macro that maps to
      our own implementation adopted from the KWSys auto_ptr implementation.
      Later we may be able to map CM_AUTO_PTR to std::auto_ptr on compilers
      that do not warn about it.
      
      Automate the client site conversions:
      
          git grep -l auto_ptr -- Source/ | grep -v Source/kwsys/ | xargs sed -i \
            's|cmsys::auto_ptr|CM_AUTO_PTR|;s|cmsys/auto_ptr.hxx|cm_auto_ptr.hxx|'
      b5ec5b09
  20. 13 Jun, 2016 1 commit
  21. 16 May, 2016 1 commit
    • Kitware Robot's avatar
      Revise C++ coding style using clang-format · d9fd2f54
      Kitware Robot authored
      Run the `Utilities/Scripts/clang-format.bash` script to update
      all our C++ code to a new style defined by `.clang-format`.
      Use `clang-format` version 3.8.
      
      * If you reached this commit for a line in `git blame`, re-run the blame
        operation starting at the parent of this commit to see older history
        for the content.
      
      * See the parent commit for instructions to rebase a change across this
        style transition commit.
      d9fd2f54
  22. 29 Apr, 2016 2 commits
    • Brad King's avatar
      Format include directive blocks and ordering with clang-format · e1c77472
      Brad King authored
      Sort include directives within each block (separated by a blank line) in
      lexicographic order (except to prioritize `sys/types.h` first).  First
      run `clang-format` with the config file:
      
          ---
          SortIncludes: false
          ...
      
      Commit the result temporarily.  Then run `clang-format` again with:
      
          ---
          SortIncludes: true
          IncludeCategories:
            - Regex:    'sys/types.h'
              Priority: -1
          ...
      
      Commit the result temporarily.  Start a new branch and cherry-pick the
      second commit.  Manually resolve conflicts to preserve indentation of
      re-ordered includes.  This cleans up the include ordering without
      changing any other style.
      
      Use the following command to run `clang-format`:
      
          $ git ls-files -z -- \
              '*.c' '*.cc' '*.cpp' '*.cxx' '*.h' '*.hh' '*.hpp' '*.hxx' |
            egrep -z -v '(Lexer|Parser|ParserHelper)\.' |
            egrep -z -v '^Source/cm_sha2' |
            egrep -z -v '^Source/(kwsys|CursesDialog/form)/' |
            egrep -z -v '^Utilities/(KW|cm).*/' |
            egrep -z -v '^Tests/Module/GenerateExportHeader' |
            egrep -z -v '^Tests/RunCMake/CommandLine/cmake_depends/test_UTF-16LE.h' |
            xargs -0 clang-format -i
      
      This selects source files that do not come from a third-party.
      Inspired-by: Daniel Pfeifer's avatarDaniel Pfeifer <daniel@pfeifer-mail.de>
      e1c77472
    • Brad King's avatar
      Source: Stabilize include order · 180538c7
      Brad King authored
      Each source file has a logical first include file.  Include it in an
      isolated block so that tools that sort includes do not move them.
      180538c7
  23. 15 Apr, 2016 1 commit
  24. 29 Mar, 2016 1 commit
  25. 20 Oct, 2015 1 commit
    • Stephen Kelly's avatar
      cmIfCommand: Issue CMP0054 warning with appropriate context. (#15802) · d6a03b47
      Stephen Kelly authored
      Commit v3.4.0-rc1~494^2~4 (cmMakefile: Add API for elseif to create
      backtrace., 2015-05-29) removed the use of cmMakefileCall to push/pop
      execution context in favor of a new way to create backtraces.
      
      However, a call to cmMakefile::GetExecutionContext is still invoked to
      issue a contextual CMP0054 warning through cmConditionEvaluator.  As
      the elseif is not part of the call stack, this resulted in trying to
      access an empty vector.
      
      Avoid the attempt at getting execution context when evaluating elseif by
      constructing a context and backtrace on behalf of the cmConditionEvaluator
      in all cases.
      d6a03b47
  26. 05 Oct, 2015 1 commit
  27. 06 Jul, 2015 2 commits
  28. 06 Jun, 2015 1 commit
  29. 02 Jun, 2015 1 commit
  30. 14 May, 2015 1 commit
  31. 22 Feb, 2015 1 commit
  32. 18 Jan, 2015 2 commits
  33. 01 Dec, 2014 1 commit