1. 14 Aug, 2019 1 commit
  2. 27 Mar, 2019 1 commit
    • Sebastian Holtermann's avatar
      cmDepends: Define DependencyMap instead of DependencyVector · 87341d83
      Sebastian Holtermann authored
      In `cmDepends` use
      `typedef std::map<std::string, std::vector<std::string>> DependencyMap`
      instead of defining a
      `class DependencyVector : public std::vector<std::string>`
      and using it in `std::map<std::string, DependencyVector>`.
      
      Since `std::map<std::string, std::vector<std::string>>` is used in various
      other places, we now reuse all of it's auto generated methods.  This doesn't
      happen when we use `DependencyVector` in a `std::map`, because it is a
      different class than `std::vector<std::string>`.
      87341d83
  3. 19 Mar, 2019 1 commit
    • Brad King's avatar
      Replace use of CollapseCombinedPath with CollapseFullPath · a13a5c94
      Brad King authored
      `CollapseCombinedPath` was introduced by commit 551d3343 (cmDependsC:
      Collapse relative include paths, 2013-06-19, v2.8.12~237^2) where the
      existing `CollapseFullPath` should have been used instead.  Then its use
      proliferated slightly.  Since `CollapseCombinedPath` is less widely used
      and less robust (see issue #19049), use `CollapseFullPath` everywhere
      instead.
      
      Issue: #19050
      a13a5c94
  4. 18 Mar, 2019 1 commit
  5. 13 Mar, 2019 1 commit
  6. 12 Mar, 2019 2 commits
  7. 20 Feb, 2019 1 commit
  8. 28 Jan, 2019 1 commit
  9. 27 Jan, 2019 1 commit
  10. 25 Jan, 2019 1 commit
    • wahikihiki's avatar
      clang-tidy: Use `= default` · 55671b41
      wahikihiki authored
      Suppress some cases in `Source/cmGeneratorExpressionNode.cxx` and
      `Source/cmUVHandlePtr.h` where a few older compilers require a
      user-defined default constructor (with `{}`).
      55671b41
  11. 18 Jan, 2019 1 commit
  12. 15 Dec, 2018 1 commit
  13. 07 Aug, 2018 1 commit
  14. 20 Mar, 2018 1 commit
    • tsecer's avatar
      Makefile: Restore use of dependency scanning cache · 8c0f12c4
      tsecer authored
      Since commit v2.8.0~27 (Major optimization of C/C++ dependency scanning,
      2009-09-23) our `VaildDeps` cache of `depend.internal` content is
      supposed to avoid re-scanning dependencies of object files whose
      dependencies have not changed.  However, this was broken by changes to
      `cmDependsC::WriteDependencies` by commit v3.1.0-rc1~272^2~1 (cmDepends:
      Refactor object file path conversion, 2014-07-22).  The object file path
      written to `depend.internal` was changed to a relative path, but the
      lookup in the `ValidDeps` cache of that information was not updated too.
      Therefore the cache is not used.
      
      Fix the object file path used for the `ValidDeps` lookup to restore the
      original optimization.
      8c0f12c4
  15. 31 Jan, 2018 1 commit
    • Pavel Solodovnikov's avatar
      Reduce raw string pointers usage. · 653b8946
      Pavel Solodovnikov authored
      * Change some functions to take `std::string` instead of
        `const char*` in the following classes: `cmMakeFile`, `cmake`,
        `cmCoreTryCompile`, `cmSystemTools`,  `cmState`, `cmLocalGenerator`
        and a few others.
      * Greatly reduce using of `const char*` overloads for
        `cmSystemTools::MakeDirectory` and `cmSystemTools::RelativePath`.
      * Remove many redundant `c_str()` conversions throughout the code.
      653b8946
  16. 26 Jan, 2018 1 commit
  17. 12 Sep, 2017 1 commit
  18. 27 Aug, 2017 1 commit
  19. 24 Aug, 2017 1 commit
  20. 01 Jun, 2017 2 commits
  21. 11 Apr, 2017 1 commit
    • Daniel Pfeifer's avatar
      Use quotes for non-system includes · 1d829c86
      Daniel Pfeifer authored
      Automate with:
      
      git grep -l '#include <cm_' -- Source \
        | xargs sed -i 's/#include <\(cm_.*\)>/#include "\1"/g'
      
      git grep -l '#include <cmsys/' -- Source \
        | xargs sed -i 's/#include <\(cmsys\/.*\)>/#include "\1"/g'
      
      git grep -l '#include <cm[A-Z]' -- Source \
        | xargs sed -i 's/#include <\(cm[A-Z].*\)>/#include "\1"/g'
      1d829c86
  22. 10 Jan, 2017 1 commit
  23. 08 Nov, 2016 1 commit
  24. 27 Sep, 2016 1 commit
    • Brad King's avatar
      Simplify CMake per-source license notices · 86578ecc
      Brad King authored
      Per-source copyright/license notice headers that spell out copyright holder
      names and years are hard to maintain and often out-of-date or plain wrong.
      Precise contributor information is already maintained automatically by the
      version control tool.  Ultimately it is the receiver of a file who is
      responsible for determining its licensing status, and per-source notices are
      merely a convenience.  Therefore it is simpler and more accurate for
      each source to have a generic notice of the license name and references to
      more detailed information on copyright holders and full license terms.
      
      Our `Copyright.txt` file now contains a list of Contributors whose names
      appeared source-level copyright notices.  It also references version control
      history for more precise information.  Therefore we no longer need to spell
      out the list of Contributors in each source file notice.
      
      Replace CMake per-source copyright/license notice headers with a short
      description of the license and links to `Copyright.txt` and online information
      available from "https://cmake.org/licensing".  The online URL also handles
      cases of modules being copied out of our source into other projects, so we
      can drop our notices about replacing links with full license text.
      
      Run the `Utilities/Scripts/filter-notices.bash` script to perform the majority
      of the replacements mechanically.  Manually fix up shebang lines and trailing
      newlines in a few files.  Manually update the notices in a few files that the
      script does not handle.
      86578ecc
  25. 19 Sep, 2016 4 commits
  26. 03 Sep, 2016 1 commit
  27. 27 Aug, 2016 1 commit
  28. 28 Jun, 2016 1 commit
  29. 10 Jun, 2016 1 commit
  30. 06 Jun, 2016 1 commit
  31. 02 Jun, 2016 1 commit
    • Daniel Pfeifer's avatar
      Simplify boolean expressions · 7f6b8d33
      Daniel Pfeifer authored
      Use clang-tidy's readability-simplify-boolean-expr checker.
      After applying the fix-its, revise all changes *very* carefully.
      Be aware of false positives and invalid changes.
      7f6b8d33
  32. 25 May, 2016 1 commit
    • Daniel Pfeifer's avatar
      Use enums defined in cmOutputConverter using their fully qualified name. · 25d1ef64
      Daniel Pfeifer authored
      Mostly automated:
      
      values=("RelativeRoot" "NONE" "FULL" "HOME" "START" "HOME_OUTPUT" "START_OUTPUT"
              "OutputFormat" "UNCHANGED" "MAKERULE" "SHELL" "WATCOMQUOTE" "RESPONSE"
              "FortranFormat" "FortranFormatNone" "FortranFormatFixed" "FortranFormatFree")
      for i in "${values[@]}"; do git grep -l cmLocalGenerator::$i | xargs sed -i "s|cmLocalGenerator::$i|cmOutputConverter::$i|g"; done
      25d1ef64
  33. 16 May, 2016 1 commit
    • Kitware Robot's avatar
      Revise C++ coding style using clang-format · d9fd2f54
      Kitware Robot authored
      Run the `Utilities/Scripts/clang-format.bash` script to update
      all our C++ code to a new style defined by `.clang-format`.
      Use `clang-format` version 3.8.
      
      * If you reached this commit for a line in `git blame`, re-run the blame
        operation starting at the parent of this commit to see older history
        for the content.
      
      * See the parent commit for instructions to rebase a change across this
        style transition commit.
      d9fd2f54
  34. 09 May, 2016 1 commit
    • Brad King's avatar
      Remove `//------...` horizontal separator comments · 0ac18d40
      Brad King authored
      Modern editors provide plenty of ways to visually separate functions.
      Drop the explicit comments that previously served this purpose.
      Use the following command to automate the change:
      
          $ git ls-files -z -- \
              "*.c" "*.cc" "*.cpp" "*.cxx" "*.h" "*.hh" "*.hpp" "*.hxx" |
            egrep -z -v "^Source/cmCommandArgumentLexer\." |
            egrep -z -v "^Source/cmCommandArgumentParser(\.y|\.cxx|Tokens\.h)" |
            egrep -z -v "^Source/cmDependsJavaLexer\." |
            egrep -z -v "^Source/cmDependsJavaParser(\.y|\.cxx|Tokens\.h)" |
            egrep -z -v "^Source/cmExprLexer\." |
            egrep -z -v "^Source/cmExprParser(\.y|\.cxx|Tokens\.h)" |
            egrep -z -v "^Source/cmFortranLexer\." |
            egrep -z -v "^Source/cmFortranParser(\.y|\.cxx|Tokens\.h)" |
            egrep -z -v "^Source/cmListFileLexer\." |
            egrep -z -v "^Source/cm_sha2" |
            egrep -z -v "^Source/(kwsys|CursesDialog/form)/" |
            egrep -z -v "^Utilities/(KW|cm).*/" |
            xargs -0 sed -i '/^\(\/\/---*\|\/\*---*\*\/\)$/ {d;}'
      
      This avoids modifying third-party sources and generated sources.
      0ac18d40
  35. 29 Apr, 2016 1 commit
    • Brad King's avatar
      Format include directive blocks and ordering with clang-format · e1c77472
      Brad King authored
      Sort include directives within each block (separated by a blank line) in
      lexicographic order (except to prioritize `sys/types.h` first).  First
      run `clang-format` with the config file:
      
          ---
          SortIncludes: false
          ...
      
      Commit the result temporarily.  Then run `clang-format` again with:
      
          ---
          SortIncludes: true
          IncludeCategories:
            - Regex:    'sys/types.h'
              Priority: -1
          ...
      
      Commit the result temporarily.  Start a new branch and cherry-pick the
      second commit.  Manually resolve conflicts to preserve indentation of
      re-ordered includes.  This cleans up the include ordering without
      changing any other style.
      
      Use the following command to run `clang-format`:
      
          $ git ls-files -z -- \
              '*.c' '*.cc' '*.cpp' '*.cxx' '*.h' '*.hh' '*.hpp' '*.hxx' |
            egrep -z -v '(Lexer|Parser|ParserHelper)\.' |
            egrep -z -v '^Source/cm_sha2' |
            egrep -z -v '^Source/(kwsys|CursesDialog/form)/' |
            egrep -z -v '^Utilities/(KW|cm).*/' |
            egrep -z -v '^Tests/Module/GenerateExportHeader' |
            egrep -z -v '^Tests/RunCMake/CommandLine/cmake_depends/test_UTF-16LE.h' |
            xargs -0 clang-format -i
      
      This selects source files that do not come from a third-party.
      Inspired-by: Daniel Pfeifer's avatarDaniel Pfeifer <daniel@pfeifer-mail.de>
      e1c77472