1. 10 Feb, 2015 1 commit
  2. 12 Jan, 2015 1 commit
  3. 11 Jan, 2015 1 commit
    • Evangelos Foutras's avatar
      FindRuby: Fix output check in _RUBY_CONFIG_VAR · 802d0aa0
      Evangelos Foutras authored
      Since commit v2.8.8~173^2 (FindRuby: clean up querying variables from
      Ruby, 2012-02-17) we query RbConfig::CONFIG first and, if the command
      fails or its output equates to a false constant, then fall back to
      querying Config::CONFIG.
      
      Due to the above, an error condition exists with Ruby 2.2.0; when
      querying RbConfig::CONFIG['TEENY'], the output of '0' will be discarded
      since it matches the false constant '0'.
      
      In previous versions this wasn't a problem, but Ruby 2.2 has completely
      removed Config::CONFIG. This causes RUBY_VERSION_PATCH to be set to an
      empty string and the Ruby version to be detected as '2.2.' (instead of
      '2.2.0').
      
      Fix the output check to explicitly look for an empty string before using
      the fallback query method. (Someone more familiar with Ruby might be
      able to deem the fallback as unnecessary and fully remove it.)
      802d0aa0
  4. 22 Oct, 2014 1 commit
  5. 28 Feb, 2014 1 commit
  6. 15 Oct, 2013 1 commit
  7. 18 Mar, 2013 1 commit
  8. 13 Aug, 2012 2 commits
    • Kitware Robot's avatar
      Remove CMake-language block-end command arguments · 9db31162
      Kitware Robot authored
      Ancient versions of CMake required else(), endif(), and similar block
      termination commands to have arguments matching the command starting the
      block.  This is no longer the preferred style.
      
      Run the following shell code:
      
      for c in else endif endforeach endfunction endmacro endwhile; do
          echo 's/\b'"$c"'\(\s*\)(.\+)/'"$c"'\1()/'
      done >convert.sed &&
      git ls-files -z -- bootstrap '*.cmake' '*.cmake.in' '*CMakeLists.txt' |
      egrep -z -v '^(Utilities/cm|Source/kwsys/)' |
      egrep -z -v 'Tests/CMakeTests/While-Endwhile-' |
      xargs -0 sed -i -f convert.sed &&
      rm convert.sed
      9db31162
    • Kitware Robot's avatar
      Convert CMake-language commands to lower case · 77543bde
      Kitware Robot authored
      Ancient CMake versions required upper-case commands.  Later command
      names became case-insensitive.  Now the preferred style is lower-case.
      
      Run the following shell code:
      
      cmake --help-command-list |
      grep -v "cmake version" |
      while read c; do
          echo 's/\b'"$(echo $c | tr '[:lower:]' '[:upper:]')"'\(\s*\)(/'"$c"'\1(/g'
      done >convert.sed &&
      git ls-files -z -- bootstrap '*.cmake' '*.cmake.in' '*CMakeLists.txt' |
      egrep -z -v '^(Utilities/cm|Source/kwsys/)' |
      xargs -0 sed -i -f convert.sed &&
      rm convert.sed
      77543bde
  9. 17 Feb, 2012 1 commit
    • Rolf Eike Beer's avatar
      FindRuby: clean up querying variables from Ruby · 854e7623
      Rolf Eike Beer authored
      Newer Ruby versions (from 1.9 onward) seem to warn if you query Config::CONFIG
      and print a warning to use RbConfig instead. RbConfig seems to also work in
      older versions, at least in 1.8. Use a macro to query RbConfig first and only
      if that doesn't give anything fall back to Config.
      854e7623
  10. 25 Jan, 2012 1 commit
    • Rolf Eike Beer's avatar
      FindRuby: do not blindly set version to 1.8.0 · 409aeafa
      Rolf Eike Beer authored
      RUBY_VERSION was always set, even if no RUBY_EXECUTABLE was found. While it
      may make sense to assume a default version if we can't execute the binary, it
      certainly doesn't make sense to report a version if there is no executable at
      all.
      409aeafa
  11. 05 Jan, 2012 3 commits
  12. 12 Oct, 2011 2 commits
  13. 20 Jan, 2011 1 commit
    • Brad King's avatar
      Modules: Include builtin FindPackageHandleStandardArgs directly · c4275592
      Brad King authored
      The FindPackageHandleStandardArgs module was originally created outside
      of CMake.  It was added for CMake 2.6.0 by commit e118a627 (add a macro
      FIND_PACKAGE_HANDLE_STANDARD_ARGS..., 2007-07-18).  However, it also
      proliferated into a number of other projects that at the time required
      only CMake 2.4 and thus could not depend on CMake to provide the module.
      CMake's own find modules started using the module in commit b5f656e0
      (use the new FIND_PACKAGE_HANDLE_STANDARD_ARGS in some of the FindXXX
      modules..., 2007-07-18).
      
      Then commit d358cf5c (add 2nd, more powerful mode to
      find_package_handle_standard_args, 2010-07-29) added a new feature to
      the interface of the module that was fully optional and backward
      compatible with all existing users of the module.  Later commit 5f183caa
      (FindZLIB: use the FPHSA version mode, 2010-08-04) and others shortly
      thereafter started using the new interface in CMake's own find modules.
      This change was also backward compatible because it was only an
      implementation detail within each module.
      
      Unforutnately these changes introduced a problem for projects that still
      have an old copy of FindPackageHandleStandardArgs in CMAKE_MODULE_PATH.
      When any such project uses one of CMake's builtin find modules the line
      
        include(FindPackageHandleStandardArgs)
      
      loads the copy from the project which does not have the new interface!
      Then the including find module tries to use the new interface with the
      old module and fails.
      
      Whether this breakage can be considered a backward incompatible change
      in CMake is debatable.  The situation is analagous to copying a standard
      library header from one version of a compiler into a project and then
      observing problems when the next version of the compiler reports errors
      in its other headers that depend on its new version of the original
      header.  Nevertheless it is a change to CMake that causes problems for
      projects that worked with previous versions.
      
      This problem was discovered during the 2.8.3 release candidate cycle.
      It is an instance of a more general problem with projects that provide
      their own versions of CMake modules when other CMake modules depend on
      them.  At the time we resolved this instance of the problem with commit
      b0118402 (Use absolute path to FindPackageHandleStandardArgs.cmake
      everywhere, 2010-09-28) for the 2.8.3 release.
      
      In order to address the more general problem we introduced policy
      CMP0017 in commit db44848f (Prefer files from CMAKE_ROOT when including
      from CMAKE_ROOT, 2010-11-17).  That change was followed by commit
      ce28737c (Remove usage of CMAKE_CURRENT_LIST_DIR now that we have
      CMP0017, 2010-12-20) which reverted the original workaround in favor of
      using the policy.  However, existing project releases do not set the
      policy behavior to NEW and therefore still exhibit the problem.
      
      We introduced in commit a364daf1 (Allow users to specify defaults for
      unset policies, 2011-01-03) an option for users to build existing
      projects by adding -DCMAKE_POLICY_DEFAULT_CMP0017=NEW to the command
      line.  Unfortunately this solution still does not allow such projects to
      build out of the box, and there is no good way to suggest the use of the
      new option.
      
      The only remaining solution to keep existing projects that exhibit this
      problem building is to restore the change originally made in commit
      b0118402 (Use absolute path to FindPackageHandleStandardArgs.cmake
      everywhere, 2010-09-28).  This also avoids policy CMP0017 warnings for
      this particular instance of the problem the policy addresses.
      c4275592
  14. 04 Jan, 2011 1 commit
  15. 28 Sep, 2010 1 commit
  16. 09 Aug, 2010 1 commit
  17. 07 Aug, 2010 1 commit
  18. 28 Jan, 2010 1 commit
  19. 27 Jan, 2010 1 commit
  20. 03 Jan, 2010 1 commit
  21. 01 Oct, 2009 1 commit
  22. 28 Sep, 2009 1 commit
    • Brad King's avatar
      Convert CMake find-modules to BSD License · c4bb9c9d
      Brad King authored
      This adds copyright/license notification blocks CMake's find-modules.
      Many of the modules had no notices at all.  Some had notices referring
      to the BSD license already.  This commit normalizes existing notices and
      adds missing notices.
      c4bb9c9d
  23. 26 Sep, 2009 1 commit
  24. 12 Sep, 2009 2 commits
  25. 02 Jan, 2008 2 commits
  26. 07 Dec, 2006 1 commit
  27. 04 Oct, 2006 1 commit
  28. 15 Dec, 2005 1 commit
  29. 14 Dec, 2005 1 commit
  30. 07 Apr, 2005 2 commits
  31. 30 Apr, 2004 1 commit