1. 25 Mar, 2019 1 commit
    • Brad King's avatar
      Restore support for include_directories() in toolchain files · 588fa1bb
      Brad King authored
      Any `include_directories()` calls in toolchain files are used during our
      ABI detection step even though it does not include any system headers.
      Since commit 5990ecb7 (Compute implicit include directories from
      compiler output, 2018-12-07, v3.14.0-rc1~108^2), that check is also used
      to detect implicit include directories.  Any `include_directories()` in
      a toolchain file are detected as implicit and later excluded from
      explicit specification on compiler command lines, thus breaking the
      purpose of the calls in the first place.
      
      Fix the implicit include directory detection step to avoid using paths
      from `include_directories()` calls in the toolchain file.
      
      Fixes: #19079
      588fa1bb
  2. 14 Jul, 2016 1 commit
  3. 06 Jul, 2016 1 commit
    • Brad King's avatar
      Honor CMAKE_<LANG>_FLAGS[_<CONFIG>]_INIT set in toolchain files · a66004be
      Brad King authored
      Document these variables.
      
      Change our convention for setting these variables from:
      
          set(CMAKE_C_FLAGS_INIT "...")
      
      to
      
          string(APPEND CMAKE_C_FLAGS_INIT " ...")
      
      so that any value previously set by a toolchain file will be used.
      
      Automate the conversion with:
      
          sed -i 's/set *(\(CMAKE_\(C\|CXX\|Fortran\|RC\|ASM\|${[^}]\+}\)_FLAGS\(_[^_]\+\)\?_INIT \+"\)/string(APPEND \1 /' \
            Modules/Compiler/*.cmake Modules/Platform/*.cmake
      
      and follow up with some manual fixes (e.g. to cases that already
      meant to append).  Also revert the automated changes to contexts
      that are not protected from running multiple times.
      a66004be
  4. 07 Mar, 2016 1 commit