Commit 94332a3e authored by Brad King's avatar Brad King Committed by Kitware Robot

Merge topic 'ninja-no-static-lib-def-file'

47ffa0ea Ninja: Do not use module definition `.def` files for static libraries
parents 8a8aff61 47ffa0ea
......@@ -63,6 +63,13 @@ void cmCommonTargetGenerator::AddFeatureFlags(std::string& flags,
void cmCommonTargetGenerator::AddModuleDefinitionFlag(
cmLinkLineComputer* linkLineComputer, std::string& flags)
// A module definition file only makes sense on certain target types.
if (this->GeneratorTarget->GetType() != cmStateEnums::SHARED_LIBRARY &&
this->GeneratorTarget->GetType() != cmStateEnums::MODULE_LIBRARY &&
this->GeneratorTarget->GetType() != cmStateEnums::EXECUTABLE) {
if (!this->ModuleDefinitionFile) {
Markdown is supported
0% or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment