Skip to content
GitLab
  • Menu
Projects Groups Snippets
  • /
  • Help
    • Help
    • Support
    • Community forum
    • Submit feedback
    • Contribute to GitLab
  • Sign in / Register
  • CMake CMake
  • Project information
    • Project information
    • Activity
    • Labels
    • Members
  • Repository
    • Repository
    • Files
    • Commits
    • Branches
    • Tags
    • Contributors
    • Graph
    • Compare
  • Issues 3,924
    • Issues 3,924
    • List
    • Boards
    • Service Desk
    • Milestones
  • Merge requests 16
    • Merge requests 16
  • CI/CD
    • CI/CD
    • Pipelines
    • Jobs
    • Schedules
  • Deployments
    • Deployments
    • Releases
  • Packages & Registries
    • Packages & Registries
    • Container Registry
  • Analytics
    • Analytics
    • Value stream
    • CI/CD
    • Repository
  • External wiki
    • External wiki
  • Activity
  • Graph
  • Create a new issue
  • Jobs
  • Commits
  • Issue Boards
Collapse sidebar
  • CMake
  • CMakeCMake
  • Merge requests
  • !7446

Makefiles: Count explicitly included targets in progress total

  • Review changes

  • Download
  • Email patches
  • Plain diff
Closed Adriaan de Groot requested to merge adridg/cmake:issue-21867a into master Jul 05, 2022
  • Overview 3
  • Commits 1
  • Pipelines 2
  • Changes 1

A target that is explicitly included (e.g. has explicitly set EXCLUDE_FROM_ALL to FALSE) needs to be added in directories that are above the source directory where the target is defined, so that it gets counted towards ALL. This affects targets where the directory containing the target is excluded, but the target itself is included; these are either counted double or not at all in previous CMake versions.

Fixes: #21867

Assignee
Assign to
Reviewer
Request review from
Time tracking
Source branch: issue-21867a