Skip to content
GitLab
Projects Groups Topics Snippets
  • /
  • Help
    • Help
    • Support
    • Community forum
    • Submit feedback
    • Contribute to GitLab
  • Register
  • Sign in
  • CMake CMake
  • Project information
    • Project information
    • Activity
    • Labels
    • Members
  • Repository
    • Repository
    • Files
    • Commits
    • Branches
    • Tags
    • Contributor statistics
    • Graph
    • Compare revisions
  • Issues 4,161
    • Issues 4,161
    • List
    • Boards
    • Service Desk
    • Milestones
  • Merge requests 14
    • Merge requests 14
  • CI/CD
    • CI/CD
    • Pipelines
    • Jobs
    • Schedules
  • Deployments
    • Deployments
    • Releases
  • Packages and registries
    • Packages and registries
    • Container Registry
  • Analytics
    • Analytics
    • Value stream
    • CI/CD
    • Repository
  • External wiki
    • External wiki
  • Activity
  • Graph
  • Create a new issue
  • Jobs
  • Commits
  • Issue Boards
Collapse sidebar
  • CMakeCMake
  • CMakeCMake
  • Merge requests
  • !7390

FindGLEW: Set documented variables when found via upstream package

  • Review changes

  • Download
  • Email patches
  • Plain diff
Merged Markus Mützel requested to merge mmuetzel/cmake:glew into master Jun 20, 2022
  • Overview 7
  • Commits 1
  • Pipelines 3
  • Changes 1

When GLEW is found by find_package, (most of) the variables described in the documentation of FindGLEW 1 aren't set. That could lead to issues when building packages that rely on these variables.

This PR basically uses the same logic that vcpkg is using to populate these variables. 2 IANAL, but their license should be compatible afaict.

Fixes #19662 (closed)

Edited Jun 21, 2022 by Brad King
Assignee
Assign to
Reviewers
Request review from
Time tracking
Source branch: glew