Skip to content

GitLab

  • Menu
Projects Groups Snippets
  • Help
    • Help
    • Support
    • Community forum
    • Submit feedback
    • Contribute to GitLab
  • Sign in / Register
  • CMake CMake
  • Project information
    • Project information
    • Activity
    • Labels
    • Members
  • Repository
    • Repository
    • Files
    • Commits
    • Branches
    • Tags
    • Contributors
    • Graph
    • Compare
  • Issues 3,818
    • Issues 3,818
    • List
    • Boards
    • Service Desk
    • Milestones
  • Merge requests 8
    • Merge requests 8
  • CI/CD
    • CI/CD
    • Pipelines
    • Jobs
    • Schedules
  • Deployments
    • Deployments
    • Releases
  • Packages & Registries
    • Packages & Registries
    • Container Registry
  • Analytics
    • Analytics
    • Value stream
    • CI/CD
    • Repository
  • External wiki
    • External wiki
  • Activity
  • Graph
  • Create a new issue
  • Jobs
  • Commits
  • Issue Boards
Collapse sidebar
  • CMake
  • CMakeCMake
  • Merge requests
  • !552

Server refactor

  • Review changes

  • Download
  • Email patches
  • Plain diff
Merged jdavidberger requested to merge jdavidberger/cmake:server-refactor into master Mar 05, 2017
  • Overview 104
  • Commits 4
  • Pipelines 32
  • Changes 15

This MR is as requested from !483 (closed)

Main contributions of this MR:

  • Separate out connection logic from buffering strategy logic
  • Moved minor protocol issues out of connection class (namely send greeting)
  • Moved ownership of event loop to server class
  • Added semaphore wakeup (libuv_async) to server so that new reads / writes would not stall the other loop events
  • Differentiated between responding to a specific request/connection and broadcast to all connections. This allows for (eventually) multiple connections per server.

The first commit in the MR is a little heavier than I'd like and I can split it out more if needed.

Assignee
Assign to
Reviewer
Request review from
Time tracking
Source branch: server-refactor