Skip to content
GitLab
Projects Groups Snippets
  • /
  • Help
    • Help
    • Support
    • Community forum
    • Submit feedback
    • Contribute to GitLab
  • Register
  • Sign in
  • CMake CMake
  • Project information
    • Project information
    • Activity
    • Labels
    • Members
  • Repository
    • Repository
    • Files
    • Commits
    • Branches
    • Tags
    • Contributors
    • Graph
    • Compare
  • Issues 4,157
    • Issues 4,157
    • List
    • Boards
    • Service Desk
    • Milestones
  • Merge requests 13
    • Merge requests 13
  • CI/CD
    • CI/CD
    • Pipelines
    • Jobs
    • Schedules
  • Deployments
    • Deployments
    • Releases
  • Packages and registries
    • Packages and registries
    • Container Registry
  • Analytics
    • Analytics
    • Value stream
    • CI/CD
    • Repository
  • External wiki
    • External wiki
  • Activity
  • Graph
  • Create a new issue
  • Jobs
  • Commits
  • Issue Boards
Collapse sidebar
  • CMakeCMake
  • CMakeCMake
  • Merge requests
  • !5047

WIP: Module/Platform: Factor out repeated distro detection code

  • Review changes

  • Download
  • Email patches
  • Plain diff
Closed Andreas Sturmlechner requested to merge asturm/cmake:platform.cmake into master Jul 22, 2020
  • Overview 6
  • Commits 4
  • Pipelines 2
  • Changes 10

This work was spawned by a Gentoo Prefix downstream report: https://bugs.gentoo.org/733480

Gentoo Prefix is an installation of Gentoo on an offset location on e.g. another distribution or even MacOS or Windows.

The problem is that cmake inside the Prefix installation makes wrong assumptions if the root distribution is e.g. Debian. cmake modules in various places are making checks if /etc/debian_version exists (/etc/arch-release in one place) to guess libdir name. This MR would move that check to one central place and provides an override option to not perform these detections. It could in the future also be expanded with further special cases if need be.

Edited Jul 29, 2020 by Brad King
Assignee
Assign to
Reviewers
Request review from
Time tracking
Source branch: platform.cmake