Darwin: prefix internal osx variables with "_" to hide them from users (!4967) · Merge requests · CMake / CMake

chuck cranor requested to merge chuck/cmake:darwin-init-var-cleanup into master Jul 02, 2020

A simple CMakeLists.txt on osx shows that variable "d" is set (but empty) by the system modules. this pollutes the user's variable namespace. I noticed this when I created a library target "d" and got unexpected policy CMP0054 warnings when trying to find_package(d CONFIG REQUIRED) (triggered from the generated "d-targets.cmake" ...). Note that non-"_" prefixed internal variables are ok within functions due to scoping rules.

Fixes #20898 (closed).

Edited Jul 02, 2020 by Brad King

Darwin: prefix internal osx variables with "_" to hide them from users

Merge request reports