Skip to content
GitLab
  • Menu
Projects Groups Snippets
  • /
  • Help
    • Help
    • Support
    • Community forum
    • Submit feedback
    • Contribute to GitLab
  • Sign in / Register
  • CMake CMake
  • Project information
    • Project information
    • Activity
    • Labels
    • Members
  • Repository
    • Repository
    • Files
    • Commits
    • Branches
    • Tags
    • Contributors
    • Graph
    • Compare
  • Issues 3,928
    • Issues 3,928
    • List
    • Boards
    • Service Desk
    • Milestones
  • Merge requests 19
    • Merge requests 19
  • CI/CD
    • CI/CD
    • Pipelines
    • Jobs
    • Schedules
  • Deployments
    • Deployments
    • Releases
  • Packages & Registries
    • Packages & Registries
    • Container Registry
  • Analytics
    • Analytics
    • Value stream
    • CI/CD
    • Repository
  • External wiki
    • External wiki
  • Activity
  • Graph
  • Create a new issue
  • Jobs
  • Commits
  • Issue Boards
Collapse sidebar
  • CMake
  • CMakeCMake
  • Merge requests
  • !493

VS: force Win10 SDK be chosen for VS2017

  • Review changes

  • Download
  • Email patches
  • Plain diff
Closed gnaggnoyil requested to merge gnaggnoyil/cmake:master into master Feb 17, 2017
  • Overview 9
  • Commits 1
  • Pipelines 4
  • Changes 2

Visual Studio 2017 currently only have Win10 SDK bundled while would still switch to choose Win8.1 SDK without <WindowsTargetPlatformVersion> property set in Visual Studip project file. Therefore, the fact that CMake used to choose correct Win10 SDK only on Windows 10 and later even for Visual Studio 2017 Generator leads to the result that Visual Studio 2017 would report "Could not locate Win8.1 SDK" error when building targets on systems such as Window 7, especially for cases in 'try_run' command where CMake variables seems not to work there.

This patch is intended to fix the problem described above.

Assignee
Assign to
Reviewer
Request review from
Time tracking
Source branch: master